Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1167146

Re: [PATCH v2 1/2] vTPM: support little endian guests

Show all headers | View raw

Hi Ashley,

Ah, good catch.  I think I can only join the first two lines (where the
assignments are) and will have to leave the rest splitted. I'll resubmit
this one soon.

Thanks for the review!  


Vicky
On Tue, 2015-06-16 at 20:17 -0500, Ashley Lai wrote:
> Just a small comment otherwise it looks good.
> 
> On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote:
> > 	case NONHOST_INFO:
> > -		name = tcpa_event_type_strings[event->event_type];
> > +		name =
> > +		    tcpa_event_type_strings[do_endian_conversion
> > +					    (event->event_type)];
> Not being picky but if it does not exceed 80 characters it looks better
> to join the line above.
>                 name = tcpa_event_type_strings[do_endian_conversion
>                                                (event->event_type)];
> 
> > 		case POST_CONTENTS:
> > -			name = tcpa_pc_event_id_strings[pc_event->event_id];
> > +			name =
> > +			    tcpa_pc_event_id_strings[do_endian_conversion
> > +						     (pc_event->event_id)];
> Same as above.
> 
> Thanks,
> --Ashley Lai
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] vTPM: support little endian guests "Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com> - 2015-06-10 04:00 +0200
  Re: [PATCH v2 1/2] vTPM: support little endian guests "Hon Ching (Vicky) Lo" <honclo@linux.vnet.ibm.com> - 2015-06-17 23:20 +0200

csiph-web