Re: [PATCH 3/5] vhost: support upto 509 memory regions

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] vhost: support upto 509 memory regions
Date	2015-06-19 10:00 +0200
Message-ID	<pCZnr-17v-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <pCGEa-7zg-9@gated-at.bofh.it> <pCHTz-16G-17@gated-at.bofh.it> <pCImC-1Ew-21@gated-at.bofh.it> <pCJiG-30U-17@gated-at.bofh.it> <pCKy6-4Yo-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 18, 2015 at 06:02:46PM +0200, Paolo Bonzini wrote:
> 
> 
> On 18/06/2015 16:47, Michael S. Tsirkin wrote:
> >> However, with Igor's patches a memory_region_del_subregion will cause a
> >> mmap(MAP_NORESERVE), which _does_ have the effect of making the hva go away.
> >>
> >> I guess one way to do it would be to alias the same page in two places,
> >> one for use by vhost and one for use by everything else.  However, the
> >> kernel does not provide the means to do this kind of aliasing for
> >> anonymous mmaps.
> > 
> > Basically pages go away on munmap, so won't simple
> > 	lock
> > 	munmap
> > 	mmap(MAP_NORESERVE)
> > 	unlock
> > do the trick?
> 
> Not sure I follow.  Here we have this:
> 
>     VCPU 1                             VCPU 2                          I/O worker
>     ----------------------------------------------------------------------------------------
>     take big QEMU lock
>     p = address_space_map(hva, len)
>     pass I/O request to worker thread
>                                                                        read(fd, p, len)
>     release big QEMU lock
> 
>                                         memory_region_del_subregion
>                                           mmap(MAP_NORESERVE)
> 
>                                                                        read returns EFAULT

Why doesn't it EFAULT without mmap(MAP_NORESERVE)?
Doesn't memory_region_del_subregion free the memory?

>                                                                        wake up VCPU 1
>     take big QEMU lock
>     EFAULT?  What's that?
> 
> In another scenario you are less lucky: the memory accesses
> between address_space_map/unmap aren't done in the kernel and
> you get a plain old SIGSEGV.
> 
> This is not something that you can fix with a lock.  The very
> purpose of the map/unmap API is to do stuff asynchronously while
> the lock is released.
> 
> Thanks,
> 
> Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/5] vhost: support upto 509 memory regions "Michael S. Tsirkin" <mst@redhat.com> - 2015-06-19 10:00 +0200
  Re: [PATCH 3/5] vhost: support upto 509 memory regions Paolo Bonzini <pbonzini@redhat.com> - 2015-06-19 10:00 +0200
    Re: [PATCH 3/5] vhost: support upto 509 memory regions "Michael S. Tsirkin" <mst@redhat.com> - 2015-06-19 10:10 +0200
      Re: [PATCH 3/5] vhost: support upto 509 memory regions Paolo Bonzini <pbonzini@redhat.com> - 2015-06-19 11:00 +0200
        Re: [PATCH 3/5] vhost: support upto 509 memory regions "Michael S. Tsirkin" <mst@redhat.com> - 2015-06-19 15:40 +0200

csiph-web