Re: [PATCH v2 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Paul Bolle <pebolle@tiscali.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit
Date	Fri, 19 Jun 2015 09:40:01 +0200
Message-ID	<pCZ45-KN-9@gated-at.bofh.it> (permalink)
References	<pCHJT-V5-11@gated-at.bofh.it> <pCHJT-V5-17@gated-at.bofh.it>
X-Original-To	Cyrille Pitchen <cyrille.pitchen@atmel.com>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.10.4 (3.10.4-4.fc20)
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org
X-Original-Date	Fri, 19 Jun 2015 09:34:33 +0200
X-Original-Message-ID	<1434699273.2385.139.camel@x220>
X-Original-References	<cover.1434632230.git.cyrille.pitchen@atmel.com> <bc25d9365ba31f987437ff4f0f2ee60c19639270.1434632230.git.cyrille.pitchen@atmel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1168583

Show key headers only | View raw

On Thu, 2015-06-18 at 15:05 +0200, Cyrille Pitchen wrote:
> --- /dev/null
> +++ b/drivers/mfd/atmel-flexcom.c

> +MODULE_ALIAS("platform:atmel_flexcom");

(The day before yesterday and yesterday I had a, well, lively
conversation regarding this macro. The interesting bits start at
https://lkml.org/lkml/2015/6/17/383 . Let's see how things go here.)

As I understand it, this alias is only useful if there's a corresponding
struct platform_device, somewhere. Ie, this alias implies a
platform_device that will fire of a "MODALIAS=platform:atmel_flexcom"
uevent when it's created. That would be a platform_device using a
"atmel_flexcom" name.

If that's correct, then I think this MODULE_ALIAS macro isn't needed
here, as I couldn't find a platform_device using that name. (But perhaps
a patch that adds it is pending, somewhere.)

Thanks,

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] mfd: flexcom: add a driver for Atmel Flexible  Serial Communication Unit Paul Bolle <pebolle@tiscali.nl> - 2015-06-19 09:40 +0200

csiph-web