Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1168262

Re: [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug

From Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug
Date 2015-06-18 22:10 +0200
Message-ID <pCOim-1Z7-5@gated-at.bofh.it> (permalink)
References <pCN2W-8tp-19@gated-at.bofh.it> <pCNZ0-1nf-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/18/2015 12:47 PM, Thomas Gleixner wrote:
>> > @@ -1239,12 +1239,15 @@ static inline void cqm_pick_event_reader(int cpu)
>> >  	int phys_id = topology_physical_package_id(cpu);
>> >  	int i;
>> >  
>> > +	mutex_lock(&cache_mutex);
> I already explained it to Vikas. You CANNOT take a mutex in that code
> path as it runs with interrupts disabled on a CPU which cannot
> schedule.

How did lockdep not blow up and scream about this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug Thomas Gleixner <tglx@linutronix.de> - 2015-06-18 21:50 +0200
  Re: [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug Dave Hansen <dave.hansen@linux.intel.com> - 2015-06-18 22:10 +0200
    Re: [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug Thomas Gleixner <tglx@linutronix.de> - 2015-06-18 22:10 +0200

csiph-web