Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1168250

Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init
Date Thu, 18 Jun 2015 21:40:02 +0200
Message-ID <pCNPk-1bG-9@gated-at.bofh.it> (permalink)
References <pCLaN-5HL-5@gated-at.bofh.it> <pCLaN-5HL-3@gated-at.bofh.it> <pCNmi-E4-7@gated-at.bofh.it>
X-Original-To Alexandre Belloni <alexandre.belloni@free-electrons.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23+89 (0255b37be491) (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc Nicholas Krause <xerofoify@gmail.com>, balbi@ti.com, nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, peter.chen@freescale.com, ronald.wahl@raritan.com, voice.shen@atmel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 18 Jun 2015 12:31:13 -0700
X-Original-Message-ID <20150618193113.GA21756@kroah.com>
X-Original-References <1430709902-10815-1-git-send-email-xerofoify@gmail.com> <20150618164114.GS27492@piout.net> <20150618190452.GT27492@piout.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1168250

Show key headers only | View raw


On Thu, Jun 18, 2015 at 09:04:52PM +0200, Alexandre Belloni wrote:
> On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote :
> > On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote :
> > > This simplifies the error checking of the function,at91sam9261_udc_init
> > > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary
> > > if statement to check the return value of a call to the function,
> > > syscon_regmap_lookup_by_phandle by checking with a call to the function,
> > > IS_ERR and returning a error pointer if there is one for the function,
> > > at91sam9261_udc_init. Furthermore this was found by running coccinelle
> > > against the lastest kernel tree.
> > > 
> > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > 
> 
> OK, it seems the original patch got ignored by all the mailing lists. To
> bad, that one was actually applicable :)

Nick is banned from vger.kernel.org, so that is why his patches will not
ever show up.  I recommend that you do the same if possible.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] usb:gadget:Simplify the error checking of the  function,at91sam9261_udc_init Greg KH <gregkh@linuxfoundation.org> - 2015-06-18 21:40 +0200

csiph-web