Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1166355

Re: [PATCH] tmpfs: truncate at i_size

From Josef Bacik <jbacik@fb.com>
Newsgroups linux.kernel
Subject Re: [PATCH] tmpfs: truncate at i_size
Date 2015-06-16 22:10 +0200
Message-ID <pC5lg-4rn-9@gated-at.bofh.it> (permalink)
References <prRCW-2bB-15@gated-at.bofh.it> <pC5lg-4rn-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/16/2015 01:02 PM, Hugh Dickins wrote:
> On Tue, 19 May 2015, Josef Bacik wrote:
>
>> If we fallocate past i_size with KEEP_SIZE, extend the file to use some but not
>> all of this space, and then truncate(i_size) we won't trim the excess
>> preallocated space.  We decided at LSF that we want to truncate the fallocated
>> bit past i_size when we truncate to i_size, which is what this patch does.
>> Thanks,
>>
>> Signed-off-by: Josef Bacik <jbacik@fb.com>
>
> Sorry for the delay, it's been on my mind but only now I get to it.
> Yes, that was agreed at LSF, and I've checked that indeed tmpfs is
> out of line here: thank you for fixing it.  But I do prefer your
> original more explicit description, so I'll send the patch to akpm
> now for v4.2, with that description instead (plus a reference to LSF).
>

Sounds good, thanks Hugh.

Josef

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] tmpfs: truncate at i_size Josef Bacik <jbacik@fb.com> - 2015-06-16 22:10 +0200

csiph-web