Re: [PATCH 1/4] x86: Add basic support for the Congatec CGEB BIOS interface

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Christian Gmeiner <christian.gmeiner@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] x86: Add basic support for the Congatec CGEB BIOS interface
Date	Mon, 15 Jun 2015 09:30:01 +0200
Message-ID	<pBx0d-4YA-7@gated-at.bofh.it> (permalink)
References	<pAhAe-fl-21@gated-at.bofh.it> <pAhAe-fl-19@gated-at.bofh.it> <pAtBo-1q2-27@gated-at.bofh.it>
X-Original-To	Paul Bolle <pebolle@tiscali.nl>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wBHsj5LTwSX49wJWYILOqzgXotHiiat4WJrZyD+Exdw=; b=esjoGbtEgIAunTW1McNj9Iqs13D8csnpMlRReJDB2TKSTdzIs3+W0y+fGHhI84ABBm 7hdS5SI0oyOWrotY/0KwAuy4l30A+QtodPgLLD2m8LOqH6OLZ+LoeLGovQNnJaIOFIt2 rrylZClSdMH8TdfibpyhWeqCF51xMlYoauZypYaEfR0oaZrt2Db7imxmnJxB0DKGMbHr EACCCStTct+gobLQJ42Qlgnj8PL7iVpfg6d6iJA11TGE7NPaxoTO6oq7h5gXNDxV50pK UPWUpmAxg0Mf7+Su/vBafNbU+GfyQ7f0EqsC9q1fuRDW3NGCFu7THeo9JrfTYkAO64+4 kouA==
X-Received	by 10.194.178.201 with SMTP id da9mr48757513wjc.139.1434353086115; Mon, 15 Jun 2015 00:24:46 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	83
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Wolfram Sang <wsa@the-dreams.de>, jdelvare@suse.de, linux-i2c@vger.kernel.org, wim@iguana.be, linux-watchdog@vger.kernel.org, jingoohan1@gmail.com, Sascha Hauer <s.hauer@pengutronix.de>
X-Original-Date	Mon, 15 Jun 2015 09:24:25 +0200
X-Original-Message-ID	<CAH9NwWfJS7e_=NFUQgiDB4BOETxYn9oreKT0Md9q6N9eLJd3Rw@mail.gmail.com>
X-Original-References	<1434055734-3602-1-git-send-email-christian.gmeiner@gmail.com> <1434055734-3602-2-git-send-email-christian.gmeiner@gmail.com> <1434101718.2271.166.camel@x220>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1165057

Show key headers only | View raw

Hi Paul

Thanks for looking over my patches!

2015-06-12 11:35 GMT+02:00 Paul Bolle <pebolle@tiscali.nl>:
> A few nits.
>
> On Thu, 2015-06-11 at 22:48 +0200, Christian Gmeiner wrote:
>> --- /dev/null
>> +++ b/drivers/mfd/congatec-cgeb.c
>
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; version 2 of the License.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>
>> +/*
>> + * cgeb_invoke - invoke CGEB BIOS call.
>
> s/cgeb_invoke/cgeb_call/
>

ok

>> + *
>> + * @board:     board context data
>> + * @p:         CGEB parameters for this call
>> + * @fct:       CGEB function code
>> + * @return:    0 on success or negative error code on failure.
>> + *
>> + * Call the CGEB BIOS code with the given parameters.
>> + */
>> +unsigned int cgeb_call(struct cgeb_board_data *board,
>> +              struct cgeb_function_parameters *p, cgeb_function_t fct)
>> +{
>> +     [...]
>> +}
>
>> +static int __init cgeb_init(void)
>> +{
>> +     [...]
>> +}
>> +
>> +static void cgeb_exit(void)
>> +{
>> +     [...]
>> +}
>> +
>> +module_init(cgeb_init);
>> +module_exit(cgeb_exit);
>
> cgeb_exit is only used through module_exit(). So I guess it could be
> marked __exit, right?
>

That is correct - will be fixed in v2.

>> +MODULE_LICENSE("GPL");
>
> The comment at the top of this file states the license is GPL v2. The
> MODULE_LICENSE() macro states, according to include/linux/module.h, that
> the license is GPL v2 or later. So I think one of these two needs to
> change.
>
> I spotted the same license mismatch in 2/4, 3/4 and 4/4.
>

Will be fixed in v2.

Thanks
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] x86: Add basic support for the Congatec CGEB BIOS interface Christian Gmeiner <christian.gmeiner@gmail.com> - 2015-06-11 22:50 +0200
  Re: [PATCH 1/4] x86: Add basic support for the Congatec CGEB BIOS interface Christian Gmeiner <christian.gmeiner@gmail.com> - 2015-06-15 09:30 +0200

csiph-web