Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)
Date	2015-06-15 08:40 +0200
Message-ID	<pBwdP-3OT-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <pAHkZ-4SF-1@gated-at.bofh.it> <pAPix-7L0-5@gated-at.bofh.it> <pAWtH-1rb-3@gated-at.bofh.it> <pAWWK-1ZU-3@gated-at.bofh.it> <pBuYp-27I-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-06-15 at 10:47 +0530, Sudip Mukherjee wrote:
> On Sat, Jun 13, 2015 at 09:57:05AM -0700, Joe Perches wrote:
> > It's unfortunate there are so many #ifdef __BIG_ENDIAN uses.
> instead of #ifdef __BIG_ENDIAN can i then use a bool flag to check by if-else?

I think that'd be worse.  Moving the #ifdef into the .h
may be better, but <shrug>, whatever works well enough.

Another thing may be to move the vgamode array declaration
in fb7xx.h to the .c file and make it const and remove the
#define numvgamodes and just use ARRAY_SIZE directly in
the one place it's used.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus  driver Greg KH <gregkh@linuxfoundation.org> - 2015-06-13 02:20 +0200
  doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New  functionality to the MC bus driver) Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-13 10:50 +0200
    Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc:  New functionality to the MC bus driver) Greg KH <gregkh@linuxfoundation.org> - 2015-06-13 18:30 +0200
      Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc:  New functionality to the MC bus driver) Joe Perches <joe@perches.com> - 2015-06-13 19:00 +0200
        Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc:  New functionality to the MC bus driver) Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-15 07:20 +0200
          Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc:  New functionality to the MC bus driver) Joe Perches <joe@perches.com> - 2015-06-15 08:40 +0200

csiph-web