Re: why do we need vmalloc_sync_all?

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: why do we need vmalloc_sync_all?
Date	2015-06-14 22:10 +0200
Message-ID	<pBmo9-6xN-3@gated-at.bofh.it> (permalink)
References	<pAQeC-Ge-7@gated-at.bofh.it> <pAYOS-4Iu-1@gated-at.bofh.it> <pBb9n-6cY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/14, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@redhat.com> wrote:
>
> > I didn't read v2 yet, but I'd like to ask a question.
> >
> > Why do we need vmalloc_sync_all()?
> >
> > It has a single caller, register_die_notifier() which calls it without
> > any explanation. IMO, this needs a comment at least.
>
> Yes, it's used to work around crashes in modular callbacks: if the callbacks
> happens to be called from within the page fault path, before the vmalloc page
> fault handler runs, then we have a catch-22 problem.
>
> It's rare but not entirely impossible.

But again, the kernel no longer does this? do_page_fault() does vmalloc_fault()
without notify_die(). If it fails, I do not see how/why a modular DIE_OOPS
handler could try to resolve this problem and trigger another fault.

> > I am not sure I understand the changelog in 101f12af correctly, but at first
> > glance vmalloc_sync_all() is no longer needed at least on x86, do_page_fault()
> > no longer does notify_die(DIE_PAGE_FAULT). And btw DIE_PAGE_FAULT has no users.
> > DIE_MNI too...
> >
> > Perhaps we can simply kill it on x86?
>
> So in theory we could still have it run from DIE_OOPS, and that could turn a
> survivable kernel crash into a non-survivable one.

I don't understand... But OK, my understanding of this magic is very limited,
please forget.

Thanks,

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: why do we need vmalloc_sync_all? Oleg Nesterov <oleg@redhat.com> - 2015-06-14 22:10 +0200
  Re: why do we need vmalloc_sync_all? Ingo Molnar <mingo@kernel.org> - 2015-06-15 22:30 +0200
    Re: why do we need vmalloc_sync_all? Andy Lutomirski <luto@amacapital.net> - 2015-06-15 22:50 +0200

csiph-web