Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB
Date	Sun, 14 Jun 2015 07:50:02 +0200
Message-ID	<pB8XU-2RL-9@gated-at.bofh.it> (permalink)
References	<pAF9w-1pF-5@gated-at.bofh.it> <pAF9w-1pF-3@gated-at.bofh.it> <pAWk3-1fM-47@gated-at.bofh.it>
X-Original-To	Christoph Hellwig <hch@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=dWAhbuZIbugCOWrhkCBozQz3g6UMDLgPu4zJpxCLK70=; b=ZivQn2PL/ChTbKuwHJEbMgswVlXRi2vrKzEyDJVX428wA80WwKE/MMB9VEPVZoUCC/ tDe0M0dCmSCwhT0PkLuMF1BBpXh942MF5YsOqKgYPyBocUby+IL5NNBlcCgebRnRUndJ EQC/PvOArtpAcD82seOwvSn9y6gyhp95oQ+1AUjR8yPxzMjbVCPLiPTyuW2FkUx30yIQ QLC8aTsEceqYp15pTDiIbSX5J9krgrbAd426YxEubUBqoA+X/IZkpOCVxFLpL8qorpPU 2RPoah0KwznsCJxMR7Z/S3HVutiuoAIB73avecJ8fXJ74Nixe3Iv733NUcZtHrqL0FJ1 pCyg==
X-Received	by 10.182.230.75 with SMTP id sw11mr12909224obc.17.1434260558559; Sat, 13 Jun 2015 22:42:38 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
X-Original-Date	Sun, 14 Jun 2015 00:42:36 -0500
X-Original-Message-ID	<20150614054236.GA9662@mtj.duckdns.org>
X-Original-References	<1434146254-26220-1-git-send-email-tj@kernel.org> <1434146254-26220-3-git-send-email-tj@kernel.org> <20150613161608.GA29414@infradead.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1164747

Show key headers only | View raw

Hello, Christoph.

On Sat, Jun 13, 2015 at 09:16:08AM -0700, Christoph Hellwig wrote:
> On Fri, Jun 12, 2015 at 04:57:33PM -0500, Tejun Heo wrote:
> > FS_CGROUP_WRITEBACK indicates whether a file_system_type supports
> > cgroup writeback; however, different super_blocks of the same
> > file_system_type may or may not support cgroup writeback depending on
> > filesystem options.  This patch replaces FS_CGROUP_WRITEBACK with a
> > kernel-internal super_block->s_flags MS_CGROUPWB.  The concatenated
> > and abbreviated name is for consistency with other MS_* flags.
> 
> Nak.  As the uapi part makes it obvious the MS_ namespace is part
> of the userspace ABI.  Please add a new in-kernel flags field instead.

Are MS_ACTIVE and MS_BORN part of userpace ABI?  They seem pretty
internal.  I don't mind introducing a new internal flag field but it's
weird to put this single flag there with other internal flags in
->s_flags.

Assuming we add a new field, how do sb->s_iflags and SB_I_XXX sound?
Any better suggestions?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with  MS_CGROUPWB Christoph Hellwig <hch@infradead.org> - 2015-06-13 18:20 +0200
  Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with  MS_CGROUPWB Tejun Heo <tj@kernel.org> - 2015-06-14 07:50 +0200

csiph-web