Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1163706
| From | Tejun Heo <htejun@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] kernel/params.c: make use of unused but set variable |
| Date | 2015-06-12 03:50 +0200 |
| Message-ID | <pAmgx-7p8-1@gated-at.bofh.it> (permalink) |
| References | <pySNz-6Jc-9@gated-at.bofh.it> <pySNz-6Jc-5@gated-at.bofh.it> <pySXf-6UE-1@gated-at.bofh.it> <pAmgx-7p8-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 12, 2015 at 10:57:24AM +0930, Rusty Russell wrote: > Linus Torvalds <torvalds@linux-foundation.org> writes: > > On Sun, Jun 7, 2015 at 5:00 PM, Tejun Heo <htejun@gmail.com> wrote: > > At most, it could be a "WARN_ON_ONCE()". Maybe even just silently > > ignore the error. But BUG_ON()? Hell no. > > Yeah, in practice it's already (1) paniced if we ran out of memory, or > (2) warned if we somehow tried to create two entries with the same name. > > So the WARN_ON_ONCE() is a bit... meh. How's this, too snarky? Sounds pretty passive agressive to me. At least reply to the actual argument? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] kernel/params.c: make use of unused but set variable Tejun Heo <htejun@gmail.com> - 2015-06-08 02:10 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-08 02:20 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Tejun Heo <htejun@gmail.com> - 2015-06-08 03:00 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Tejun Heo <htejun@gmail.com> - 2015-06-11 04:00 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Louis Langholtz <lou_langholtz@me.com> - 2015-06-12 05:20 +0200
Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON() Ingo Molnar <mingo@kernel.org> - 2015-06-08 13:30 +0200
Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON() Ingo Molnar <mingo@kernel.org> - 2015-06-08 13:30 +0200
Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON() Ingo Molnar <mingo@kernel.org> - 2015-06-08 21:40 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Tejun Heo <htejun@gmail.com> - 2015-06-12 03:50 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Tejun Heo <htejun@gmail.com> - 2015-06-16 22:00 +0200
Re: [PATCH] kernel/params.c: make use of unused but set variable Rusty Russell <rusty@rustcorp.com.au> - 2015-06-12 03:50 +0200
csiph-web