Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1163718

[PATCH 4/7] perf stat: Error out unsupported group leader immediately

Show all headers | View raw

From: Kan Liang <kan.liang@intel.com>

perf stat ignores the unsupported event and continue to count supported
event. But if the unsupported event is group leader, perf tool will
crash. After applying this patch, the unsupported group leader will
error out immediately.

Without this patch:

  $ perf stat -x, -e '{node-prefetch-refs,cycles}' --  sleep 1
  perf: util/evsel.c:1009: get_group_fd: Assertion `!(fd == -1)' failed.
  Aborted (core dumped)

With this patch:

  $ perf stat -x, -e '{node-prefetch-refs,cycles}' --  sleep 1
  Error:
  The node-prefetch-refs event is not supported.

Commiter note: Here I got a different output, but no core dump:

  [acme@zoo linux]$ perf stat -x, -e '{node-prefetch-refs,cycles}' -- sleep 1
  Error:
  The sys_perf_event_open() syscall returned with 22 (Invalid argument)
  for event (node-prefetch-refs).
  /bin/dmesg may provide additional information.
  No CONFIG_PERF_EVENTS=y kernel support configured?

Signed-off-by: Kan Liang <kan.liang@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Link: http://lkml.kernel.org/r/1434004360-8570-1-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-stat.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index ff3d25803400..b24ecee95fec 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -549,7 +549,10 @@ static int __run_perf_stat(int argc, const char **argv)
 					ui__warning("%s event is not supported by the kernel.\n",
 						    perf_evsel__name(counter));
 				counter->supported = false;
-				continue;
+
+				if ((counter->leader != counter) ||
+				    !(counter->leader->nr_members > 1))
+					continue;
 			}
 
 			perf_evsel__open_strerror(counter, &target,
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/7] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 4/7] perf stat: Error out unsupported group leader immediately Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 5/7] perf tools: Fix build failure on 32-bit arch Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 3/7] perf evsel: Display 0x for hex values when printing the attribute Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 7/7] perf tools: Update MANIFEST per files removed from kernel Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 1/7] perf tools: Avoid possible race condition in copyfile() Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 2/7] perf record: Amend option summaries Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200
  [PATCH 6/7] trace: Beautify perf_event_open syscall Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-12 04:20 +0200

csiph-web