Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1163639
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM |
| Date | 2015-06-12 00:00 +0200 |
| Message-ID | <pAiFX-1NG-1@gated-at.bofh.it> (permalink) |
| References | <pmtKV-3e2-5@gated-at.bofh.it> <pmuQG-53f-21@gated-at.bofh.it> <pwiOe-5Rk-3@gated-at.bofh.it> <pAiFX-1NG-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/11/2015 03:53 PM, Richard Weinberger wrote: > Am 31.05.2015 um 23:12 schrieb Richard Weinberger: >> Am 04.05.2015 um 22:00 schrieb Ross Zwisler: >>> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote: >>>> Not all architectures have io memory. >>>> >>>> Fixes: >>>> drivers/block/pmem.c: In function ‘pmem_alloc’: >>>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration] >>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); >>>> ^ >>>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default] >>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); >>>> ^ >>>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] >>>> iounmap(pmem->virt_addr); >>>> ^ >>>> >>>> Signed-off-by: Richard Weinberger <richard@nod.at> >>>> --- >>>> drivers/block/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig >>>> index eb1fed5..3ccef9e 100644 >>>> --- a/drivers/block/Kconfig >>>> +++ b/drivers/block/Kconfig >>>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX >>>> >>>> config BLK_DEV_PMEM >>>> tristate "Persistent memory block device support" >>>> + depends on HAS_IOMEM >>>> help >>>> Saying Y here will allow you to use a contiguous range of reserved >>>> memory as one or more persistent block devices. >>> >>> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com> >> >> Ping? > > Can someone please pickup this trivial patch? I'll fold it in. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM Jens Axboe <axboe@kernel.dk> - 2015-06-12 00:00 +0200
csiph-web