Re: [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late() method

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late() method
Date	Sat, 13 Jun 2015 19:50:02 +0200
Message-ID	<pAXJ8-3aQ-11@gated-at.bofh.it> (permalink)
References	<pAbl8-7YY-5@gated-at.bofh.it> <pAbl8-7YY-25@gated-at.bofh.it> <pAG5A-2Mo-7@gated-at.bofh.it> <pANqq-4YL-19@gated-at.bofh.it> <pANA6-5db-13@gated-at.bofh.it>
X-Original-To	Ingo Molnar <mingo@kernel.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.18 (2008-05-17)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	60
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-mml@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>, Andrew Morton <akpm@linux-foundation.org>, Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de>, Waiman Long <Waiman.Long@hp.com>
X-Original-Date	Sat, 13 Jun 2015 19:45:27 +0200
X-Original-Message-ID	<20150613174527.GA29379@redhat.com>
X-Original-References	<1434031637-9091-1-git-send-email-mingo@kernel.org> <1434031637-9091-7-git-send-email-mingo@kernel.org> <20150612225000.GA24699@redhat.com> <20150613064705.GA13835@gmail.com> <20150613065255.GA16018@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1164665

Show key headers only | View raw

On 06/13, Ingo Molnar wrote:
>
> * Ingo Molnar <mingo@kernel.org> wrote:
>
> > * Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > >
> > > Afaics, we need to ensure that:
> > >
> > > > +			if (pgd_val(*pgd_src))
> > > > +				WRITE_ONCE(*pgd_dst, *pgd_src);
> > >
> > > either we notice the recent update of this PGD, or (say) the subsequent
> > > sync_global_pgds() can miss the child.
> > >
> > > How the write barrier can help?
> >
> > So the real thing this pairs with is the earlier:
> >
> > 	tsk->mm = mm;
> >
> > plus the linking of the new task in the task list.
> >
> > _that_ write must become visible to others before we do the (conditional) copy
> > ourselves.

Hmm. that write must be visible before we start to _read_ *pgd_src,
afaics.

> > Granted, it happens quite a bit earlier, and the task linking's use of locking
> > is a natural barrier - but since this is lockless I didn't want to leave a
> > silent assumption in.

I agree,

> Ah, there's another detail I forgot. This might handle the fork case, but in
> exec() we have:
>
>         tsk->mm = mm;
>         arch_pgd_init_late(mm);

Yes, this too.

But wmb() can't help. At least we need the full mb() to serialize the
STORE above (or list addition in copy_process) with the LOAD which
reads *pgd_src.

Plus we need another mb() in sync_global_pgds(), say, before the main
for_each_process() loop.


it would be nice to make this more simple/clear somehow...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late()  method Oleg Nesterov <oleg@redhat.com> - 2015-06-13 19:50 +0200
  Re: [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late()  method Oleg Nesterov <oleg@redhat.com> - 2015-06-14 23:00 +0200
    Re: [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late()  method Oleg Nesterov <oleg@redhat.com> - 2015-06-15 00:20 +0200

csiph-web