Re: [PATCH 01/15] ARM: kill off set_irq_flags usage

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Wan ZongShun <mcuos.com@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/15] ARM: kill off set_irq_flags usage
Date	Sat, 13 Jun 2015 13:40:02 +0200
Message-ID	<pARX4-3ft-5@gated-at.bofh.it> (permalink)
References	<pzwrD-6kQ-5@gated-at.bofh.it> <pzwL0-6JH-11@gated-at.bofh.it>
X-Original-To	Rob Herring <robh@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=iVGLziS/PVwPWpKYU2M3Nd46vmgw7ul2LM8TbkRRKZ8=; b=nSrx6kgalQJQ2VxT5gb2AmDyGOEgK+THOSnQm8Q2IJWIwdDvzomVFmBw7fIKTsxYlE tXUTzTuMiuLghRCvQ8//C2foeYcAuj+ZWBy5Qc0F99oddf30RKCekah5EWYzJOatU4hJ 5uqdnnTE2K/ZHpBzIgNMkRCQajhPXGUgKOgGyU/2SvMURNUIXBsg9RO+lwrh7//jk6oP RZMWzI98Ho4Wuh+tZalrmMtbcYIEVt2u38a7efZpqHQsPoqIEmCyeFmPIyyaGxveV9cj 1bHi0SmbAK5nVQah+wnBIkBuSOdAFPUkztadm2v9HzmhHK0czUS1D/GpCovHZi2Bsfh7 FEog==
X-Received	by 10.129.80.87 with SMTP id e84mr23762584ywb.31.1434195161526; Sat, 13 Jun 2015 04:32:41 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	Russell King <linux@arm.linux.org.uk>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, arm@kernel.org, Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@deeprootsystems.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@free-electrons.com>, Hans Ulli Kroll <ulli.kroll@googlemail.com>, Shawn Guo <shawn.guo@linaro.org>, Sascha Hauer <kernel@pengutronix.de>, Imre Kaloz <kaloz@openwrt.org>, Krzysztof Halasa <khalasa@piap.pl>, Greg Ungerer <gerg@uclinux.org>, Roland Stigge <stigge@antcom.de>, Tony Lindgren <tony@atomide.com>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Simtec Linux Team <linux@simtec.co.uk>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org
X-Original-Date	Sat, 13 Jun 2015 19:32:20 +0800
X-Original-Message-ID	<CAKT61h_EJgF926gmu0QZB=YHYSC+jWQA86yQ0e2T_4MtOvbXFg@mail.gmail.com>
X-Original-References	<1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-2-git-send-email-robh@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1164625

Show key headers only | View raw

2015-06-10 2:26 GMT+08:00 Rob Herring <robh@kernel.org>:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: Simtec Linux Team <linux@simtec.co.uk>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Wan ZongShun <mcuos.com@gmail.com>

For Nuvoton W90x900
Acked-by: Wan ZongShun <mcuos.com@gmail.com>

> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-omap@vger.kernel.org
> +++ b/arch/arm/mach-w90x900/irq.c
> @@ -211,6 +211,6 @@ void __init nuc900_init_irq(void)
>         for (irqno = IRQ_WDT; irqno <= IRQ_ADC; irqno++) {
>                 irq_set_chip_and_handler(irqno, &nuc900_irq_chip,
>                                          handle_level_irq);
> -               set_irq_flags(irqno, IRQF_VALID);
> +               irq_clear_status_flags(irqno, IRQ_NOREQUEST);
>         }
>  }
> --
> 2.1.0
>



-- 
---
Vincent Wan(Zongshun)
www.mcuos.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 01/15] ARM: kill off set_irq_flags usage Wan ZongShun <mcuos.com@gmail.com> - 2015-06-13 13:40 +0200

csiph-web