Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1164595

Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger

From Daniel Wagner <wagi@monom.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger
Date 2015-06-13 10:50 +0200
Message-ID <pAPix-7L0-7@gated-at.bofh.it> (permalink)
References <pzcVY-2Mr-5@gated-at.bofh.it> <pzcVY-2Mr-19@gated-at.bofh.it> <pAByV-4Pm-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/12/2015 06:01 PM, Steven Rostedt wrote:
>
> Why v3 in the subject?

This patch has not changed since v3 I guess.

>
> On Mon,  8 Jun 2015 16:32:00 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
>
>> When a trigger is enabled, the cond flag should be set beforehand,
>> otherwise a trigger that's expecting to process a trace record
>> (e.g. one with post_trigger set) could be invoked without one.
>>
>> Likewise a trigger's cond flag should be reset after it's disabled,
>> not before.
>>
>> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> Why is Daniel signed off by here?

I have reported the issue and send a fix for this patch

https://lkml.org/lkml/2015/4/21/161

I would have complained if I wasn't okay with it.

cheers,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling  a trigger Daniel Wagner <wagi@monom.org> - 2015-06-13 10:50 +0200
  Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling  a trigger Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-06-15 09:10 +0200

csiph-web