Re: [PATCH perf/core 1/4] [BUGFIX] perf probe: List probes in stdout

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH perf/core 1/4] [BUGFIX] perf probe: List probes in stdout
Date	Sat, 13 Jun 2015 03:20:01 +0200
Message-ID	<pAIh3-6eD-1@gated-at.bofh.it> (permalink)
References	<pApxL-41Y-5@gated-at.bofh.it> <pApxL-41Y-3@gated-at.bofh.it> <pACEG-6nK-7@gated-at.bofh.it>
X-Original-To	Arnaldo Carvalho de Melo <acme@kernel.org>
Organization	Hitachi, Ltd., Japan
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	62
X-Original-Cc	Naohiro Aota <naota@elisp.net>, Peter Zijlstra <peterz@infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>, namhyung@kernel.org, Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>
X-Original-Date	Sat, 13 Jun 2015 10:14:50 +0900
X-Original-Message-ID	<557B840A.4040802@hitachi.com>
X-Original-References	<20150612050806.20548.12371.stgit@localhost.localdomain> <20150612050813.20548.16385.stgit@localhost.localdomain> <20150612191200.GB6850@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1164508

Show key headers only | View raw

On 2015/06/13 4:12, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 12, 2015 at 02:08:13PM +0900, Masami Hiramatsu escreveu:
>> Since commit 5e17b28f1e24 ("perf probe: Add --quiet option to
>> suppress output result message") have replaced printf with pr_info,
>> perf probe -l outputs its result in stderr. However, that is not
>> what the commit expected.
>> e.g.
>>   -----
>>   # perf probe -l > /dev/null
>>     probe:vfs_read       (on vfs_read@ksrc/linux-3/fs/read_write.c)
>>   -----
>> With this fix,
>>   -----
>>   # perf probe -l > list
>>   # cat list
>>     probe:vfs_read       (on vfs_read@ksrc/linux-3/fs/read_write.c)
> 
> Nope, with this fix just applied:

Oops, I missed to rewrite...

[...]
>> @@ -2200,9 +2220,10 @@ static int __show_perf_probe_events(int fd, bool is_kprobe,
>>  				goto next;
>>  			ret = convert_to_perf_probe_event(&tev, &pev,
>>  								is_kprobe);
>> -			if (ret >= 0)
>> -				ret = show_perf_probe_event(&pev,
>> -							    tev.point.module);
>> +			if (ret < 0)
>> +				goto next;
>> +			ret = show_perf_probe_event(&pev, tev.point.module,
>> +						    false);
>>  		}
>>  next:
>>  		clear_perf_probe_event(&pev);
>> @@ -2463,7 +2484,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
>>  		group = pev->group;
>>  		pev->event = tev->event;
>>  		pev->group = tev->group;
>> -		show_perf_probe_event(pev, tev->point.module);
>> +		show_perf_probe_event(pev, tev->point.module, true);
>>  		/* Trick here - restore current event/group */
>>  		pev->event = (char *)event;
>>  		pev->group = (char *)group;
>>
> 

These true/false are opposite!


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH perf/core  1/4] [BUGFIX] perf probe: List probes in stdout Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> - 2015-06-13 03:20 +0200

csiph-web