Re: [PATCH] mm/memory hotplug: print the last vmemmap region at the end of hot add memory

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/memory hotplug: print the last vmemmap region at the end of hot add memory
Date	Thu, 11 Jun 2015 12:50:02 +0200
Message-ID	<pA8dA-3ce-13@gated-at.bofh.it> (permalink)
References	<pyZ2F-7pV-1@gated-at.bofh.it> <pzeO5-5y9-1@gated-at.bofh.it> <pziI1-2ST-1@gated-at.bofh.it> <pzyjM-Ij-3@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
X-Ironport-Av	E=Sophos;i="5.01,1,1399996800"; d="scan'208";a="96855046"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.167.226.252]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, <vbabka@suse.cz>, <rientjes@google.com>, <n-horiguchi@ah.jp.nec.com>, <zhenzhang.zhang@huawei.com>, <wangnan0@huawei.com>, <fabf@skynet.be>
X-Original-Date	Thu, 11 Jun 2015 18:41:21 +0800
X-Original-Message-ID	<557965D1.7020009@cn.fujitsu.com>
X-Original-References	<1433745881-7179-1-git-send-email-zhugh.fnst@cn.fujitsu.com> <20150608163053.c481d9a5057513130f760910@linux-foundation.org> <55766068.9090809@cn.fujitsu.com> <20150609132908.c5a9d2c9714bd7a8f33ffde8@linux-foundation.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1163133

Show key headers only | View raw

On 06/10/2015 04:29 AM, Andrew Morton wrote:
> On Tue, 9 Jun 2015 11:41:28 +0800 Zhu Guihua <zhugh.fnst@cn.fujitsu.com> wrote:
>
>>>> --- a/mm/memory_hotplug.c
>>>> +++ b/mm/memory_hotplug.c
>>>> @@ -513,6 +513,7 @@ int __ref __add_pages(int nid, struct zone *zone, unsigned long phys_start_pfn,
>>>>    			break;
>>>>    		err = 0;
>>>>    	}
>>>> +	vmemmap_populate_print_last();
>>>>    
>>>>    	return err;
>>>>    }
>>> vmemmap_populate_print_last() is only available on x86_64, when
>>> CONFIG_SPARSEMEM_VMEMMAP=y.  Are you sure this won't break builds?
>> I tried this on i386 and on x86_64 when CONFIG_SPARSEMEM_VMEMMAP=n ,
>> it builds ok.
> With powerpc:
>
> akpm3:/usr/src/25> make allmodconfig
> akpm3:/usr/src/25> make mm/memory_hotplug.o
> akpm3:/usr/src/25> nm mm/memory_hotplug.o | grep vmemmap_populate_print_last
> 	U .vmemmap_populate_print_last
> akpm3:/usr/src/25> grep -r vmemmap_populate_print_last arch/powerpc
> akpm3:/usr/src/25>
>
> So I think that's going to break.
>
> I expect ia64 will break also, but I didn't investigate.
> .
>

There is
void __weak __meminit vmemmap_populate_print last(void)
in /mm/sparse.c, so I think this won't break builds.

And I found the function was invoked in void __init sparse_init(void) 
without
CONFIG_SPARSEMEM_VMEMMAP=y.

I also tried this on arm, it builds ok too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm/memory hotplug: print the last vmemmap region at the  end of hot add memory Zhu Guihua <zhugh.fnst@cn.fujitsu.com> - 2015-06-09 05:50 +0200
  Re: [PATCH] mm/memory hotplug: print the last vmemmap region at the  end of hot add memory Zhu Guihua <zhugh.fnst@cn.fujitsu.com> - 2015-06-11 12:50 +0200

csiph-web