Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #12302 > unrolled thread

Force pushing on salsa?

Back to article view | Back to linux.debian.maint.python

Contents

  Force pushing on salsa? Louis-Philippe Véronneau <pollo@debian.org> - 2020-02-11 17:40 +0100
    Re: Force pushing on salsa? Mattia Rizzolo <mattia@debian.org> - 2020-02-11 17:50 +0100

#12302 — Force pushing on salsa?

[Multipart message — attachments visible in raw view] — view raw

Hey folks,

Looking at a package recently, I saw some important mistakes and I was
wondering: would it be ok to force push to fix them?

More explicitly, the import of the new upstream version with
pristine-tar contains a bunch of errors due to a wrong manipulation. It
seems to me it would be "more clean" to start again and force push.

I know force pushing is normally frowned upon when working in a team
environment, but I haven't seen any mention of it in the Python Team's
policy.

Happy to know what folks think of this. If there is a strong consensus,
maybe we should add something to the policy.

Cheers,

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
  ⠈⠳⣄

[toc] | [next] | [standalone]

#12303

[Multipart message — attachments visible in raw view] — view raw

On Tue, Feb 11, 2020 at 11:34:23AM -0500, Louis-Philippe Véronneau wrote:
> Looking at a package recently, I saw some important mistakes and I was
> wondering: would it be ok to force push to fix them?
> 
> More explicitly, the import of the new upstream version with
> pristine-tar contains a bunch of errors due to a wrong manipulation. It
> seems to me it would be "more clean" to start again and force push.
> 
> I know force pushing is normally frowned upon when working in a team
> environment, but I haven't seen any mention of it in the Python Team's
> policy.

Let me keep frowing deeply.

If pristine-tar data is corrupted, just use
    % pristine-tar commit ../foo_1.2.3.orig.tar.xz upstream/1.2.3
to update the data, without force-pushing.  It's just one extra commit,
so why would that be "less clean"?!


The only thing I could *very frowingly* accept, is force-pushing a tag
because you are doing it again.  Having said that, I usually just append
a number if I need to re-repack again an upstream tarball (+dfsg1,
+dfsg2, etc).  But you mentioned only pristine-tar, so I suppose that's
not your case.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web