Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #12202 > unrolled thread

python-babel

Back to article view | Back to linux.debian.maint.python

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  python-babel Håvard Flaget Aasen <haavard_aasen@yahoo.no> - 2020-01-10 21:00 +0100
    Re: python-babel Jonathan Carter <jcc@debian.org> - 2020-02-11 10:40 +0100
    Re: python-babel Håvard Flaget Aasen <haavard_aasen@yahoo.no> - 2020-02-11 11:20 +0100
      Re: python-babel Jonathan Carter <jcc@debian.org> - 2020-02-11 11:30 +0100
      Re: python-babel Håvard Flaget Aasen <haavard_aasen@yahoo.no> - 2020-02-11 12:10 +0100
      Re: python-babel Sandro Tosi <morph@debian.org> - 2020-02-11 16:50 +0100
      Re: python-babel Håvard Flaget Aasen <haavard_aasen@yahoo.no> - 2020-02-11 17:00 +0100
        Re: python-babel Håvard Flaget Aasen <haavard_aasen@yahoo.no> - 2020-02-12 08:20 +0100

#12202 — python-babel

Hello,

The python-babel [1] package is currently broken, there isn't any bugs 
reported yet, but after the transit to
python3.8 it failed the testsuite. New upstream version 2.7.0 and above 
fixes these issues.
To update the package there is a 'repack' script which i believe is 
broken, I at least did most of the work
manually. For that reason I haven't dared push it to the official repo 
yet, if anyone have time, it will be nice
with a second opinion. It's still some work left, but it builds and 
tests fine. The version I updated is currently here [2]

The script might only require a minor fix but i noticed that the files 
being downloaded already exist
within Debian. The package unicode-cldr-core [3].
Is it possible to have this as a build-dependency, have a Files-Excluded 
in d/copyright file and
drop the repack script altogether? If there still is a reason to change 
the files in the first place.
If this makes it any easier/better of course.

I'll appreciate all kinds of feedback.


Håvard


[1] https://tracker.debian.org/pkg/python-babel
[2] https://salsa.debian.org/haava-guest/python-babel
[3] https://tracker.debian.org/pkg/unicode-cldr-core

[toc] | [next] | [standalone]

#12292

Hi Håvard

On 2020/02/11 10:33, Thomas Goirand wrote:
> I tried to build python-babel to sponsor the upload from what's in the
> Git in the DPMT, and it failed to build for me:

I'm removing it from the channel topic in the meantime, please re-add
when the building is resolved, thanks for your contribution!

-Jonathan

-- 
  ⢀⣴⠾⠻⢶⣦⠀  Jonathan Carter (highvoltage) <jcc>
  ⣾⠁⢠⠒⠀⣿⡁  Debian Developer - https://wiki.debian.org/highvoltage
  ⢿⡄⠘⠷⠚⠋   https://debian.org | https://jonathancarter.org
  ⠈⠳⣄⠀⠀⠀⠀  Be Bold. Be brave. Debian has got your back.

[toc] | [prev] | [next] | [standalone]

#12295

> 
> I tried to build python-babel to sponsor the upload from what's in the
> Git in the DPMT, and it failed to build for me:
> 
> # Generate the localedata folder data out of the xml files
> # downloaded in debian/repack
> scripts/import_cldr.py common
> Processing root.xml (Language = root; Territory = 001)
> 
> root: Unsupported number system "adlm" in <symbols numberSystem="adlm">
> 
> [... lots of lines like this one ...]

I'm also getting these lines. I tested with the current 2.6.0 which also 
gives the same messages, the build log for 2.6.0 in Ubuntu prints the 
same messages.

Now for the files actually being processed
It is 719 in version 2.4.0
745 in version 2.6.0 and
764 in version 2.8.0

Not that it is supposed to be this way of course. Though I do believe 
the actual content in the package is correct.
I can have a look at what we are actually importing in d/repack and see
if anything has changed from version 2.4.0 to 2.8.0


> 
> root: Unsupported number system "vaii" in <currencyFormats
> numberSystem="vaii">
> 
> Traceback (most recent call last):
>    File "scripts/import_cldr.py", line 968, in <module>
>      main()
>    File "scripts/import_cldr.py", line 193, in main
>      dump_json=bool(options.dump_json)
>    File "scripts/import_cldr.py", line 207, in process_data
>      _process_local_datas(sup, srcdir, destdir, force=force,
> dump_json=dump_json)
>    File "scripts/import_cldr.py", line 435, in _process_local_datas
>      write_datafile(data_filename, data, dump_json=dump_json)
>    File "scripts/import_cldr.py", line 167, in write_datafile
>      with open(path, 'wb') as outfile:
> IOError: [Errno 2] No such file or directory:
> '/<<PKGBUILDDIR>>/babel/locale-data/root.dat'
> 
I can't replicate this. I tried with cowbuilder/pbuilder and sbuild and 
the build completes fine on my systems.

Håvard

[toc] | [prev] | [next] | [standalone]

#12296

On 2020/02/11 12:16, Håvard Flaget Aasen wrote:
> I can't replicate this. I tried with cowbuilder/pbuilder and sbuild and
> the build completes fine on my systems.

Ok, thanks. I'll check on a chroot on my system later too to try to see
what's going on, but swamped at the moment so can't check right now.

-Jonathan

-- 
  ⢀⣴⠾⠻⢶⣦⠀  Jonathan Carter (highvoltage) <jcc>
  ⣾⠁⢠⠒⠀⣿⡁  Debian Developer - https://wiki.debian.org/highvoltage
  ⢿⡄⠘⠷⠚⠋   https://debian.org | https://jonathancarter.org
  ⠈⠳⣄⠀⠀⠀⠀  Be Bold. Be brave. Debian has got your back.

[toc] | [prev] | [next] | [standalone]

#12297

>>
>> I tried to build python-babel to sponsor the upload from what's in the
>> Git in the DPMT, and it failed to build for me:
>>
>> # Generate the localedata folder data out of the xml files
>> # downloaded in debian/repack
>> scripts/import_cldr.py common
>> Processing root.xml (Language = root; Territory = 001)
>>
>> root: Unsupported number system "adlm" in <symbols numberSystem="adlm">
>>
>> [... lots of lines like this one ...]
> 
> I'm also getting these lines. I tested with the current 2.6.0 which also 
> gives the same messages, the build log for 2.6.0 in Ubuntu prints the 
> same messages.
> 
> Now for the files actually being processed
> It is 719 in version 2.4.0
> 745 in version 2.6.0 and
> 764 in version 2.8.0
> 
> Not that it is supposed to be this way of course. Though I do believe 
> the actual content in the package is correct.
> I can have a look at what we are actually importing in d/repack and see
> if anything has changed from version 2.4.0 to 2.8.0
> 
I believe this is the upstream change. [1]
If it indeed are files were supposed to have in the package i guess it 
need some more work, if not we could either leave it as is, or comment 
out the log line.

Håvard

[1] 
https://github.com/python-babel/babel/commit/77dc9d4024b78c2339f7cf3bff1a2e8be8e2d0f7#diff-106585574531c31ab48c6bf45e566e40

[toc] | [prev] | [next] | [standalone]

#12300

> In such case, could you provide me with the source package, rather than
> just letting me try with Git? Maybe this is going to work then...

whatever turns out to be, please ensure the package is buildable from
the git repo. and matches what's going to be uploaded. We have already
enough packages with missing pristine-tar deltas, with orig tarballs
that dont match what's in the upstream+pristine-tar output, let's not
increase that number.

Thanks,
-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi

[toc] | [prev] | [next] | [standalone]

#12301

On 11.02.2020 15:44, Thomas Goirand wrote:
> On 2/11/20 11:16 AM, Håvard Flaget Aasen wrote:
>>
>>>
>>> I tried to build python-babel to sponsor the upload from what's in the
>>> Git in the DPMT, and it failed to build for me:
>>>
>>> # Generate the localedata folder data out of the xml files
>>> # downloaded in debian/repack
>>> scripts/import_cldr.py common
>>> Processing root.xml (Language = root; Territory = 001)
>>>
>>> root: Unsupported number system "adlm" in <symbols numberSystem="adlm">
>>>
>>> [... lots of lines like this one ...]
>>
>> I'm also getting these lines. I tested with the current 2.6.0 which also
>> gives the same messages, the build log for 2.6.0 in Ubuntu prints the
>> same messages.
>>
>> Now for the files actually being processed
>> It is 719 in version 2.4.0
>> 745 in version 2.6.0 and
>> 764 in version 2.8.0
>>
>> Not that it is supposed to be this way of course. Though I do believe
>> the actual content in the package is correct.
>> I can have a look at what we are actually importing in d/repack and see
>> if anything has changed from version 2.4.0 to 2.8.0
>>
>>
>>>
>>> root: Unsupported number system "vaii" in <currencyFormats
>>> numberSystem="vaii">
>>>
>>> Traceback (most recent call last):
>>>     File "scripts/import_cldr.py", line 968, in <module>
>>>       main()
>>>     File "scripts/import_cldr.py", line 193, in main
>>>       dump_json=bool(options.dump_json)
>>>     File "scripts/import_cldr.py", line 207, in process_data
>>>       _process_local_datas(sup, srcdir, destdir, force=force,
>>> dump_json=dump_json)
>>>     File "scripts/import_cldr.py", line 435, in _process_local_datas
>>>       write_datafile(data_filename, data, dump_json=dump_json)
>>>     File "scripts/import_cldr.py", line 167, in write_datafile
>>>       with open(path, 'wb') as outfile:
>>> IOError: [Errno 2] No such file or directory:
>>> '/<<PKGBUILDDIR>>/babel/locale-data/root.dat'
>>>
>> I can't replicate this. I tried with cowbuilder/pbuilder and sbuild and
>> the build completes fine on my systems.
>>
>> Håvard
> 
> 
> In such case, could you provide me with the source package, rather than
> just letting me try with Git? Maybe this is going to work then...

Thats ok, how do you want it? the orig.tar.gz is just over 25 MB

When i try I only use git, with these commands:
$ gbp clone
$ gbp buildpackage

Håvard

[toc] | [prev] | [next] | [standalone]

#12308

On 11.02.2020 16:55, Håvard Flaget Aasen wrote:
> 
> 
> On 11.02.2020 15:44, Thomas Goirand wrote:
>> On 2/11/20 11:16 AM, Håvard Flaget Aasen wrote:
>>>
>>>>
>>>> I tried to build python-babel to sponsor the upload from what's in the
>>>> Git in the DPMT, and it failed to build for me:
>>>>
>>>> # Generate the localedata folder data out of the xml files
>>>> # downloaded in debian/repack
>>>> scripts/import_cldr.py common
>>>> Processing root.xml (Language = root; Territory = 001)
>>>>
>>>> root: Unsupported number system "adlm" in <symbols numberSystem="adlm">
>>>>
>>>> [... lots of lines like this one ...]
>>>
>>> I'm also getting these lines. I tested with the current 2.6.0 which also
>>> gives the same messages, the build log for 2.6.0 in Ubuntu prints the
>>> same messages.
>>>
>>> Now for the files actually being processed
>>> It is 719 in version 2.4.0
>>> 745 in version 2.6.0 and
>>> 764 in version 2.8.0
>>>
>>> Not that it is supposed to be this way of course. Though I do believe
>>> the actual content in the package is correct.
>>> I can have a look at what we are actually importing in d/repack and see
>>> if anything has changed from version 2.4.0 to 2.8.0
>>>
>>>
>>>>
>>>> root: Unsupported number system "vaii" in <currencyFormats
>>>> numberSystem="vaii">
>>>>
>>>> Traceback (most recent call last):
>>>>     File "scripts/import_cldr.py", line 968, in <module>
>>>>       main()
>>>>     File "scripts/import_cldr.py", line 193, in main
>>>>       dump_json=bool(options.dump_json)
>>>>     File "scripts/import_cldr.py", line 207, in process_data
>>>>       _process_local_datas(sup, srcdir, destdir, force=force,
>>>> dump_json=dump_json)
>>>>     File "scripts/import_cldr.py", line 435, in _process_local_datas
>>>>       write_datafile(data_filename, data, dump_json=dump_json)
>>>>     File "scripts/import_cldr.py", line 167, in write_datafile
>>>>       with open(path, 'wb') as outfile:
>>>> IOError: [Errno 2] No such file or directory:
>>>> '/<<PKGBUILDDIR>>/babel/locale-data/root.dat'
>>>>
>>> I can't replicate this. I tried with cowbuilder/pbuilder and sbuild and
>>> the build completes fine on my systems.
>>>
>>> Håvard
>>
>>
>> In such case, could you provide me with the source package, rather than
>> just letting me try with Git? Maybe this is going to work then...
> 
> Thats ok, how do you want it? the orig.tar.gz is just over 25 MB
> 
> When i try I only use git, with these commands:
> $ gbp clone
> $ gbp buildpackage
> 
> Håvard


I'm sorry to have wasted your time yesterday. It is indeed my system 
that does something it shouldn't.
I created a CI in salsa which duplicated your error.
I believe the repository with the pristine-tar and upstream branch is 
correct

I will fix the package today and readd it on IRC when it's done.

I was able to reproduce the error on my own system with
$ dpkg-buildpackage -us -ui

Håvard

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web