Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #11249 > unrolled thread

Build test failure for python-easydev

Started byAndreas Tille <andreas@an3as.eu>
First post2019-01-15 20:00 +0100
Last post2019-01-23 17:20 +0100
Articles 8 — 4 participants

Back to article view | Back to linux.debian.maint.python


Contents

  Build test failure for python-easydev Andreas Tille <andreas@an3as.eu> - 2019-01-15 20:00 +0100
    Re: Build test failure for python-easydev Piotr Ożarowski <piotr@debian.org> - 2019-01-16 10:40 +0100
      Re: Build test failure for python-easydev Andreas Tille <andreas@an3as.eu> - 2019-01-22 22:00 +0100
        Re: Build test failure for python-easydev Nick Morrott <knowledgejunkie@gmail.com> - 2019-01-22 23:30 +0100
          Re: Build test failure for python-easydev Nick Morrott <knowledgejunkie@gmail.com> - 2019-01-23 00:40 +0100
            Re: Build test failure for python-easydev Andreas Tille <andreas@an3as.eu> - 2019-01-23 08:00 +0100
              Re: Build test failure for python-easydev Nick Morrott <knowledgejunkie@gmail.com> - 2019-01-23 11:00 +0100
                Re: Build test failure for python-easydev Andreas Tille <tille@debian.org> - 2019-01-23 17:20 +0100

#11249 — Build test failure for python-easydev

FromAndreas Tille <andreas@an3as.eu>
Date2019-01-15 20:00 +0100
SubjectBuild test failure for python-easydev
Message-ID<xgC6m-4L7-9@gated-at.bofh.it>
Hi,

I've upgraded python-easydev[1] but the test fails:



   dh_auto_test -O--buildsystem=pybuild
I: pybuild base:217: cd /build/python-easydev-0.9.37/.pybuild/cpython2_2.7_easydev/build; python2.7 -m unittest discover -v.

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
I: pybuild base:217: cd /build/python-easydev-0.9.37/.pybuild/cpython3_3.7_easydev/build; python3.7 -m unittest discover -v.
easydev (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: easydev (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: easydev
Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/loader.py", line 468, in _find_test_path
    package = self._get_module_from_name(name)
  File "/usr/lib/python3.7/unittest/loader.py", line 375, in _get_module_from_name
    __import__(name)
  File "/build/python-easydev-0.9.37/.pybuild/cpython3_3.7_easydev/build/easydev/__init__.py", line 30, in <module>
    version = pkg_resources.require("easydev")[0].version
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 898, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 784, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'easydev' distribution was not found and is required by the application


----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)
E: pybuild pybuild:338: test: plugin distutils failed with: exit code=1: cd /build/python-easydev-0.9.37/.pybuild/cpython3_3.7_easydev/build; python3.7 -m unittest discover -v.


Any idea how to fix this?

Kind regards

     Andreas.


[1] https://salsa.debian.org/med-team/python-easydev

-- 
http://fam-tille.de

[toc] | [next] | [standalone]


#11252

FromPiotr Ożarowski <piotr@debian.org>
Date2019-01-16 10:40 +0100
Message-ID<xgPPY-4Tg-7@gated-at.bofh.it>
In reply to#11249
> pkg_resources.DistributionNotFound: The 'easydev' distribution was not found and is required by the application

there are many ways to fix it (by creating egg-info data during build,
not only during install stage), but if upstream is updating __version__
in each version, then definitely the best option is to patch out lines
23-31 from easydev/__init__.py file (i.e. not use pkg_resources)
-- 
GPG: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

[toc] | [prev] | [next] | [standalone]


#11263

FromAndreas Tille <andreas@an3as.eu>
Date2019-01-22 22:00 +0100
Message-ID<xjbjk-2k4-3@gated-at.bofh.it>
In reply to#11252
Hi Piotr,

On Wed, Jan 16, 2019 at 10:34:07AM +0100, Piotr Ożarowski wrote:
> > pkg_resources.DistributionNotFound: The 'easydev' distribution was not found and is required by the application
> 
> there are many ways to fix it (by creating egg-info data during build,
> not only during install stage), but if upstream is updating __version__
> in each version, then definitely the best option is to patch out lines
> 23-31 from easydev/__init__.py file (i.e. not use pkg_resources)

Thanks for the hint.  I decided for the removal of lines 23-31.
Unfortunately this did not brought me way further:

   dh_auto_test -O--buildsystem=pybuild
I: pybuild base:217: cd /build/python-easydev-0.9.37/.pybuild/cpython2_2.7_easydev/build; python2.7 -m pytest test
usage: pytest.py [options] [file_or_dir] [file_or_dir] [...]
pytest.py: error: unrecognized arguments: --cov=easydev --cov-report=term-missing
  inifile: /build/python-easydev-0.9.37/setup.cfg
  rootdir: /build/python-easydev-0.9.37
E: pybuild pybuild:338: test: plugin distutils failed with: exit code=4: cd /build/python-easydev-0.9.37/.pybuild/cpython2_2.7_easydev/build; python2.7 -m pytest test
dh_auto_test: pybuild --test --test-pytest -i python{version} -p 2.7 returned exit code 13
make: *** [debian/rules:7: build] Error 25


Also here I have no idea what to do next.

Kind regards

      Andreas.

-- 
http://fam-tille.de

[toc] | [prev] | [next] | [standalone]


#11265

FromNick Morrott <knowledgejunkie@gmail.com>
Date2019-01-22 23:30 +0100
Message-ID<xjcIp-3iO-11@gated-at.bofh.it>
In reply to#11263
On Tue, 22 Jan 2019 at 20:50, Andreas Tille <andreas@an3as.eu> wrote:
>
> Hi Piotr,
>
> Also here I have no idea what to do next.

Andreas,

I'm a newcomer to the python team, but I'm looking at this at the
moment to improve by debugging and python packaging.

Thanks,
Nick

[toc] | [prev] | [next] | [standalone]


#11269

FromNick Morrott <knowledgejunkie@gmail.com>
Date2019-01-23 00:40 +0100
Message-ID<xjdO9-3VV-5@gated-at.bofh.it>
In reply to#11265
On Tue, 22 Jan 2019 at 22:25, Nick Morrott <knowledgejunkie@gmail.com> wrote:
>
> On Tue, 22 Jan 2019 at 20:50, Andreas Tille <andreas@an3as.eu> wrote:
> >
> > Hi Piotr,
> >
> > Also here I have no idea what to do next.
>
> Andreas,
>
> I'm a newcomer to the python team, but I'm looking at this at the
> moment to improve by debugging and python packaging.

Andreas,

I've sent an MR [1] for you (and more experienced Python packagers) to
review to get you started.

  [1] https://salsa.debian.org/med-team/python-easydev/merge_requests/1

I note the following lintian issues after a build. The important ones
are the missing manpages:

N: Starting on group python-easydev/0.9.37-1
N: Unpacking packages in group python-easydev/0.9.37-1
N: ----
N: Processing changes file python-easydev (version 0.9.37-1, arch
source all) ...
N: ----
N: Processing source package python-easydev (version 0.9.37-1, arch source) ...
X: python-easydev source: upstream-metadata-file-is-missing
X: python-easydev source: debian-watch-does-not-check-gpg-signature
N: ----
N: Processing binary package python3-easydev (version 0.9.37-1, arch all) ...
X: python3-easydev: library-package-name-for-application
usr/bin/easydev3_browse usr/bin/easydev3_buildPackage
X: python3-easydev: application-in-library-section python
usr/bin/easydev3_browse usr/bin/easydev3_buildPackage
P: python3-easydev: image-file-in-usr-lib
usr/lib/python3/dist-packages/easydev/share/themes/cno/static/bgfooter.png
P: python3-easydev: image-file-in-usr-lib
usr/lib/python3/dist-packages/easydev/share/themes/cno/static/bgtop.png
P: python3-easydev: image-file-in-usr-lib
usr/lib/python3/dist-packages/easydev/share/themes/cno/static/warning.jpg
P: python3-easydev: image-file-in-usr-lib
usr/lib/python3/dist-packages/easydev/share/themes/standard/static/bgfooter.png
P: python3-easydev: image-file-in-usr-lib
usr/lib/python3/dist-packages/easydev/share/themes/standard/static/bgtop.png
P: python3-easydev: image-file-in-usr-lib
usr/lib/python3/dist-packages/easydev/share/themes/standard/static/warning.jpg
W: python3-easydev: binary-without-manpage usr/bin/easydev3_browse
W: python3-easydev: binary-without-manpage usr/bin/easydev3_buildPackage
N: ----
N: Processing binary package python-easydev (version 0.9.37-1, arch all) ...
X: python-easydev: library-package-name-for-application
usr/bin/easydev2_browse usr/bin/easydev2_buildPackage
X: python-easydev: application-in-library-section python
usr/bin/easydev2_browse usr/bin/easydev2_buildPackage
P: python-easydev: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/easydev/share/themes/cno/static/bgfooter.png
P: python-easydev: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/easydev/share/themes/cno/static/bgtop.png
P: python-easydev: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/easydev/share/themes/cno/static/warning.jpg
P: python-easydev: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/easydev/share/themes/standard/static/bgfooter.png
P: python-easydev: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/easydev/share/themes/standard/static/bgtop.png
P: python-easydev: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/easydev/share/themes/standard/static/warning.jpg
W: python-easydev: binary-without-manpage usr/bin/easydev2_browse
W: python-easydev: binary-without-manpage usr/bin/easydev2_buildPackage
N: Finished processing group python-easydev/0.9.37-1


Hope this helps,
Nick

[toc] | [prev] | [next] | [standalone]


#11270

FromAndreas Tille <andreas@an3as.eu>
Date2019-01-23 08:00 +0100
Message-ID<xjkFY-860-7@gated-at.bofh.it>
In reply to#11269
Hi Nick,

On Tue, Jan 22, 2019 at 11:33:09PM +0000, Nick Morrott wrote:
> > I'm a newcomer to the python team, but I'm looking at this at the
> > moment to improve by debugging and python packaging.

Cool.  Thanks a lot.  Your outright contribution was very helpful and
really welcome.  The only change I made is to revert your commit
38022ac5 since there is no point in changing the upstream source that
way.  I agree upstream should not ship that file but if its in the
upstream tarball I see no need to remove it here.
 
> Hope this helps,

Definitely.  Package is uploaded - one worry less. :-)

Thanks again

       Andreas.


[1] https://salsa.debian.org/med-team/python-easydev/commit/7f2adf4f

-- 
http://fam-tille.de

[toc] | [prev] | [next] | [standalone]


#11271

FromNick Morrott <knowledgejunkie@gmail.com>
Date2019-01-23 11:00 +0100
Message-ID<xjnu9-1m8-3@gated-at.bofh.it>
In reply to#11270
On Wed, 23 Jan 2019 at 06:54, Andreas Tille <andreas@an3as.eu> wrote:
>
> Hi Nick,
>
> On Tue, Jan 22, 2019 at 11:33:09PM +0000, Nick Morrott wrote:
> > > I'm a newcomer to the python team, but I'm looking at this at the
> > > moment to improve by debugging and python packaging.
>
> Cool.  Thanks a lot.  Your outright contribution was very helpful and
> really welcome.  The only change I made is to revert your commit
> 38022ac5 since there is no point in changing the upstream source that
> way.  I agree upstream should not ship that file but if its in the
> upstream tarball I see no need to remove it here.

Apologies about that. My build failed immediately due to the presence
of that file when I started testing, and removing it got the build to
proceed so I could look at the test failures.

That file is not present in their upstream github repository at the
release date of 0.9.37. pypi points to the repo as the definitive
source location so it's my fault for not investigating the pypi
tarball further. If it persists it can obviously always be removed
automatically via d/copyright if desired.

> > Hope this helps,
>
> Definitely.  Package is uploaded - one worry less. :-)

Excellent!

Cheers,
Nick

[toc] | [prev] | [next] | [standalone]


#11272

FromAndreas Tille <tille@debian.org>
Date2019-01-23 17:20 +0100
Message-ID<xjtpT-5f1-5@gated-at.bofh.it>
In reply to#11271
On Wed, Jan 23, 2019 at 09:58:45AM +0000, Nick Morrott wrote:
> > Cool.  Thanks a lot.  Your outright contribution was very helpful and
> > really welcome.  The only change I made is to revert your commit
> > 38022ac5 since there is no point in changing the upstream source that
> > way.  I agree upstream should not ship that file but if its in the
> > upstream tarball I see no need to remove it here.
> 
> Apologies about that.

No problem. :-)

> My build failed immediately due to the presence
> of that file when I started testing, and removing it got the build to
> proceed so I could look at the test failures.
> 
> That file is not present in their upstream github repository at the
> release date of 0.9.37. pypi points to the repo as the definitive
> source location so it's my fault for not investigating the pypi
> tarball further.

Strange. I have no idea how this file might have sneaked in.  It might
be that PyPI changed the content of the file without renaming it?  I
used what I once obtained and stored in pristine-tar.  May be you
did not used `gbp buildpackage` - thus the difference.

> If it persists it can obviously always be removed
> automatically via d/copyright if desired.

It never harmed my build.  I tend to not touch the original tarball via
d/copyright to keep the md5sum equally to the download - which does not
seem to be the case any more if you are right (I did not mind to check
admittedly).  I guess it will "heal" for the next version and I have
more important things than this on my desk now.
 
> > Definitely.  Package is uploaded - one worry less. :-)
> 
> Excellent!

Thanks again

      Andreas. 

-- 
http://fam-tille.de

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.maint.python


csiph-web