Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #10879 > unrolled thread

Bug#907806: How to disable tests for Python2 only?

Started byAndreas Tille <andreas@an3as.eu>
First post2018-09-10 16:40 +0200
Last post2018-09-10 21:50 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.debian.maint.python

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Bug#907806: How to disable tests for Python2 only? Andreas Tille <andreas@an3as.eu> - 2018-09-10 16:40 +0200
    Bug#907806: How to disable tests for Python2 only? eamanu15 <emmanuelarias30@gmail.com> - 2018-09-10 17:50 +0200
    Bug#907806: How to disable tests for Python2 only? Yaroslav Halchenko <debian@onerussian.com> - 2018-09-10 17:50 +0200
      Bug#907806: How to disable tests for Python2 only? Andreas Tille <andreas@an3as.eu> - 2018-09-10 21:50 +0200

#10879 — Bug#907806: How to disable tests for Python2 only?

FromAndreas Tille <andreas@an3as.eu>
Date2018-09-10 16:40 +0200
SubjectBug#907806: How to disable tests for Python2 only?
Message-ID<wwvw5-7ta-1@gated-at.bofh.it>
Hi,

looking at the bug log of scikit-learn[1] it seems to be a simple means to do

--- a/debian/control
+++ b/debian/control
@@ -20,6 +20,7 @@ Build-Depends: debhelper (>= 9), dh-autoreconf,
                python3-pytest,
                python3-matplotlib,
                python3-joblib (>= 0.9.2),
+               python3-distributed <!nocheck>,
                libsvm-dev (>= 2.84.0),
                libatlas3-base,
 Build-Depends-Indep:


Since python-distributed does not exist for Python2 I tried:


--- a/debian/rules
+++ b/debian/rules
@@ -36,6 +36,8 @@ NOSEARGS += $(shell dpkg --print-architecture | grep -q -v ppc64el || echo --exc
 export  http_proxy=http://127.0.0.1:9/
 export  https_proxy=http://127.0.0.1:9/
 
+export PYBUILD_TEST_ARGS_python2=-k-Xtest_import_all_consistency
+
 # Mega rule
 %:
        : # Explicit build system to avoid use of all-in-1 Makefile



(just for a test - there are more tests to exclude for Python2).
However, it seems that due to the fact that this package uses
--buildsystem=python_distutils instead of pybuild this method does
not seem to work.  Are there any other ways to exclude some tests
for Python2 to make this package build again?

Kind regards

      Andreas.

PS: Yaroslav, I think we formerly agreed that it is OK to move
    those basic packages to Debian Science team maintenance.  I
    would like to move the packaging to Salsa and will follow your
    precondition to change only the needed things to not break
    any backports of yours.  Is this OK?


[1] https://bugs.debian.org/907806


-- 
http://fam-tille.de

[toc] | [next] | [standalone]


#10880

Fromeamanu15 <emmanuelarias30@gmail.com>
Date2018-09-10 17:50 +0200
Message-ID<wwwBP-83X-3@gated-at.bofh.it>
In reply to#10879

[Multipart message — attachments visible in raw view] — view raw

> ... sorry to repeat myself but having team maintained packages on
> github is not inviting to others.  Is there any reason not to
> use Salsa?
>
+1

Regards!

-- 
Arias Emmanuel
http://eamanu.com
Github/Gitlab; @eamanu
Debian: @eamanu-guest

[toc] | [prev] | [next] | [standalone]


#10881

FromYaroslav Halchenko <debian@onerussian.com>
Date2018-09-10 17:50 +0200
Message-ID<wwwBP-83X-1@gated-at.bofh.it>
In reply to#10879
On Mon, 10 Sep 2018, Andreas Tille wrote:

> On Mon, Sep 10, 2018 at 10:54:02AM -0400, Yaroslav Halchenko wrote:
> > Outstanding few issues so far are reported/dealt with upstream:
> > https://github.com/scikit-learn/scikit-learn/issues?q=is%3Aopen+is%3Aissue+author%3Ayarikoptic+label%3ABlocker
> > updating packaging is in debian-0.20 branch at 
> > http://github.com/yarikoptic/scikit-learn

> ... sorry to repeat myself but having team maintained packages on
> github is not inviting to others.  Is there any reason not to
> use Salsa?

yeap, let's make a repo on salsa.  Would you be ok to retain my weird
"based on upstream git" setup?

-- 
Yaroslav O. Halchenko
Center for Open Neuroscience     http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik        

[toc] | [prev] | [next] | [standalone]


#10882

FromAndreas Tille <andreas@an3as.eu>
Date2018-09-10 21:50 +0200
Message-ID<wwAm5-1P1-5@gated-at.bofh.it>
In reply to#10881
On Mon, Sep 10, 2018 at 11:44:00AM -0400, Yaroslav Halchenko wrote:
> 
> > ... sorry to repeat myself but having team maintained packages on
> > github is not inviting to others.  Is there any reason not to
> > use Salsa?
> 
> yeap, let's make a repo on salsa.  Would you be ok to retain my weird
> "based on upstream git" setup?

https://salsa.debian.org/science-team/scikit-learn

(I did so about one year ago but you decided to stay on Github.
 I removed the old repo and injected what I cloned this morning
 and added a pristine-tar branch.  I volunteer to do it even
 a third time but not more. ;-) )

Hope this helps and thanks for caring for the package.  I agree that
packaging the new upstream version is probably the best strategy if
it is in the not too distant future (= we will not loose all the
rdepends from testing)

Kind regards

         Andreas. 

-- 
http://fam-tille.de

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.maint.python


csiph-web