Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #10272 > unrolled thread

Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL)

Back to article view | Back to linux.debian.maint.python

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL) Yao Wei (魏銘廷) <mwei@lxde.org> - 2018-03-19 15:10 +0100
    Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL) Paul Wise <pabs@debian.org> - 2018-03-20 01:10 +0100
    Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL) Paul Wise <pabs@debian.org> - 2018-03-20 01:30 +0100
      Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL) Yao Wei (魏銘廷) <mwei@lxde.org> - 2018-03-20 01:50 +0100
        Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL) Paul Wise <pabs@debian.org> - 2018-03-20 02:50 +0100

#10272 — Bug#891391: ITP: python-hsluv -- Python implementation of HSLuv (Human-friendly HSL)

[Multipart message — attachments visible in raw view] — view raw

X-Debbugs-CC: debian-python@lists.debian.org
On Sun, Feb 25, 2018 at 01:12:59PM +0800, Yao Wei (魏銘廷) wrote:

> Package: wnpp
> Severity: wishlist
> Owner: Yao Wei (魏銘廷) <mwei@lxde.org>
> Control: block 806464 by -1
>
> * Package name    : python-hsluv
>   Version         : 4.0.2
>   Upstream Author : Alexei Boronine <alexei@boronine.com>
> * URL             : https://github.com/hsluv/hsluv-python
> * License         : Expat
>   Programming Lang: Python
>   Description     : Python implementation of HSLuv (Human-friendly HSL)
>
> This is the dependency of trufont

I am having a situation that this code is said to be "transpiled" from
HSLuv written in Haxe [1], the code seems to be gone though a lot of
overhaul from the generated code that cannot be diffed.  I believe the
code written in Python is preferred form of making modifications for
hsluv-python project.  However, I need consensus on this mattter.

[1]: https://github.com/hsluv/hsluv-python/blob/master/hsluv.py

[toc] | [next] | [standalone]

#10275

On Mon, Mar 19, 2018 at 10:04 PM, Yao Wei wrote:

> I am having a situation that this code is said to be "transpiled" from
> HSLuv written in Haxe [1], the code seems to be gone though a lot of
> overhaul from the generated code that cannot be diffed.  I believe the
> code written in Python is preferred form of making modifications for
> hsluv-python project.  However, I need consensus on this mattter.

I suggest you dig through the git history of both HSLuv and
Python-HSLuv to develop an intuition about how the upstreams are
developing both projects and then clarify the details of their
development processes with upstream.

Personally, I find the thought of modifying generated code to be
horrible and would have either stuck with building from Haxe or
reimplementing the code in Python.

At the end of the day, what matters is that there is equality of
access to the work between the upstream authors and users of Debian
derivatives. i.e., make sure upstream aren't keeping something secret
or using something proprietary and make sure Debian passes on what we
receive from upstream.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

[toc] | [prev] | [next] | [standalone]

#10276

On Mon, Mar 19, 2018 at 10:04 PM, Yao Wei wrote:

> [1]: https://github.com/hsluv/hsluv-python/blob/master/hsluv.py

I quote from that file:

""" This module is generated by transpiling Haxe into Python and cleaning
the resulting code by hand, e.g. removing unused Haxe classes. To try it
yourself, clone https://github.com/hsluv/hsluv and run:
haxe -cp haxe/src hsluv.Hsluv -python hsluv.py """

If that is the case, then it could be possible to automate this
conversion and drop the generated and then modified file from git.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

[toc] | [prev] | [next] | [standalone]

#10277

[Multipart message — attachments visible in raw view] — view raw

I am filing an issue as question to the upstream:

https://github.com/hsluv/hsluv-python/issues/10

In the screenshot provided in the issue the code seems to be pretty
different, so I am wondering that does it count as an "reimplementation"
of hsluv?

On 03/20/2018 08:26 AM, Paul Wise wrote:
> If that is the case, then it could be possible to automate this
> conversion and drop the generated and then modified file from git.

[toc] | [prev] | [next] | [standalone]

#10278

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2018-03-20 at 08:39 +0800, Yao Wei (魏銘廷) wrote:

> In the screenshot provided in the issue the code seems to be pretty
> different, so I am wondering that does it count as an
> "reimplementation" of hsluv?

To me it looks fairly similar and the changes seem mechanical, they
could probably even be done with automatic Python AST modification.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web