Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.maint.python > #10613 > unrolled thread
| Started by | Diane Trout <diane@ghic.org> |
|---|---|
| First post | 2018-06-06 06:40 +0200 |
| Last post | 2018-06-06 09:30 +0200 |
| Articles | 8 — 4 participants |
Back to article view | Back to linux.debian.maint.python
Dask sourceless javascript passed by me. Diane Trout <diane@ghic.org> - 2018-06-06 06:40 +0200
Re: Dask sourceless javascript passed by me. Paul Wise <pabs@debian.org> - 2018-06-06 06:50 +0200
Re: Dask sourceless javascript passed by me. Scott Kitterman <debian@kitterman.com> - 2018-06-06 07:50 +0200
Re: Dask sourceless javascript passed by me. Diane Trout <diane@ghic.org> - 2018-06-08 00:10 +0200
Re: Dask sourceless javascript passed by me. Paul Wise <pabs@debian.org> - 2018-06-08 04:10 +0200
Re: Dask sourceless javascript passed by me. Diane Trout <diane@ghic.org> - 2018-06-08 20:10 +0200
Re: Dask sourceless javascript passed by me. Paul Wise <pabs@debian.org> - 2018-06-09 02:20 +0200
Re: Dask sourceless javascript passed by me. Thomas Goirand <zigo@debian.org> - 2018-06-06 09:30 +0200
| From | Diane Trout <diane@ghic.org> |
|---|---|
| Date | 2018-06-06 06:40 +0200 |
| Subject | Dask sourceless javascript passed by me. |
| Message-ID | <vXyoN-6xx-1@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi, I discovered a mistake I made with packaging dask. There's two static html files which embed some bokeh generated javascript plot code that's in dask 0.17.5 and I uploaded that to the Debian. There doesn't appear to be source to build the files. Bokeh is free software (BSD-3-Clause), but depends on a bunch of javascript libraries so isn't available in Debian. I should have repacked the archive to remove them, but I'm working on a -2 release, and there's no new upstream release yet for me to use as a base for repack. I was planning on patching the references to the .html files out and removing them in the debian/rules files. But is that enough? Diane
[toc] | [next] | [standalone]
| From | Paul Wise <pabs@debian.org> |
|---|---|
| Date | 2018-06-06 06:50 +0200 |
| Message-ID | <vXyyt-6Ba-5@gated-at.bofh.it> |
| In reply to | #10613 |
On Wed, Jun 6, 2018 at 12:30 PM, Diane Trout wrote: > I was planning on patching the references to the .html files out and > removing them in the debian/rules files. > > But is that enough? That doesn't fix the orig.tar.gz. I would suggest talking to upstream about fixing this properly (no prebuilt files or embedded code copies in the VCS and tarballs). -- bye, pabs https://wiki.debian.org/PaulWise
[toc] | [prev] | [next] | [standalone]
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2018-06-06 07:50 +0200 |
| Message-ID | <vXzux-7ei-1@gated-at.bofh.it> |
| In reply to | #10614 |
On June 6, 2018 4:42:44 AM UTC, Paul Wise <pabs@debian.org> wrote: >On Wed, Jun 6, 2018 at 12:30 PM, Diane Trout wrote: > >> I was planning on patching the references to the .html files out and >> removing them in the debian/rules files. >> >> But is that enough? > >That doesn't fix the orig.tar.gz. > >I would suggest talking to upstream about fixing this properly (no >prebuilt files or embedded code copies in the VCS and tarballs). And in the meantime repacking the existing tarball to remove the sourceless files. Scott K
[toc] | [prev] | [next] | [standalone]
| From | Diane Trout <diane@ghic.org> |
|---|---|
| Date | 2018-06-08 00:10 +0200 |
| Message-ID | <vYbgt-4NU-11@gated-at.bofh.it> |
| In reply to | #10615 |
> > I would suggest talking to upstream about fixing this properly (no > > prebuilt files or embedded code copies in the VCS and tarballs). > > And in the meantime repacking the existing tarball to remove the > sourceless files. > I was suspecting that was going to be the answer... How do I replace the .orig.tar.gz that I already uploaded? The offending .html files are linked into the diagnostics-local.html page as embedded iframes. you can see what they look like as "Profile Results" a little below this anchor link. https://dask.pydata.org/en/latest/diagnostics-local.html#example I was planning on replacing the plots with a screen shot until I have a solution to actually build the plots from source. Diane
[toc] | [prev] | [next] | [standalone]
| From | Paul Wise <pabs@debian.org> |
|---|---|
| Date | 2018-06-08 04:10 +0200 |
| Message-ID | <vYf0J-73O-7@gated-at.bofh.it> |
| In reply to | #10632 |
On Fri, Jun 8, 2018 at 5:59 AM, Diane Trout wrote: > How do I replace the .orig.tar.gz that I already uploaded? You will need a new upstream version, typically people use 0.1.2+dfsg1 (for DFSG issues) or 0.1.2+ds1 (for other repack reasons) in these sort of situations. > I was planning on replacing the plots with a screen shot until I have a > solution to actually build the plots from source. Screenshots are derivative works of the UI they are from, so theoretically you need to care about the source for screenshots too. In practice I guess everyone ignores this. -- bye, pabs https://wiki.debian.org/PaulWise
[toc] | [prev] | [next] | [standalone]
| From | Diane Trout <diane@ghic.org> |
|---|---|
| Date | 2018-06-08 20:10 +0200 |
| Message-ID | <vYtZL-7Fj-1@gated-at.bofh.it> |
| In reply to | #10633 |
On Fri, 2018-06-08 at 10:05 +0800, Paul Wise wrote: > On Fri, Jun 8, 2018 at 5:59 AM, Diane Trout wrote: > > > How do I replace the .orig.tar.gz that I already uploaded? > > You will need a new upstream version, typically people use > 0.1.2+dfsg1 > (for DFSG issues) or 0.1.2+ds1 (for other repack reasons) in these > sort of situations. Ah I see, if I adjust the changelog to <upstream>+dfsg1-1, I can upload a new .orig.tar.gz... > > > I was planning on replacing the plots with a screen shot until I > > have a > > solution to actually build the plots from source. > > Screenshots are derivative works of the UI they are from, so > theoretically you need to care about the source for screenshots too. > In practice I guess everyone ignores this. Wait a second... The pages that I want to replace with a screenshot are in a BSD-3-clause licensed repository. Aren't I allowed to make derivative works? Using a screen shot is just to deal with our build from source rule and to avoid a privacy leak from loading a remote resource. Diane
[toc] | [prev] | [next] | [standalone]
| From | Paul Wise <pabs@debian.org> |
|---|---|
| Date | 2018-06-09 02:20 +0200 |
| Message-ID | <vYzLP-2Jk-5@gated-at.bofh.it> |
| In reply to | #10636 |
On Sat, Jun 9, 2018 at 2:05 AM, Diane Trout wrote: > Using a screen shot is just to deal with our build from source rule and > to avoid a privacy leak from loading a remote resource. I believe that rule applies to all of Debian main, not just ELF binaries. -- bye, pabs https://wiki.debian.org/PaulWise
[toc] | [prev] | [next] | [standalone]
| From | Thomas Goirand <zigo@debian.org> |
|---|---|
| Date | 2018-06-06 09:30 +0200 |
| Message-ID | <vXB3j-8lg-3@gated-at.bofh.it> |
| In reply to | #10613 |
On 06/06/2018 06:30 AM, Diane Trout wrote: > Hi, > > I discovered a mistake I made with packaging dask. > > There's two static html files which embed some bokeh generated > javascript plot code that's in dask 0.17.5 and I uploaded that to the > Debian. > > There doesn't appear to be source to build the files. > > Bokeh is free software (BSD-3-Clause), but depends on a bunch of > javascript libraries so isn't available in Debian. > > I should have repacked the archive to remove them, but I'm working on a > -2 release, and there's no new upstream release yet for me to use as a > base for repack. > > I was planning on patching the references to the .html files out and > removing them in the debian/rules files. > > But is that enough? > > Diane In my experience, it is ok to just remove the minified javascript in a patch *IF* (and only if) there is normal code next to it, which isn't your case. So you must produce a +dfsg orig tarball. Cheers, Thomas Goirand (zigo)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.maint.python
csiph-web