Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #10525 > unrolled thread

Mass-commit fix of lintian ancient-python-version-field

Back to article view | Back to linux.debian.maint.python

Contents

  Mass-commit fix of lintian ancient-python-version-field Ondrej Novy <novy@ondrej.org> - 2018-05-10 13:50 +0200
    Re: Mass-commit fix of lintian ancient-python-version-field Joseph Herlant <herlantj@gmail.com> - 2018-05-11 00:30 +0200
      Re: Mass-commit fix of lintian ancient-python-version-field Ondrej Novy <novy@ondrej.org> - 2018-05-11 10:30 +0200
        Re: Mass-commit fix of lintian ancient-python-version-field Joseph Herlant <herlantj@gmail.com> - 2018-05-11 18:40 +0200
          Re: Mass-commit fix of lintian ancient-python-version-field Scott Kitterman <debian@kitterman.com> - 2018-05-11 20:40 +0200
        Re: Mass-commit fix of lintian ancient-python-version-field Joseph Herlant <herlantj@gmail.com> - 2018-05-14 02:10 +0200

#10525 — Mass-commit fix of lintian ancient-python-version-field

[Multipart message — attachments visible in raw view] — view raw

Hi,

because of:

   -
   https://wiki.debian.org/Python/LibraryStyleGuide?action=diff&rev1=85&rev2=86
   - https://lintian.debian.org/tags/ancient-python-version-field.html


I would like to mass commit into DPMT/PAPT this:
https://salsa.debian.org/python-team/modules/pytest/commit/a737368e75cb2e79f8cb61bb1615306d5f12e77a
https://salsa.debian.org/python-team/modules/pytest/commit/9cb2718daa8645ab5620d719cea1937ea0eefc50

Removing Python 2 version: <= 2.7 (thus all)
Removing Python 3 version: <= 3.4 (older than jessie)

Any objections?

Thanks.

-- 
Best regards
 Ondřej Nový

Email: novy@ondrej.org
PGP: 3D98 3C52 EB85 980C 46A5  6090 3573 1255 9D1E 064B

[toc] | [next] | [standalone]

#10531

On Thu, May 10, 2018 at 4:29 AM, Ondrej Novy <novy@ondrej.org> wrote:
> Removing Python 2 version: <= 2.7 (thus all)
> Removing Python 3 version: <= 3.4 (older than jessie)
>
> Any objections?

Thanks for doing that Ondřej, maybe we could delete the pycompat file
when exists at the same time (in a separate commit of course) to to
get rid of debian-pycompat-is-obsolete. It seems there are still 18
python modules with that file in.
If not, no worries I was planning to check the packages that have this
linitian tag in the next week or so, see what I can do to get rid of
that.

Thanks
Joseph

[toc] | [prev] | [next] | [standalone]

#10532

[Multipart message — attachments visible in raw view] — view raw

Hi,

2018-05-11 0:19 GMT+02:00 Joseph Herlant <herlantj@gmail.com>:

> ... maybe we could delete the pycompat file
> when exists at the same time (in a separate commit of course) to to
> get rid of debian-pycompat-is-obsolete. It seems there are still 18
> python modules with that file in.
>

no problem, so just remove that file?

https://github.com/onovy/onovy-mass/commit/2c24adf1ecd8fc934328f69c75b2b2d9256ee3c9

Are we sure it's completely safe to remove it globally?

-- 
Best regards
 Ondřej Nový

Email: novy@ondrej.org
PGP: 3D98 3C52 EB85 980C 46A5  6090 3573 1255 9D1E 064B

[toc] | [prev] | [next] | [standalone]

#10533

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Fri, May 11, 2018, 1:10 AM Ondrej Novy <novy@ondrej.org> wrote:

> no problem, so just remove that file?
>
>
> https://github.com/onovy/onovy-mass/commit/2c24adf1ecd8fc934328f69c75b2b2d9256ee3c9
>
> Are we sure it's completely safe to remove it globally?
>

This file has been deprecated for about 10 years if I'm correct. It was
used in old versions of dh_python and dh_pysupport.
I will double-check the code of dh_python when I'm back at a computer but
it was already asked to remove it when we migrated to dh_python2 in 2015,
see: https://wiki.debian.org/Python/TransitionToDHPython2

[toc] | [prev] | [next] | [standalone]

#10534

On Friday, May 11, 2018 09:33:20 AM Joseph Herlant wrote:
> Hi,
> 
> On Fri, May 11, 2018, 1:10 AM Ondrej Novy <novy@ondrej.org> wrote:
> > no problem, so just remove that file?
> > 
> > 
> > https://github.com/onovy/onovy-mass/commit/2c24adf1ecd8fc934328f69c75b2b2d
> > 9256ee3c9
> > 
> > Are we sure it's completely safe to remove it globally?
> 
> This file has been deprecated for about 10 years if I'm correct. It was
> used in old versions of dh_python and dh_pysupport.
> I will double-check the code of dh_python when I'm back at a computer but
> it was already asked to remove it when we migrated to dh_python2 in 2015,
> see: https://wiki.debian.org/Python/TransitionToDHPython2

If it's removal causes a problem, then we will have found a bug in the tool 
that has the problem.  pyversions will still use it if it's found, but it 
doesn't require it.

Scott K

[toc] | [prev] | [next] | [standalone]

#10536

Hi,


On Fri, May 11, 2018 at 1:10 AM, Ondrej Novy <novy@ondrej.org> wrote:
> Are we sure it's completely safe to remove it globally?

Also, it's written in the python policy to do so:
https://wiki.debian.org/Python/Policy
"Another note: if there is a debian/pycompat file, you must launch
dh_python after dh_pysupport, but the recommended way is to remove
that file."

Checked in dh-python2 and 3 and I don't see how this could be an
issue. As Scott said, if that breaks any of the 18 packages, that
would probably be a bug or that the package needs to be updated to use
a supported build system.

Joseph

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web