Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #8700 > unrolled thread

DPMT membership request

Back to article view | Back to linux.debian.maint.python

Contents

  DPMT membership request Filip Pytloun <filip@pytloun.cz> - 2016-08-04 17:40 +0200
    Re: DPMT membership request Sandro Tosi <morph@debian.org> - 2016-08-04 19:20 +0200
      Re: DPMT membership request Filip Pytloun <filip@pytloun.cz> - 2016-08-05 12:10 +0200
    Re: DPMT membership request Thomas Goirand <zigo@debian.org> - 2016-08-08 12:40 +0200
      Re: DPMT membership request Filip Pytloun <filip@pytloun.cz> - 2016-08-08 13:10 +0200
        Re: DPMT membership request Thomas Goirand <zigo@debian.org> - 2016-08-08 22:00 +0200
    Re: DPMT membership request Piotr Ożarowski <piotr@debian.org> - 2016-08-08 21:40 +0200

#8700 — DPMT membership request

[Multipart message — attachments visible in raw view] — view raw

Hello DPMT,

I would like to join to be able to package some software I am interested
in (Openstack-related + various python tools that I (co-)authored).

As the first package, I am working on packaging of python-aptly:
https://github.com/fpytloun/debian-python-aptly

I have read and agree the policy.
My Alioth login is fpytloun-guest.

Thank you,
Filip

[toc] | [next] | [standalone]

#8701

On Thu, Aug 4, 2016 at 4:35 PM, Filip Pytloun <filip@pytloun.cz> wrote:
> As the first package, I am working on packaging of python-aptly:
> https://github.com/fpytloun/debian-python-aptly

this package looks interesting, let me know if you need a sponsor and
I'd be happy to be one

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

[toc] | [prev] | [next] | [standalone]

#8703

[Multipart message — attachments visible in raw view] — view raw

Thank you very much for your interest, my sponsor/mentor is already
Ondrej Novy :-)

I have a few more tools that I authored and may be interesting to
package (any opinion appreciated):

EC2 security groups manager: https://github.com/gooddata/sgmanager
 - supports only EC2 API so it can be used on OpenStack but a shame it
   doesn't support neutron API at the moment, don't know if there will
   be any interest in this one :-X

Smoke testing framework: https://github.com/gooddata/smoker
 - not only for smoke testing but for executing anything over set of
   nodes and gathering unified result, can be interesting for some
   people

Smart files/directory cleaner: https://github.com/gooddata/tmpcleaner
 - I think this one is very useful especially on slow shared filesystems
   (eg. GlusterFS) where passing deep directory structure is expensive
   and takes a lot of time (eg. hours in environment for which this was
   developed). I don't know about any alternative tool working as this
   one.

On 2016/08/04 18:10, Sandro Tosi wrote:
> On Thu, Aug 4, 2016 at 4:35 PM, Filip Pytloun <filip@pytloun.cz> wrote:
> > As the first package, I am working on packaging of python-aptly:
> > https://github.com/fpytloun/debian-python-aptly
> 
> this package looks interesting, let me know if you need a sponsor and
> I'd be happy to be one
> 
> -- 
> Sandro "morph" Tosi
> My website: http://sandrotosi.me/
> Me at Debian: http://wiki.debian.org/SandroTosi
> G+: https://plus.google.com/u/0/+SandroTosi

[toc] | [prev] | [next] | [standalone]

#8715

On 08/04/2016 05:35 PM, Filip Pytloun wrote:
> Hello DPMT,
> 
> I would like to join to be able to package some software I am interested
> in (Openstack-related + various python tools that I (co-)authored).
> 
> As the first package, I am working on packaging of python-aptly:
> https://github.com/fpytloun/debian-python-aptly
> 
> I have read and agree the policy.
> My Alioth login is fpytloun-guest.
> 
> Thank you,
> Filip

Hi Filip,

A few things about your packaging.

1/ debian/rules
===============
1.a. Simplifying dpkg-parsechangelog

You can replace your PKG = line with:

PKG = $(shell dpkg-parsechangelog -SSource)

The same way, you can simplify VER = using dpkg-parsechangelog -SVersion

Note that I'm not adding a space after the -S, as this would add an
incompatibility with Ubuntu trusty (and there's no reason why you
wouldn't care as this is a gratuitous fix for it).

1.b. Adding unnecessary parenthesis

Why are you adding parenthesis to the command:
PYTHONPATH=. help2man

?

1.c. Using update-alternatives for /usr/bin

Instead of doing:
	rm -rf debian/python-aptly/usr/bin
	mkdir -p debian/aptly-publisher/usr
	mv debian/python3-aptly/usr/bin debian/aptly-publisher/usr/

you can have a look at using pkgos-alternative-bin from
openstack-pkg-tools. This will generate postinst, prerm and postrm for
you, so it handles /usr/bin with python2 or python3 alternatives.
Optionally, you can fix py3 as higher priority in the postinst files if
you prefer.

2/ debian/control
=================
2.a X-Python{3,}-Version headers

Please remove X-Python-Version: >= 2.6 and X-Python3-Version: >= 3.2
stuff. Jessie has Python 2.6 and Python 3.4, so these are completely
useless. It isn't even needed in oldstable!!!

2.b Build-Depends-Indep:

Since both all of the generated binaries are Arch: all, you can put some
of the Build-Depends into Build-Depends-Indep: like this:

Build-Depends: debhelper (>= 9),
               dh-python,
               help2man,
               python-all,
               python-setuptools,
               python3-all,
               python3-setuptools
Build-Depends-Indep: python-requests,
                     python-yaml,

I was also very much surprised to not see python3-requests and
python3-yaml in your build-depends. Aren't you running Py3 tests too?

2.c Short and long description

Your short description for python-aptly and python3-aptly shouldn't be
that different. Also, upstream short desc is nicer. I'd suggest:

Package: python-aptly
Description: REST API client  and tooling - Python 2.7
[...]
Package: python3-aptly
Description: REST API client  and tooling - Python 3.x

2.d Long desc for Package: aptly-publisher

The long desc start by an empty line. This isn't nice. Also, please
consider longer long descriptions. 2 lines isn't enough, at least 5
would be nicer. Upstream has a lot more info which you can pickup.

3/ Final word

I hope this helps. Thanks for your contribution to Debian.

Cheers,

Thomas Goirand (zigo)

[toc] | [prev] | [next] | [standalone]

#8716

[Multipart message — attachments visible in raw view] — view raw

Hello Zigo,

thank you very much for your feedback!
More inline:

> 1/ debian/rules
> ===============
> 1.a. Simplifying dpkg-parsechangelog
> 
> You can replace your PKG = line with:
> 
> PKG = $(shell dpkg-parsechangelog -SSource)
> 
> The same way, you can simplify VER = using dpkg-parsechangelog -SVersion
> 
> Note that I'm not adding a space after the -S, as this would add an
> incompatibility with Ubuntu trusty (and there's no reason why you
> wouldn't care as this is a gratuitous fix for it).

I found this at https://wiki.debian.org/onlyjob/get-orig-source
Didn't know these shortcuts anyway, fixing.

> 
> 1.b. Adding unnecessary parenthesis
> 
> Why are you adding parenthesis to the command:
> PYTHONPATH=. help2man

Yes, that should not be needed, removing.

> 
> ?
> 
> 1.c. Using update-alternatives for /usr/bin
> 
> Instead of doing:
> 	rm -rf debian/python-aptly/usr/bin
> 	mkdir -p debian/aptly-publisher/usr
> 	mv debian/python3-aptly/usr/bin debian/aptly-publisher/usr/
> 
> you can have a look at using pkgos-alternative-bin from
> openstack-pkg-tools. This will generate postinst, prerm and postrm for
> you, so it handles /usr/bin with python2 or python3 alternatives.
> Optionally, you can fix py3 as higher priority in the postinst files if
> you prefer.

I was thinking about using alternatives vs forcing python3 (didn't know
pkgos-alternative-bin anyway or any reference package for this case) but
decided to force Python 3 as it should be Debian's default.

> 
> 2/ debian/control
> =================
> 2.a X-Python{3,}-Version headers
> 
> Please remove X-Python-Version: >= 2.6 and X-Python3-Version: >= 3.2
> stuff. Jessie has Python 2.6 and Python 3.4, so these are completely
> useless. It isn't even needed in oldstable!!!

Good, didn't know it's not needed now.

> 
> 2.b Build-Depends-Indep:
> 
> Since both all of the generated binaries are Arch: all, you can put some
> of the Build-Depends into Build-Depends-Indep: like this:
> 
> Build-Depends: debhelper (>= 9),
>                dh-python,
>                help2man,
>                python-all,
>                python-setuptools,
>                python3-all,
>                python3-setuptools
> Build-Depends-Indep: python-requests,
>                      python-yaml,
> 
> I was also very much surprised to not see python3-requests and
> python3-yaml in your build-depends. Aren't you running Py3 tests too?

Will fix this.

> 
> 2.c Short and long description
> 
> Your short description for python-aptly and python3-aptly shouldn't be
> that different. Also, upstream short desc is nicer. I'd suggest:
> 
> Package: python-aptly
> Description: REST API client  and tooling - Python 2.7
> [...]
> Package: python3-aptly
> Description: REST API client  and tooling - Python 3.x
> 
> 2.d Long desc for Package: aptly-publisher
> 
> The long desc start by an empty line. This isn't nice. Also, please
> consider longer long descriptions. 2 lines isn't enough, at least 5
> would be nicer. Upstream has a lot more info which you can pickup.

Fixed.

> 
> 3/ Final word
> 
> I hope this helps. Thanks for your contribution to Debian.

Helps a lot, thank you again!

> 
> Cheers,
> 
> Thomas Goirand (zigo)
> 

[toc] | [prev] | [next] | [standalone]

#8723

On 08/08/2016 01:06 PM, Filip Pytloun wrote:
>> 1.c. Using update-alternatives for /usr/bin
>>
>> Instead of doing:
>> 	rm -rf debian/python-aptly/usr/bin
>> 	mkdir -p debian/aptly-publisher/usr
>> 	mv debian/python3-aptly/usr/bin debian/aptly-publisher/usr/
>>
>> you can have a look at using pkgos-alternative-bin from
>> openstack-pkg-tools. This will generate postinst, prerm and postrm for
>> you, so it handles /usr/bin with python2 or python3 alternatives.
>> Optionally, you can fix py3 as higher priority in the postinst files if
>> you prefer.
> 
> I was thinking about using alternatives vs forcing python3 (didn't know
> pkgos-alternative-bin anyway or any reference package for this case) but
> decided to force Python 3 as it should be Debian's default.

I very much agree that Python 3 should be the default, however, IMO
there's not much point supporting Python 2 and not providing the needed
command line tools. To me, either you support Py2 fully, or you just
don't support it at all. YMMV I guess.

>> 2/ debian/control
>> =================
>> 2.a X-Python{3,}-Version headers
>>
>> Please remove X-Python-Version: >= 2.6 and X-Python3-Version: >= 3.2
>> stuff. Jessie has Python 2.6 and Python 3.4, so these are completely
>> useless. It isn't even needed in oldstable!!!
> 
> Good, didn't know it's not needed now.

Well, it may sometimes be needed. For example, let's say Stretch is
released, and at some point, Buster gets Python 3.6. Some packages may
support only that, and then you may need X-Python3-Version: >= 3.6. But
if we have already 3.4, and you're declaring "I'm supporting only >=
3.2", then there is no point.

Cheers,

Thomas Goirand (zigo)

P.S: Please don't CC me, I'm subscribed, and if you didn't know, it's
the rule in Debian to not CC.

[toc] | [prev] | [next] | [standalone]

#8721

[Filip Pytloun, 2016-08-04]
> I would like to join to be able to package some software I am interested
> in (Openstack-related + various python tools that I (co-)authored).

Welcome :)
-- 
Piotr Ożarowski                         Debian GNU/Linux Developer
www.ozarowski.pl          www.griffith.cc           www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web