Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.maint.python > #14991 > unrolled thread
| Started by | c.buhtz@posteo.jp |
|---|---|
| First post | 2023-03-29 10:00 +0200 |
| Last post | 2023-03-29 13:10 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.debian.maint.python
Unittests writing to HOME (backintime) c.buhtz@posteo.jp - 2023-03-29 10:00 +0200
Re: Unittests writing to HOME (backintime) Andrey Rakhmatullin <wrar@wrar.name> - 2023-03-29 11:50 +0200
Re: Unittests writing to HOME (backintime) c.buhtz@posteo.jp - 2023-03-29 12:10 +0200
Re: Unittests writing to HOME (backintime) Andrey Rakhmatullin <wrar@wrar.name> - 2023-03-29 15:10 +0200
Re: Unittests writing to HOME (backintime) buhtz@posteo.de - 2023-03-29 12:30 +0200
Re: Unittests writing to HOME (backintime) Simon McVittie <smcv@debian.org> - 2023-03-29 13:10 +0200
| From | c.buhtz@posteo.jp |
|---|---|
| Date | 2023-03-29 10:00 +0200 |
| Subject | Unittests writing to HOME (backintime) |
| Message-ID | <GeySS-fT6i-9@gated-at.bofh.it> |
Hello,
I assume this topic is not specific to one package but to the whole
python packaging universe.
There is "backintime" which unittests do write to $HOME. I'm one of the
new upstream maintainers and know that this isn't a good idea. It will
take time to fix this.
About that problem there is a debian bug report nearly 4 years old
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940319
It tells that this is a problem because writing to HOME during build "is
disabled on Debian auto-builders".
My question now is why newer version of this package are uploaded then?
I couldn't find that the tests where deactivated. Maybe this "disabled
on Debian auto-builders" is outdated and today it is possible to write
to HOME during build?
[toc] | [next] | [standalone]
| From | Andrey Rakhmatullin <wrar@wrar.name> |
|---|---|
| Date | 2023-03-29 11:50 +0200 |
| Message-ID | <GeABj-fUeZ-7@gated-at.bofh.it> |
| In reply to | #14991 |
On Wed, Mar 29, 2023 at 07:52:35AM +0000, c.buhtz@posteo.jp wrote: > I assume this topic is not specific to one package but to the whole python > packaging universe. > > There is "backintime" which unittests do write to $HOME. I'm one of the new > upstream maintainers and know that this isn't a good idea. It will take time > to fix this. > About that problem there is a debian bug report nearly 4 years old > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940319 > > It tells that this is a problem because writing to HOME during build "is > disabled on Debian auto-builders". > > My question now is why newer version of this package are uploaded then? I > couldn't find that the tests where deactivated. As the software doesn't use a discoverabe build system the package needs to have all build steps explicitly in d/rules, and it just doesn't have the test step there. > Maybe this "disabled on > Debian auto-builders" is outdated and today it is possible to write to HOME > during build? No. The usual solution is AFAIK to set a temporary $HOME inside d/rules though.
[toc] | [prev] | [next] | [standalone]
| From | c.buhtz@posteo.jp |
|---|---|
| Date | 2023-03-29 12:10 +0200 |
| Message-ID | <GeAUF-fUBL-3@gated-at.bofh.it> |
| In reply to | #14998 |
Dear Andrey,
thank you for the reply.
Am 29.03.2023 11:40 schrieb Andrey Rakhmatullin:
> The usual solution is AFAIK to set a temporary $HOME inside d/rules
> though.
I was looking into
https://salsa.debian.org/jmw/pkg-backintime/-/blob/debian/debian/rules
I don't see creation of a HOME or deactivation of a test.
I assume I have to wait of an answer from the package maintainer.
Thanks in advance
[toc] | [prev] | [next] | [standalone]
| From | Andrey Rakhmatullin <wrar@wrar.name> |
|---|---|
| Date | 2023-03-29 15:10 +0200 |
| Message-ID | <GeDIR-fWoJ-7@gated-at.bofh.it> |
| In reply to | #15000 |
On Wed, Mar 29, 2023 at 10:03:31AM +0000, c.buhtz@posteo.jp wrote: > > The usual solution is AFAIK to set a temporary $HOME inside d/rules > > though. > > I was looking into > https://salsa.debian.org/jmw/pkg-backintime/-/blob/debian/debian/rules > > I don't see creation of a HOME or deactivation of a test. This means you've missed my explanation.
[toc] | [prev] | [next] | [standalone]
| From | buhtz@posteo.de |
|---|---|
| Date | 2023-03-29 12:30 +0200 |
| Message-ID | <GeBe1-fUID-1@gated-at.bofh.it> |
| In reply to | #14998 |
Dear Andrey,
thank you for the reply.
Am 29.03.2023 11:40 schrieb Andrey Rakhmatullin:
> The usual solution is AFAIK to set a temporary $HOME inside d/rules
> though.
I was looking into
https://salsa.debian.org/jmw/pkg-backintime/-/blob/debian/debian/rules
I don't see creation of a HOME or deactivation of a test.
I assume I have to wait of an answer from the package maintainer.
Thanks in advance
[toc] | [prev] | [next] | [standalone]
| From | Simon McVittie <smcv@debian.org> |
|---|---|
| Date | 2023-03-29 13:10 +0200 |
| Message-ID | <GeBQJ-fVcI-5@gated-at.bofh.it> |
| In reply to | #14991 |
On Wed, 29 Mar 2023 at 07:52:35 +0000, c.buhtz@posteo.jp wrote:
> My question now is why newer version of this package are uploaded then? I
> couldn't find that the tests where deactivated. Maybe this "disabled on
> Debian auto-builders" is outdated and today it is possible to write to HOME
> during build?
In compat level 13, debhelper will set $HOME to a temporary directory
during the build (see #942111).
The user's "official" home directory in the system user database
(getent passwd $(id -u) | cut -d: -f6) is still set to a directory that
does't exist (/nonexistent) on the official buildds.
>From an upstream point of view it's still bad for unit tests to do
anything destructive in $HOME, because upstream developers who run the
unit tests won't want their data destroyed, but it's harmless to do
non-destructive things like writing to ~/.cache.
smcv
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.maint.python
csiph-web