Groups > linux.debian.maint.python > #12303

Re: Force pushing on salsa?

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mattia Rizzolo <mattia@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: Force pushing on salsa?
Date	Tue, 11 Feb 2020 17:50:02 +0100
Message-ID	<zyGTw-2Gj-5@gated-at.bofh.it> (permalink)
References	<zyGJQ-2CM-7@gated-at.bofh.it>
X-Original-To	debian-python@lists.debian.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Tue Feb 11 16:46:44 2020
Old-Return-Path	<mattia@debian.org>
X-Amavis-Spam-Status	No, score=-11.88 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, FVGT_m_MULTI_ODD=0.02, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
X-Policyd-Weight	NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .debian. - helo: .savidlin.mapreri. - helo-domain: .mapreri.) FROM/MX_MATCHES_NOT_HELO(DOMAIN)=0; rate: -3.5
Mail-Followup-To	debian-python@lists.debian.org
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KR/qxknboQ7+Tpez"
Content-Disposition	inline
X-Info	Keep It Simple, Stupid.
X-Operating-System	Linux, kernel 5.2.0-2-amd64, inside Debian GNU/Linux bullseye/sid sid.
X-Message-Flag	WARNING!! Outlook sucks. A lot.
User-Agent	Every email client sucks, this one just sucks less.
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/17930
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20200211164628.GG385407@mapreri.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Tue, 11 Feb 2020 17:46:28 +0100
X-Original-Message-ID	<20200211164628.GG385407@mapreri.org>
X-Original-References	<1b950574-b5f7-0b77-61f1-b5a363d934c6@debian.org>
Xref	csiph.com linux.debian.maint.python:12303

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Feb 11, 2020 at 11:34:23AM -0500, Louis-Philippe Véronneau wrote:
> Looking at a package recently, I saw some important mistakes and I was
> wondering: would it be ok to force push to fix them?
> 
> More explicitly, the import of the new upstream version with
> pristine-tar contains a bunch of errors due to a wrong manipulation. It
> seems to me it would be "more clean" to start again and force push.
> 
> I know force pushing is normally frowned upon when working in a team
> environment, but I haven't seen any mention of it in the Python Team's
> policy.

Let me keep frowing deeply.

If pristine-tar data is corrupted, just use
    % pristine-tar commit ../foo_1.2.3.orig.tar.xz upstream/1.2.3
to update the data, without force-pushing.  It's just one extra commit,
so why would that be "less clean"?!


The only thing I could *very frowingly* accept, is force-pushing a tag
because you are doing it again.  Having said that, I usually just append
a number if I need to re-repack again an upstream tarball (+dfsg1,
+dfsg2, etc).  But you mentioned only pristine-tar, so I suppose that's
not your case.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Force pushing on salsa? Louis-Philippe Véronneau <pollo@debian.org> - 2020-02-11 17:40 +0100
  Re: Force pushing on salsa? Mattia Rizzolo <mattia@debian.org> - 2020-02-11 17:50 +0100

csiph-web