Groups > linux.debian.maint.python > #12117

Re: Merge Requests

Path	csiph.com!4.us.feeder.erje.net!2.eu.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!weretis.net!feeder7.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Raphael Hertzog <hertzog@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: Merge Requests
Date	Fri, 06 Dec 2019 21:50:01 +0100
Message-ID	<zasI1-2q2-5@gated-at.bofh.it> (permalink)
References	<zaifE-4pX-13@gated-at.bofh.it> <zarLX-1Qx-7@gated-at.bofh.it>
X-Original-To	Louis-Philippe Véronneau <pollo@debian.org>
X-Mailbox-Line	From debian-python-request@lists.debian.org Fri Dec 6 20:45:44 2019
Old-Return-Path	<hertzog@debian.org>
X-Amavis-Spam-Status	No, score=-10.7 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, CAPINIT=0.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
X-Originating-IP	109.190.218.133
Mail-Followup-To	Raphael Hertzog <hertzog@debian.org>, Louis-Philippe Véronneau <pollo@debian.org>, debian-python@lists.debian.org
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qlTNgmc+xy1dBmNv"
Content-Disposition	inline
User-Agent	Mutt/1.12.2 (2019-09-21)
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/17713
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20191206204528.GC613857@home.ouaza.com
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Fri, 6 Dec 2019 21:45:28 +0100
X-Original-Message-ID	<20191206204528.GC613857@home.ouaza.com>
X-Original-References	<0ffb3f17-0eff-2c07-3cc7-2d2e7b164aa5@debian.org> <d7ffa8d7-0b26-8442-724f-a92623aab791@debian.org>
Xref	csiph.com linux.debian.maint.python:12117

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, 06 Dec 2019, Louis-Philippe Véronneau wrote:
> On 19-12-06 04 h 34, Jonathan Carter wrote:
> > For other MRs, I noticed that many small changes in the packaging didn't
> > have an associated changelog entry with it, so I had to dch to add a
> > changelog entry. I think for small changes I'd prefer the person who
> > submits the MR to add them. For larger ones it probably makes sense not
> > to do that since it might take longer.
> 
> I rarely add a changelog entry when creating MRs, as I feel it often is
> a burden for the maintainers if the MR isn't immediately merged and new
> releases are made (creates merge conflicts, etc.).

And it's also painful when you use "gbp dch", having a commit in the
middle introduce a changelog entry means that the next "gbp dch" run
might miss some commits that need to be documented.

Not everybody is sold to the idea of using "gbp dch" but it's definitely
cleaner IMO. Commits that do not modify debian/changelog are also easier
to cherry-pick between different branches, etc.

Cheers,
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog <hertzog@debian.org>
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋    The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄⠀⠀⠀⠀   Debian Long Term Support: https://deb.li/LTS

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Merge Requests Jonathan Carter <jcc@debian.org> - 2019-12-06 10:40 +0100
  Re: Merge Requests Scott Kitterman <debian@kitterman.com> - 2019-12-06 12:30 +0100
  Re: Merge Requests Louis-Philippe Véronneau <pollo@debian.org> - 2019-12-06 20:50 +0100
    Re: Merge Requests Raphael Hertzog <hertzog@debian.org> - 2019-12-06 21:50 +0100

csiph-web