Groups > linux.debian.maint.python > #11795

Re: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye

Path	csiph.com!news.mixmin.net!news.albasani.net!tahina.priv.at!bofh.it!news.nic.it!robomod
From	Andreas Tille <andreas@an3as.eu>
Newsgroups	linux.debian.maint.python, linux.debian.bugs.dist
Subject	Re: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye
Date	Thu, 12 Sep 2019 16:10:01 +0200
Message-ID	<yFxXj-6ZH-7@gated-at.bofh.it> (permalink)
References	<yBKT7-8wu-11@gated-at.bofh.it> <yFaem-7xs-3@gated-at.bofh.it> <yFbDr-ee-7@gated-at.bofh.it> <yFbWN-lQ-9@gated-at.bofh.it> <yFryx-2BZ-1@gated-at.bofh.it> <yFt7j-3w7-9@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu Sep 12 14:09:20 2019
Old-Return-Path	<andreas@an3as.eu>
X-Amavis-Spam-Status	No, score=-3.32 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, MEDS2=2, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_NONE=-0.0001, SARE_MLH_Stock10=1.66] autolearn=no autolearn_force=no
X-Policyd-Weight	using cached result; rate: -4.6
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/17320
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20190912140906.wfagwtol4ljcinhz@an3as.eu
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	939181@bugs.debian.org, Antonio Terceiro <terceiro@debian.org>
X-Original-Date	Thu, 12 Sep 2019 16:09:06 +0200
X-Original-Message-ID	<20190912140906.wfagwtol4ljcinhz@an3as.eu>
X-Original-References	<alpine.DEB.2.21.1909012302200.30297@bear.techie.net> <20190911123354.GA16873@debian.org> <20190911141234.7hwnsil5bp2m6cew@an3as.eu> <20190911143233.GC1706@belkar.wrar.name> <20190912071708.5olnqppyshvtus2n@an3as.eu> <20190912085732.GD1706@belkar.wrar.name>
Xref	csiph.com linux.debian.maint.python:11795 linux.debian.bugs.dist:974856

Cross-posted to 2 groups.

Show key headers only | View raw

On Thu, Sep 12, 2019 at 01:57:32PM +0500, Andrey Rahmatullin wrote:
> > > There are circular imports in the code so you most likely broke that by
> > > reordering imports in various files.
> > 
> > s/you most likely broke/2to3 most likely broke/
> 2to3 doesn't do that. You mentioned autopep8, it could do that.

Ahhh, well, that might be another way to mess up the sequence.  Put a
mental note to warn me about autodep8.
 
> > So may be I misinterpreted your hint but even reverting the reordering
> > of 2to3 in my latest commit does not help.
> I also said that other changes may be problematic too. I didn't check
> them.

OK, I redid the patching in git[1] now.  Some more wxPython 4 porting
was needed as well but I somehow got the user interface working.  May be
some final helping hint could be how to fix leaving the program that
leads to:


Traceback (most recent call last):
  File "/usr/bin/cycle", line 83, in OnCloseWindow
    Save_Cycle(cycle.name, cycle.passwd, cycle.file)
  File "/usr/share/cycle/save_load.py", line 27, in Save_Cycle
    m.update(passwd)
TypeError: Unicode-objects must be encoded before hashing


I tried

  m.update(passwd.encode())

but this leads later to

Traceback (most recent call last):
  File "cycle.py", line 83, in OnCloseWindow
    Save_Cycle(cycle.name, cycle.passwd, cycle.file)
  File "/home/andreas/debian-maintain/salsa/med-team/cycle/save_load.py", line 46, in Save_Cycle
    tmp=rt.encrypt( 'Cycle'+pickle.dumps(objSave) )
TypeError: can only concatenate str (not "bytes") to str


Since I do not have much experience with hashlib I'd be happy if someone
might be able to proof-read `def Save_Cycle` in save_load.py.

Kind regards

      Andreas.


[1] https://salsa.debian.org/med-team/cycle

-- 
http://fam-tille.de

Thread

Bug#939181: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Andreas Tille <andreas@an3as.eu> - 2019-09-11 16:20 +0200
  Bug#939181: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Andrey Rahmatullin <wrar@debian.org> - 2019-09-11 17:10 +0200
    Bug#939181: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Andreas Tille <tille@debian.org> - 2019-09-12 09:30 +0200
      Bug#939181: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Andrey Rahmatullin <wrar@debian.org> - 2019-09-12 11:10 +0200
        Re: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Andreas Tille <andreas@an3as.eu> - 2019-09-12 16:10 +0200
          Re: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Michael Kesper <mkesper@schokokeks.org> - 2019-09-12 21:10 +0200
            Bug#939181: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Andreas Tille <tille@debian.org> - 2019-09-13 12:10 +0200

csiph-web