Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #10787

Re: RFS: pcapy/0.11.3-1 [ITA]

Cross-posted to 2 groups.

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello Sergio!

Thanks for your comments!

I fix the problems that you say me. Please check it

1) On d/copyright, the license specified for the project is wrong.
> According to the LICENSE file, the project is released under a slightly
> modified version of the Apache license.  This is something really
> important to get right, otherwise the ftp-masters will certainly reject
> the package.  You listed the license as being "GPL-2", but the text is
> clearly not GPL-2.
>
> Ohh!!! Sorry I saw the old d/copyright file to do this.

2) Still on d/copyright: as said above, the GPL-2 license is wrong.
> However, I think it's also important to mention that the license text is
> formatted in a strange/wrong manner.  You have text like this:
>
>  [...]
>  Redistribution and use in source  and binary forms, with or without
>    modification, are permitted  provided that the following conditions
>    are met:
>
>        1. Redistributions  of  source   code  must  retain  the  above
>  [...]
>
> The correct format for d/copyright is to indent the text using 1 space,
> and to use . (dot) for blank lines.  Like this:
>
>  [...]
>  Redistribution and use in source  and binary forms, with or without
>  modification, are permitted  provided that the following conditions
>  are met:
>  .
>  1. Redistributions  of  source   code  must  retain  the  above
>  [...]
>


Ready!

>
> 3) The package uses a *really* old version of debhelper (version 5!).
> We're at version 11 already, so you should update both d/compat and
> d/control (i.e., depend on debhelp >= 11) to reflect that.
>

Ready!

>
> 4) You haven't addressed my comment about building a Python 3 package.
> IMO you should really do that; lintian will warn you if you don't.
>

Yes, I forgot do that! Sorry!

>
> 5) You haven't answered my question about why the package has "Suggests:
> doc-base".  It seems to be a relic from this very old debhelper; I think
> you can safely remove it.
>

Yes, I remove it. Since I do not have much knowledge about doc-base and why
it is there, I left it. But now is removed.

Thanks for your help!
Regards!

-- 
Arias Emmanuel
https://www.linkedin.com/in/emmanuel-arias-437a6a8a
http://eamanu.com

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#900820: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-06-05 15:10 +0200
  Bug#900968: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-06-07 14:10 +0200
    Re: RFS: pcapy/0.11.3-1 [ITA] Sergio Durigan Junior <sergiodj@debian.org> - 2018-06-16 21:50 +0200
      Re: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-07-03 02:40 +0200
        Re: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-08-11 05:30 +0200
          Re: RFS: pcapy/0.11.3-1 [ITA] Sergio Durigan Junior <sergiodj@debian.org> - 2018-08-11 08:00 +0200
            Re: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-08-11 11:50 +0200
              Re: RFS: pcapy/0.11.3-1 [ITA] Sergio Durigan Junior <sergiodj@debian.org> - 2018-08-20 02:40 +0200
                Re: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-08-22 02:30 +0200
                Re: RFS: pcapy/0.11.3-1 [ITA] Sergio Durigan Junior <sergiodj@debian.org> - 2018-08-22 07:00 +0200
                Re: RFS: pcapy/0.11.3-1 [ITA] eamanu15 <emmanuelarias30@gmail.com> - 2018-08-30 04:00 +0200
                Re: RFS: pcapy/0.11.3-1 [ITA] Sergio Durigan Junior <sergiodj@debian.org> - 2018-08-30 06:40 +0200

csiph-web