Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14660

Re: Review of Debian package pystray

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Claudius,

took a look at the pystray package up for sponsorship in the Python
team. Overall it's in really good shape, still a few comments left
though:

* control: the long description is really short and mentions neither
supported environment nor any other pystray features.

* tests:
 + please loop over py3versions -s rather than -r;
 + both tests have the same test-name;
 + the upstream testsuite autopkgtest doesn't actually run any tests
   according to ci logs [1];
 + for the upstream testsuite, you want to copy the test files to the
   $AUTOPKGTEST_TMP dir and run from there, to avoid testing the
   extracted sources rather than the installed package;
 + keeping the test commands/script in a separate file (rather than
   d/tests/control) tends to greatly increase readability for all but
   the smallest and most trivial autopkgtests.


[1]https://salsa.debian.org/python-team/packages/pystray/-/jobs/3596337#L411

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Review of Debian package pystray Louis-Philippe Véronneau <pollo@debian.org> - 2022-10-22 05:30 +0200
  Re: Review of Debian package pystray Louis-Philippe Véronneau <pollo@debian.org> - 2022-11-07 18:50 +0100
    Re: Review of Debian package pystray Claudius Heine <ch@denx.de> - 2022-11-08 15:50 +0100
      Re: Review of Debian package pystray Jeroen Ploemen <jcfp@debian.org> - 2022-12-03 09:40 +0100

csiph-web