Groups > linux.debian.maint.python > #14682

Re: request for review: python-pyglfw

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Timo Röhling <roehling@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: request for review: python-pyglfw
Date	Sun, 04 Dec 2022 14:30:01 +0100
Message-ID	<FyXe9-8iWn-1@gated-at.bofh.it> (permalink)
References	<FyVFn-8hJ1-11@gated-at.bofh.it>
X-Original-To	debian-python@lists.debian.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Sun Dec 4 13:25:42 2022
Old-Return-Path	<roehling@debian.org>
X-Amavis-Spam-Status	No, score=-113.024 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MONEY=0.5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
Mail-Followup-To	debian-python@lists.debian.org
Organization	The Debian Project
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kdr4eovnq3ategbl"
Content-Disposition	inline
X-Debian-User	roehling
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20544
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20221204132519.ke2t33oqinkefcq3@mail.gaussglocke.de
Approved	robomod@news.nic.it
Lines	91
Sender	robomod@news.nic.it
X-Original-Date	Sun, 4 Dec 2022 14:25:19 +0100
X-Original-Message-ID	<20221204132519.ke2t33oqinkefcq3@mail.gaussglocke.de>
X-Original-References	<Y4yIfqi5c+MbzEHq@fusion>
Xref	csiph.com linux.debian.maint.python:14682

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Étienne,

* Étienne Mollier <emollier@emlwks999.eu> [2022-12-04 12:46]:
>I'm a DD, but since this is my first DPT package, I wouldn't be
>against having a second pair of eyeballs having a look at the
>python-pyglfw package I produced this morning[1].  The packaging
>in itself was super smooth, I just wanted to make sure I didn't
>miss team specific bits; I had the policy and guide under the
>eyes while packaging, but one never knows.
>
>[1]: https://salsa.debian.org/python-team/packages/python-pyglfw
- You forgot to push the upstream and pristine-tar branches, the
   upstream/2.5.5+dfsg tag, and you should set
   "debian-branch = debian/master" in d/gbp.conf

- I think the package can be arch:all, as the package will be
   identical an all architectures, with all architecture-specific
   bits hidden behind the ctypes indirection.

- The "Build-Depends: libglfw3 <!nocheck>" seems unnecessary, because
   AFAICT, there is no test suite in the package at all.

- There is no "Testsuite: autopkgtest-pkg-python" in d/control. I'm
   really not sure if this is an issue, because I usually have more
   intrusive tests and seldomly rely on the default one. Besides, you
   did add a config in d/tests, which may also suffice? I really
   don't know, but wanted to mention it just in case.

- I've never set LC_ALL in d/rules. Is there a particular reason
   why it is necessary?

- Personally, I prefer having dh-sequence-python3 in Build-Depends,
   so I don't have to add --with python3 in d/rules.

Everything else looks good to me, with the caveat that I did not
actually test-build the package, because of the missing pushes.

Oh, and welcome to the team, nice to have you here!


Cheers
Timo


-- 
⢀⣴⠾⠻⢶⣦⠀   ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁   │ Timo Röhling                                       │
⢿⡄⠘⠷⠚⠋⠀   │ 9B03 EBB9 8300 DF97 C2B1  23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀   ╰────────────────────────────────────────────────────╯

Thread

request for review: python-pyglfw Étienne Mollier <emollier@emlwks999.eu> - 2022-12-04 12:50 +0100
  Re: request for review: python-pyglfw Timo Röhling <roehling@debian.org> - 2022-12-04 14:30 +0100
    Re: request for review: python-pyglfw Étienne Mollier <emollier@emlwks999.eu> - 2022-12-04 15:50 +0100

csiph-web