Groups > linux.debian.maint.python > #14705

review for kivy/2.1.0-1

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Jeroen Ploemen <jcfp@debian.org>
Newsgroups	linux.debian.maint.python
Subject	review for kivy/2.1.0-1
Date	Thu, 08 Dec 2022 16:30:01 +0100
Message-ID	<FAr0t-9gCV-3@gated-at.bofh.it> (permalink)
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu Dec 8 15:28:38 2022
Old-Return-Path	<jcfp@debian.org>
X-Amavis-Spam-Status	No, score=-115.024 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
X-Mailer	Claws Mail 4.1.1 (GTK 3.24.20; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="Sig_/aVGiBNARy=0Sr3tyvxFVRFy"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Debian-User	jcfp
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20571
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20221208162757.3943faea@debian.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Thu, 8 Dec 2022 16:27:57 +0100
X-Original-Message-ID	<20221208162757.3943faea@debian.org>
Xref	csiph.com linux.debian.maint.python:14705

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Dean,

I reviewed the kivy package up for sponsorship in the Python team:

* There's quite a few lintian hits [1], and most of those look legit.
  Please fix the correctly identified issues, and add overrides for
  any false positives.

* In the changelog, you should mention this is a team upload;
  otherwise (with you not listed as either maintainer or uploader) it
  looks like an NMU.

* The copyright file is missing many entries, including:
doc/sources/.static/jquery.cookie.js:6: * Copyright (c) 2010 Klaus Hartl (stilbuero.de)
doc/sources/.static/jquery-effects-core-and-slide.js:4: * Copyright 2011, AUTHORS.txt (http://jqueryui.com/about)
doc/sources/.static/jquery-effects-core-and-slide.js:736: * Copyright 2001 Robert Penner
kivy/lib/kivy_endian.h:3:  Copyright (C) 1997-2018 Sam Lantinga
kivy/lib/sdl2.pxi:1:#Copyright (c) 2010-2012, Gabriel Jacobo
kivy/lib/libtess2/Source/...:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
kivy/lib/libtess2/Include/tesselator.h:3:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
kivy/tools/pep8checker/pep8.py:4:# Copyright (C) 2006-2009 Johann C. Rocholl
kivy/tools/pep8checker/pep8.py:5:# Copyright (C) 2009-2014 Florent Xicluna
kivy/tools/pep8checker/pep8.py:6:# Copyright (C) 2014-2016 Ian Lee


Once fixed, simply add the package back to the RFS list in the IRC
channel topic.


[1] https://salsa.debian.org/python-team/packages/kivy/-/jobs/3617039

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

review for kivy/2.1.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-08 16:30 +0100
  Re: review for kivy/2.1.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-27 19:30 +0100
    Re: review for kivy/2.1.0-1 jcfp <linux@jcf.pm> - 2023-01-01 12:20 +0100
      Re: review for kivy/2.1.0-1 Vincent Cheng <vcheng@debian.org> - 2023-01-05 10:20 +0100
        Re: review for kivy/2.1.0-1 Jeroen Ploemen <jcfp@debian.org> - 2023-01-05 18:30 +0100

csiph-web