Groups > linux.debian.maint.python > #13834

Re: sphinxext-opengraph new upstream version and tests

Path	csiph.com!newsfeed.xs4all.nl!newsfeed9.news.xs4all.nl!bofh.it!news.nic.it!robomod
From	Jeroen Ploemen <jcfp@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: sphinxext-opengraph new upstream version and tests
Date	Fri, 31 Dec 2021 13:10:01 +0100
Message-ID	<DAoTn-1b6-5@gated-at.bofh.it> (permalink)
References	<DAdXX-2PT-1@gated-at.bofh.it>
X-Original-To	debian-python@lists.debian.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Fri Dec 31 12:03:08 2021
Old-Return-Path	<jcfp@debian.org>
X-Amavis-Spam-Status	No, score=-10.998 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, GMAIL=1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -3.5
X-Greylist	delayed 668 seconds by postgrey-1.36 at bendel; Fri, 31 Dec 2021 12:02:55 UTC
X-Kpn-Messageid	de1d78cc-6a2f-11ec-8a6e-005056ab378f
X-Originating-IP	82.169.215.164
X-Mailer	Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="Sig_/RCOv6.=PxMp8Z=gI=Bf3vds"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/19647
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20211231125124.13e4f73d@vip.jcf.pm
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Fri, 31 Dec 2021 12:51:24 +0100
X-Original-Message-ID	<20211231125124.13e4f73d@vip.jcf.pm>
X-Original-References	<CAGfF1495H0KxLumHzLT1zmdrjkSJZByw+uzpuh6UYamVg38UoQ@mail.gmail.com>
Xref	csiph.com linux.debian.maint.python:13834

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, 30 Dec 2021 14:27:09 -1000
Chiara Marmo <marmochiaskl@gmail.com> wrote:

> Dear list, Sandro,
> 
> I have uploaded on salsa a new upstream version of
> sphinxext-opengraph:
> https://salsa.debian.org/python-team/packages/sphinxext-opengraph/
> 
> I have also modified the way how tests are run... but I'm still in
> the process of understanding how autopkgtests works ....

Enabling the CI on salsa for your package can be really helpful to
verify things work as expected. As an added benefit, it also lowers
the time and effort needed to review a package.

Anyway, the current autopkgtest has a number of obvious flaws:
* the binary package it's trying to test isn't actually installed at
  all because it's not listed as a test dependency;
* the same goes for the supported python versions the test loops over
  (i.e. the necessary dependency on python3-all is missing).
* on the other hand, dependencies of the package being tested (such
  as python3-sphinx) should not be duplicated as a test dependency;
* within the control file, the field identifying tests in a separate
  file is called 'Tests', not 'Test-Command'.

Thread

sphinxext-opengraph new upstream version and tests Chiara Marmo <marmochiaskl@gmail.com> - 2021-12-31 01:30 +0100
  Re: sphinxext-opengraph new upstream version and tests Jeroen Ploemen <jcfp@debian.org> - 2021-12-31 13:10 +0100
    Re: sphinxext-opengraph new upstream version and tests Chiara Marmo <marmochiaskl@gmail.com> - 2022-01-01 04:30 +0100
      Re: sphinxext-opengraph new upstream version and tests Jeroen Ploemen <jcfp@debian.org> - 2022-01-02 13:00 +0100
        Re: sphinxext-opengraph new upstream version and tests Chiara Marmo <marmochiaskl@gmail.com> - 2022-01-03 02:30 +0100
          Re: sphinxext-opengraph new upstream version and tests Jeroen Ploemen <jcfp@debian.org> - 2022-01-03 11:00 +0100
            sphinxext-opengraph new upstream version and tests Chiara Marmo <marmochiaskl@gmail.com> - 2022-01-03 20:20 +0100

csiph-web