Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #65626 > unrolled thread

Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.

Back to article view | Back to linux.debian.kernel

Contents

  Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume. Glenn Washburn <development@efficientek.com> - 2019-11-15 08:50 +0100
    Processed: Re: Bug#944777: initramfs-tools-core: Resume fails  when UUID= syntax used in conf.d/resume. "Debian Bug Tracking System" <owner@bugs.debian.org> - 2019-11-15 23:30 +0100
    Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume. Ben Hutchings <ben@decadent.org.uk> - 2019-11-15 23:30 +0100
      Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume. Glenn Washburn <development@efficientek.com> - 2019-11-26 09:30 +0100
    Bug#944777: marked as done (initramfs-tools-core: Resume fails  when UUID= syntax used in conf.d/resume.) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-01-18 17:00 +0100

#65626 — Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.

[Multipart message — attachments visible in raw view] — view raw

Package: initramfs-tools-core
Version: 0.130ubuntu3.9
Severity: normal
Tags: newcomer

Dear Maintainer,

Resume from hibernation will fail when /etc/initramfs-tools/conf.d/resume
contains "RESUME=UUID=<UUID of hibernation image>".  According to NEWS this
should work.  The reason is does not is because UUID= processing is only done
for the resume kernel parameter (see init lines 123-128). No processing is done
for the RESUME shell variable included from conf.d. Recognizing that
conf.d/resume is being sourced as a script in init, I've created a hack to fix
by adding the processing in the resume file. My resume file looks like this:

"""
RESUME=UUID=deadbeef-cafe-dead-beef-cafedeadbeef

case $RESUME in
    UUID=*)
        RESUME="/dev/disk/by-uuid/${RESUME#UUID=}"
esac
"""

Incidentally, I believe this is the issue in #872664. I chose to create a new
bug because that one is unnecessarily specific.  The bug applies to all versions
on all platforms.

I suggest that the case be moved out of the resume= kernel param handling and
added just after line 206, before the "resume" variable is set. Actually, I see
no reason to use the RESUME variable aside from the fact that its what you're
supposed to use in the conf.d/resume file.  But its confusing and inconsistent
to provide "resume=UUID=" as the kernel parameter and "RESUME=UUID=" in the
conf.d/resume file.

Attached is a patch exemplifying my proposed changes (not tested). The patch
should allow for documentation to notify about the depreciation of RESUME= in
conf.d/resume and to start using resume= instead, but to continue being
backwards compatible with the old syntax. The hooks scripts would need to be
updated to account for the new variable (pretty trivial change, something like
"RESUME=${RESUME:-$resume}").

Glenn

[toc] | [next] | [standalone]

#65630 — Processed: Re: Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.

Processing control commands:

> tag -1 moreinfo
Bug #944777 [initramfs-tools-core] initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.
Added tag(s) moreinfo.

-- 
944777: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944777
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#65632

[Multipart message — attachments visible in raw view] — view raw

Control: tag -1 moreinfo

On Fri, 2019-11-15 at 01:30 -0600, Glenn Washburn wrote:
> Package: initramfs-tools-core
> Version: 0.130ubuntu3.9

This is an Ubuntu version, so maybe you should report this on
Launchpad.

> Severity: normal
> Tags: newcomer
> 
> Dear Maintainer,
> 
> Resume from hibernation will fail when /etc/initramfs-tools/conf.d/resume
> contains "RESUME=UUID=<UUID of hibernation image>".

*Does* it fail, in practice?

> According to NEWS this
> should work.  The reason is does not is because UUID= processing is only done
> for the resume kernel parameter (see init lines 123-128). No processing is done
> for the RESUME shell variable included from conf.d.
[...]

Whether the resume device is specified by a configuration file or from
a kernel parameter, scripts/local-premount/resume will pass it to the
local_device_setup function and that will pass it to resolve_device
which processes all the "key=value" formats.

The early conversion of "UUID=" for the resume kernel parameter
shouldn't be needed at all any more.

Ben.

-- 
Ben Hutchings
It is impossible to make anything foolproof
because fools are so ingenious.

[toc] | [prev] | [next] | [standalone]

#65723

On Fri, 15 Nov 2019 22:20:53 +0000
Ben Hutchings <ben@decadent.org.uk> wrote:

> Control: tag -1 moreinfo
> 
> On Fri, 2019-11-15 at 01:30 -0600, Glenn Washburn wrote:
> > Package: initramfs-tools-core
> > Version: 0.130ubuntu3.9
> 
> This is an Ubuntu version, so maybe you should report this on
> Launchpad.

After further investigation, you're right its an ubuntu issue.  I've
reported it there.  I had thought the issue was in init where I pointed
to and since the code was the same between debian and ubuntu, I thought
debian would have the issue as well.  Now, I understand that the issue
is actually in scripts/local-premount/resume, which differs where the
bug is.

> > Severity: normal
> > Tags: newcomer
> > 
> > Dear Maintainer,
> > 
> > Resume from hibernation will fail when
> > /etc/initramfs-tools/conf.d/resume contains "RESUME=UUID=<UUID of
> > hibernation image>".
> 
> *Does* it fail, in practice?

I'm not sure and suspect it probably works in debian now that I
understand the bug better.

> > According to NEWS this
> > should work.  The reason is does not is because UUID= processing is
> > only done for the resume kernel parameter (see init lines 123-128).
> > No processing is done for the RESUME shell variable included from
> > conf.d.
> [...]
> 
> Whether the resume device is specified by a configuration file or from
> a kernel parameter, scripts/local-premount/resume will pass it to the
> local_device_setup function and that will pass it to resolve_device
> which processes all the "key=value" formats.
> 
> The early conversion of "UUID=" for the resume kernel parameter
> shouldn't be needed at all any more.

For the sake of clarity, I'd suggest removing the early conversion.  At
a minimum the conf.d/resume parameter should be treated the same as the
kernel parameter.

> Ben.
> 

[toc] | [prev] | [next] | [standalone]

#66121 — Bug#944777: marked as done (initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Sat, 18 Jan 2020 15:51:58 +0000
with message-id <a76af46c41881357cee3b45278fe9fd5d5c92e21.camel@decadent.org.uk>
and subject line Re: Bug#944777: initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.
has caused the Debian Bug report #944777,
regarding initramfs-tools-core: Resume fails when UUID= syntax used in conf.d/resume.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
944777: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944777
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web