Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #64418 > unrolled thread

Bug#908712: linux-image-4.17.0-0.bpo.3-marvell: stretch-backports kernel 4.17 breaks QNAP TS-209

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#908712: linux-image-4.17.0-0.bpo.3-marvell: stretch-backports kernel 4.17 breaks QNAP TS-209 "Marco Genise" <marco@genise.de> - 2019-07-10 17:10 +0200
    Bug#908712: linux-image-4.17.0-0.bpo.3-marvell: stretch-backports kernel 4.17 breaks QNAP TS-209 Stefan Langanke <stefan@langanke-online.de> - 2019-07-29 20:10 +0200

#64418 — Bug#908712: linux-image-4.17.0-0.bpo.3-marvell: stretch-backports kernel 4.17 breaks QNAP TS-209

I just tested experimental, same issue there with 
linux-image-5.0.0-trunk-marvell (5.0.2-1~exp1).

After digging around I assume this problem is related to changes in 
drivers/net/ethernet/marvell/mvmdio.c in Version 4.12, which extended 
the number of possible clock sources, see [1].

Just a couple of days ago there was a "fix" posted in [2], which checks 
the array introduced above, before accessing it.

[1] 
https://github.com/torvalds/linux/commit/96cb4342382290c935d933a08feb57d6d0183071#diff-9f818fed5204c3b34d954ad48e607789
[2] https://www.spinics.net/lists/netdev/msg584257.html

[toc] | [next] | [standalone]

#64608

Hello,
the links in Marco's email are leading to the right changes in upstream 
kernel that lead to the problem.

I have the same issue debugged this on my TS-109. The so called fix at 
[1] does not do the trick. There is an uncaught NULL pointer exception, 
that seems to be thrown, if the device does not provide a valid clk.

The function of_clk_get(pdev->dev.of_node, i) does not respond very well 
to pdev->dev.of_node beeing NULL.
I fixed the issue on my device by adding a NULL check right before the 
for-loop.

I am going to adress this issue and my solution to the kernel 
maintainers to fix it there.

Cheers

Stefan

On Wed, 10 Jul 2019 15:05:20 +0000 "Marco Genise" <marco@genise.de> wrote:

 > I just tested experimental, same issue there with
 > linux-image-5.0.0-trunk-marvell (5.0.2-1~exp1).
 >
 > After digging around I assume this problem is related to changes in
 > drivers/net/ethernet/marvell/mvmdio.c in Version 4.12, which extended
 > the number of possible clock sources, see [1].
 >
 > Just a couple of days ago there was a "fix" posted in [2], which checks
 > the array introduced above, before accessing it.
 >
 > [1]
 > 
https://github.com/torvalds/linux/commit/96cb4342382290c935d933a08feb57d6d0183071#diff-9f818fed5204c3b34d954ad48e607789
 > [2] https://www.spinics.net/lists/netdev/msg584257.html
 >
 >
 >

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web