Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #63257 > unrolled thread

Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1

Started byDragan Milenkovic <dragan.milenkovic@pantelija.rs>
First post2019-02-05 02:00 +0100
Last post2019-03-06 12:20 +0100
Articles 8 — 4 participants

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Dragan Milenkovic <dragan.milenkovic@pantelija.rs> - 2019-02-05 02:00 +0100
    Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Cesare Leonardi <celeonar@gmail.com> - 2019-02-12 00:10 +0100
      Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Dragan Milenkovic <dragan.milenkovic@pantelija.rs> - 2019-02-13 18:30 +0100
        Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Thorsten Glaser <t.glaser@tarent.de> - 2019-02-26 20:50 +0100
        Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64:  Hangs on lvm raid1 martin <martin@luminoussheep.net> - 2019-02-27 00:20 +0100
        Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Dragan Milenkovic <dragan.milenkovic@pantelija.rs> - 2019-02-27 01:20 +0100
          Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Cesare Leonardi <celeonar@gmail.com> - 2019-02-28 23:40 +0100
            Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1 Thorsten Glaser <t.glaser@tarent.de> - 2019-03-06 12:20 +0100

#63257 — Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1

FromDragan Milenkovic <dragan.milenkovic@pantelija.rs>
Date2019-02-05 02:00 +0100
SubjectBug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1
Message-ID<xnXfH-8j0-1@gated-at.bofh.it>
I have tracked the issue to this change:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/diff/block/blk-flush.c?id=344e9ffcbd1898e1dc04085564a6e05c30ea8199

The commit log message makes it seem that it is a refactoring change, 
but it inverts the sign on q->elevator test. It should have been 
documented as a bug fix and backported to stable branches.
The line was not further modified in the "master" branch.

I have rebuilt 4.19 from Debian testing with this change, and my system 
now works correctly.

In my opinion, it also relates to #913138 and maybe #904822.

Dragan

[toc] | [next] | [standalone]

#63327

FromCesare Leonardi <celeonar@gmail.com>
Date2019-02-12 00:10 +0100
Message-ID<xqsS6-52f-5@gated-at.bofh.it>
In reply to#63257
On Tue, 5 Feb 2019 01:36:08 +0100 Dragan Milenkovic 
<dragan.milenkovic@pantelija.rs> wrote:
> I have tracked the issue to this change:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/diff/block/blk-flush.c?id=344e9ffcbd1898e1dc04085564a6e05c30ea8199

Thank you very much for your deep analisys and thank you also for 
reporting it upstream on linux-kernel mailing list:
https://marc.info/?l=linux-kernel&m=154945762114390&w=2

It still has no reply but I really hope someone will backport your fix soon.

Cesare.

[toc] | [prev] | [next] | [standalone]

#63360

FromDragan Milenkovic <dragan.milenkovic@pantelija.rs>
Date2019-02-13 18:30 +0100
Message-ID<xr6w9-3Sp-5@gated-at.bofh.it>
In reply to#63327
On Tue, 12 Feb 2019 00:04:15 +0100 Cesare Leonardi <celeonar@gmail.com> 
wrote:
> It still has no reply but I really hope someone will backport your fix soon.

Jens Axboe has determined that the proper fix is quite different:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=85bd6e61f34dffa8ec2dc75ff3c02ee7b2f1cbce

This patch is already on its way to stable branches. I have tested it 
and confirmed that it resolves the problem.

(The line I originally found seems to actually be a mistake introduced 
in the master branch, but it somehow also prevents the deadlock).

Dragan

[toc] | [prev] | [next] | [standalone]

#63449

FromThorsten Glaser <t.glaser@tarent.de>
Date2019-02-26 20:50 +0100
Message-ID<xvQTM-3nm-7@gated-at.bofh.it>
In reply to#63360
severity 913119 serious
found 913119 4.19.16-1
thanks

On Wed, 13 Feb 2019, Dragan Milenkovic wrote:

> Jens Axboe has determined that the proper fix is quite different:
> 
> http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=85bd6e61f34dffa8ec2dc75ff3c02ee7b2f1cbce
> 
> This patch is already on its way to stable branches. I have tested it and
> confirmed that it resolves the problem.

I haven’t, but I’ve just run into this in a very uncomfortable
situation: I’ve just upgraded several virtualisation hosts from
jessie or stretch to buster, and one of them just started to
hang with exactly this problem. (They are all set up as LVM on
RAID, too, no cryptsetup.)

Ben et al. please do consider the fix for buster, otherwise
it’ll be unusable for this kind of setup.

Thanks,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

*************************************************

**!!! NEU !!!** Mit der **tarent Academy** bieten wir ab sofort auch Trainings
und Schulungen in den Bereichen Softwareentwicklung, Agiles Arbeiten und
Zukunftstechnologien an. Besuchen Sie uns
auf [www.tarent.de/academy](http://www.tarent.de/academy). Wir freuen uns auf
Ihren Kontakt.

*************************************************

[toc] | [prev] | [next] | [standalone]

#63453 — Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1

Frommartin <martin@luminoussheep.net>
Date2019-02-27 00:20 +0100
SubjectBug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1
Message-ID<xvUaZ-5C7-1@gated-at.bofh.it>
In reply to#63360
On 2019-02-26 21:11, Cesare Leonardi wrote:
> On 13/02/19 18:21, Dragan Milenkovic wrote:
>> This patch is already on its way to stable branches. I have tested it 
>> and confirmed that it resolves the problem.
> 
> Hello Dragan, do you know if the patch was eventually included
> upstream and possibly in which version?

Looking at the change log it's in here:
https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.19.24

towards the bottom search for "blk-mq: fix a hung issue when fsync"

Regards
M

[toc] | [prev] | [next] | [standalone]

#63454 — Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1

FromDragan Milenkovic <dragan.milenkovic@pantelija.rs>
Date2019-02-27 01:20 +0100
SubjectBug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1
Message-ID<xvV73-6bw-3@gated-at.bofh.it>
In reply to#63360
On 2/26/19 10:11 PM, Cesare Leonardi wrote:
> Hello Dragan, do you know if the patch was eventually included upstream 
> and possibly in which version?

Hello, Cesare. It was included in 4.20.11 and 4.19.24.

Dragan

[toc] | [prev] | [next] | [standalone]

#63470 — Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1

FromCesare Leonardi <celeonar@gmail.com>
Date2019-02-28 23:40 +0100
SubjectBug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1
Message-ID<xwCvn-1PI-1@gated-at.bofh.it>
In reply to#63454
On 28/02/19 16:44, Thorsten Glaser wrote:
> please do consider uploading 4.19.24 to buster/sid with some haste.
> We have headless virtualisation hosts being unreachable/frozen now,
> and while these are “only” development systems, this is untenable.

Like you I'm looking forward for that kernel.
But, in the meantime, doesn't the workaround of disabling blk_mq work 
for you? See comment #15 and #20.
I used it for months without any problem.

Cesare.

[toc] | [prev] | [next] | [standalone]

#63506 — Bug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1

FromThorsten Glaser <t.glaser@tarent.de>
Date2019-03-06 12:20 +0100
SubjectBug#913119: Bug#913138: Bug#913119: linux-image-4.18.0-2-amd64: Hangs on lvm raid1
Message-ID<xyCKB-3Iz-1@gated-at.bofh.it>
In reply to#63470
Hi Cesare,

> But, in the meantime, doesn't the workaround of disabling blk_mq work
> for you?

I don’t know, because I have no means to trigger the bug. The three
other virtualisators I’ve upgraded at the same time did not trigger it.
My desktop machine also hits it only occasionally.

I’ve rebooted all four of them with the two kernel options, in the hopes
of staving off the bug, but in grub.cfg only, so they go away when the
fixed kernel will arrive.

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

*************************************************

**!!! NEU !!!** Mit der **tarent Academy** bieten wir ab sofort auch Trainings
und Schulungen in den Bereichen Softwareentwicklung, Agiles Arbeiten und
Zukunftstechnologien an. Besuchen Sie uns
auf [www.tarent.de/academy](http://www.tarent.de/academy). Wir freuen uns auf
Ihren Kontakt.

*************************************************

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web