Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #63715 > unrolled thread

Bug#925943: nfs-common: nfsiostat crashes due to using reserved word 'list' as variable name

Back to article view | Back to linux.debian.kernel

Contents

  Bug#925943: nfs-common: nfsiostat crashes due to using reserved word 'list' as variable name Matthew Ruffell <matthew.ruffell@canonical.com> - 2019-03-29 00:00 +0100
    Bug#925943: marked as done (nfs-common: nfsiostat crashes due to  using reserved word 'list' as variable name) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-03-13 15:00 +0100

#63715 — Bug#925943: nfs-common: nfsiostat crashes due to using reserved word 'list' as variable name

[Multipart message — attachments visible in raw view] — view raw

Package: nfs-utils
Version: 1:1.3.4-2.3
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch

Dear Maintainer,

nfsiostat, in nfs-common-1.3.4-2, is broken in bionic, cosmic and disco.

When you run the command nfsiostat, either as root or a regular user, the following traceback is printed:

$ nfsiostat
Traceback (most recent call last):
  File "/usr/sbin/nfsiostat", line 640, in <module>
    iostat_command(prog)
  File "/usr/sbin/nfsiostat", line 593, in iostat_command
    devices = list_nfs_mounts(origdevices, mountstats)
  File "/usr/sbin/nfsiostat", line 495, in list_nfs_mounts
    for device, descr in list(mountstats.items()):
TypeError: 'list' object is not callable

This is caused by the 'list' reserved word being used as a variable name in list_nfs_mounts(), 
and is explained here: https://askubuntu.com/questions/1123319/nfsiostat-failing-on-18-04/1123336#1123336?s=a1e9150fbf284e849efe6fe084e7c7b8

I have sent a patch upstream to fix this, and it was commited in:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=c4c14011b70375050d7bba7c57e2eaf4c715dc7c

In Ubuntu, the attached patch was applied to achieve the following:

  * nfsiostat-replace-list-reserved-word.patch: fix nfsiostat crash due to
    using 'list' as a variable name. (LP: #1821261)

Please land this patch in debian to aid with the SRU process.

Thanks for considering the patch.

-- System Information:
Debian Release: buster/sid
  APT prefers cosmic-updates
  APT policy: (500, 'cosmic-updates'), (500, 'cosmic-security'), (500, 'cosmic'), (100, 'cosmic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-16-generic (SMP w/4 CPU cores)
Locale: LANG=en_NZ.UTF-8, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[toc] | [next] | [standalone]

#66535 — Bug#925943: marked as done (nfs-common: nfsiostat crashes due to using reserved word 'list' as variable name)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Fri, 13 Mar 2020 13:51:41 +0000
with message-id <E1jCkiz-000Czt-Bg@fasolo.debian.org>
and subject line Bug#925943: fixed in nfs-utils 1:1.3.4-3
has caused the Debian Bug report #925943,
regarding nfs-common: nfsiostat crashes due to using reserved word 'list' as variable name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
925943: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925943
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web