Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #60643 > unrolled thread

Bug#895131: linux-perf-4.16: Add libopencsd support to perf

Back to article view | Back to linux.debian.kernel

Contents

  Bug#895131: linux-perf-4.16: Add libopencsd support to perf Wookey <wookey@debian.org> - 2018-04-07 14:10 +0200
    Bug#895131: Acknowledgement (linux-perf-4.16: Add libopencsd support to perf) Wookey <wookey@wookware.org> - 2018-04-09 19:40 +0200
    Bug#895131: Acknowledgement (linux-perf-4.16: Add libopencsd support to perf) Wookey <wookey@wookware.org> - 2018-06-14 00:00 +0200
    Bug#895131: Info received (Bug#895131: Acknowledgement (linux-perf-4.18: Add libopencsd support to perf)) Wookey <wookey@wookware.org> - 2018-10-22 03:50 +0200
    Bug#895131: (linux-perf-4.16: Add libopencsd support to perf) Wookey <wookey@wookware.org> - 2019-02-08 05:10 +0100
      Bug#895131: (linux-perf-4.16: Add libopencsd support to perf) Ben Hutchings <ben@decadent.org.uk> - 2019-02-09 00:40 +0100
    Bug#895131: linux-perf: Add libopencsd support to perf John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - 2019-03-13 05:20 +0100
      Bug#895131: linux-perf: Add libopencsd support to perf Ben Hutchings <ben@decadent.org.uk> - 2019-03-13 12:20 +0100
    Processed: Re: Bug#895131: linux-perf: Add libopencsd support to perf "Debian Bug Tracking System" <owner@bugs.debian.org> - 2019-03-13 12:20 +0100

#60643 — Bug#895131: linux-perf-4.16: Add libopencsd support to perf

[Multipart message — attachments visible in raw view] — view raw

Package: linux-perf-4.16
Version: 4.16~rc6-1~exp1
Severity: wishlist
Tags: patch

In kernel 4.16 perf has support for libopencsd, which decodes arm
coresight trace packets.  This should be enabled in debian kernels so
that it 'just works' for users.  perf compilation picks up libopencsd
if it installed so enabling it is simply a matter of adding it to the
build-dependencies so that it is available at build time.

Attached is a patch that does this.

However note that, whilst libopencsd is now packaged for debian it has
not yet been uploaded to the archive (one build issue remains to be
fixed before it can be uploaded), and clearly this build-dep can't be
added until the library is actually available. So this bug is blocked
on #891955

[toc] | [next] | [standalone]

#60660 — Bug#895131: Acknowledgement (linux-perf-4.16: Add libopencsd support to perf)

[Multipart message — attachments visible in raw view] — view raw

On 2018-04-07 12:06 +0000, Debian Bug Tracking System wrote:
libopencsd is now in the NEW queue. I'm not sure if you'll get a
noticfication when the ITP bug closure unblocks this one so I'll
comment again here when that happens.

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/

[toc] | [prev] | [next] | [standalone]

#61201 — Bug#895131: Acknowledgement (linux-perf-4.16: Add libopencsd support to perf)

On 2018-04-07 12:06 +0000, Debian Bug Tracking System wrote:
> libopencsd is now in the NEW queue. I'm not sure if you'll get a
> noticfication when the ITP bug closure unblocks this one so I'll
> comment again here when that happens.

OK. libopencsd is now in the archive, so this patch to allow the perf
build to use it can now be applied.

Thanks

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/

[toc] | [prev] | [next] | [standalone]

#62407 — Bug#895131: Info received (Bug#895131: Acknowledgement (linux-perf-4.18: Add libopencsd support to perf))

[Multipart message — attachments visible in raw view] — view raw

On 2018-06-13 21:57 +0000, Debian Bug Tracking System wrote:

This has not been fixed in latest kernel release. Updating patch to
current source tree (4.18.10-2). libopencsd has been available in
testing for 4 months now. Can we please enable it in the shipped perf?

the patch is a one-liner:

--- linux-4.18.10/debian/templates/control.source.in	2018-09-13 10:34:49.000000000 +0000
+++ linux-4.18.10/debian/templates/control.source.in	2018-10-22 01:14:26.000000000 +0000
@@ -45,6 +45,7 @@
  libnuma-dev [amd64 arm64 hppa i386 mips mips64 mips64el mipsel mipsn32 mipsn32el mipsr6 mipsr6el mipsn32r6 mipsn32r6el mips64r6 mips64r6el powerpc powerpcspe ppc64 ppc64el sparc x32] <!stage1 !pkg.linux.notools !nopython>,
  libperl-dev <!stage1 !pkg.linux.notools !nopython>,
  libunwind8-dev [amd64 armel armhf arm64 i386] <!stage1 !pkg.linux.notools !nopython>,
+ libopencsd-dev <!stage1 !pkg.linux.notools !nopython>,
  python3-dev <!stage1 !pkg.linux.notools !nopython>,
 # used by upstream to build usbip
  autoconf <!stage1 !pkg.linux.notools>,

thanks.

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/

[toc] | [prev] | [next] | [standalone]

#63287 — Bug#895131: (linux-perf-4.16: Add libopencsd support to perf)

[Multipart message — attachments visible in raw view] — view raw

On 2018-06-13 21:57 +0000, Debian Bug Tracking System wrote:

Just noticed this was blocked by the wrong ITP bug (horizon-EDA, not libopencsd).
That may explain why it's been ignored so long. Apologies for the confusion there.

The one-line packaging fix is still missing from the 4.19 that was
uploaded recently. ARM still really want to see libopencsd enabled in
perf built on arm/arm64 and the fix is utterly trivial, so please can
someone apply it.

I'll do a clean patch for 4.19.

Hmm. Looks like there has been a revamp of the templates for
tools. Now the extra build-dep needs to go in
debian/templates/control.tools-versioned.in now.  For some reason all
these build-deps seem to have lost their build-profile info (except
for asciidoc). I don't understand why that would be so. We don't want those
extra build-deps in stage1?

Perhaps there is some overriding mechanism to get this right? I've
left out the profile info to match the rest of the file, but it feels
unlikely to be correct.

Patch attached.

Ben suggested that I do a pull request to help make this happen. I'll do that next.

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/

[toc] | [prev] | [next] | [standalone]

#63291 — Bug#895131: (linux-perf-4.16: Add libopencsd support to perf)

[Multipart message — attachments visible in raw view] — view raw

On Fri, 8 Feb 2019 04:04:13 +0000 Wookey <wookey@wookware.org> wrote:
[...]
> Hmm. Looks like there has been a revamp of the templates for
> tools. Now the extra build-dep needs to go in
> debian/templates/control.tools-versioned.in now.  For some reason all
> these build-deps seem to have lost their build-profile info (except
> for asciidoc). I don't understand why that would be so. We don't want those
> extra build-deps in stage1?
[...]

The single list of Build-Depends was getting hard to manage.  So I
changed debian/bin/gencontrol.py to extract Build-Depends from each
binary package template, qualify them with the architectures and build-
profiles specified for that binary package, and append them to Build-
Depends-Arch or -Indep as appropriate.

So in a binary package template you only need to specify architecture
or profile qualifications for a build-dependency if the binary package
should sometimes be built without it.

Ben.

-- 
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky

[toc] | [prev] | [next] | [standalone]

#63573 — Bug#895131: linux-perf: Add libopencsd support to perf

Package: src:linux
Followup-For: Bug #895131
User: debian-sparc@lists.debian.org
Usertags: sparc64

Hello!

This change made src:linux BD-Uninstallable on sparc64 [1] as
the package libopencsd doesn't build there [2].

Since this library is ARM-specific anyway, wouldn't it make
more sense to have this build-dependency on ARM targets only?

Thanks,
Adrian

> [1] https://buildd.debian.org/status/package.php?p=linux&suite=sid
> [2] https://buildd.debian.org/status/package.php?p=libopencsd&suite=sid

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

[toc] | [prev] | [next] | [standalone]

#63580 — Bug#895131: linux-perf: Add libopencsd support to perf

[Multipart message — attachments visible in raw view] — view raw

Control: notforwarded -1

On Wed, 2019-03-13 at 05:01 +0100, John Paul Adrian Glaubitz wrote:
> Package: src:linux
> Followup-For: Bug #895131
> User: debian-sparc@lists.debian.org
> Usertags: sparc64
> 
> Hello!
> 
> This change made src:linux BD-Uninstallable on sparc64 [1] as
> the package libopencsd doesn't build there [2].
> 
> Since this library is ARM-specific anyway, wouldn't it make
> more sense to have this build-dependency on ARM targets only?

Please open a *new* bug for this.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered
an expert.

[toc] | [prev] | [next] | [standalone]

#63579 — Processed: Re: Bug#895131: linux-perf: Add libopencsd support to perf

Processing control commands:

> notforwarded -1
Bug #895131 {Done: Ben Hutchings <ben@decadent.org.uk>} [src:linux] linux-perf: Add libopencsd support to perf
Ignoring request to change the forwarded-to-address of bug#895131 to the same value

-- 
895131: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895131
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web