Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #61361 > unrolled thread

Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst Cyril Brulebois <kibi@debian.org> - 2018-07-08 06:40 +0200
    Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst Ben Hutchings <ben@decadent.org.uk> - 2018-07-09 21:00 +0200
      Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst Cyril Brulebois <kibi@debian.org> - 2018-07-10 02:40 +0200
        Processed: Re: Bug#903122: debian-installer-9-netboot-amd64:  Please add char/virtio_console module (paravirtualized serial) to netinst "Debian Bug Tracking System" <owner@bugs.debian.org> - 2018-07-10 02:40 +0200
        Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst Ben Hutchings <ben@decadent.org.uk> - 2018-07-10 05:30 +0200

#61361 — Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst

[Multipart message — attachments visible in raw view] — view raw

Hi Vincent,

Vincent Caron <vincent@zerodeux.net> (2018-07-06):
> Package: debian-installer-9-netboot-amd64
> Severity: wishlist
> Tags: d-i
> 
> Dear Maintainer,
> 
> while automating Debian image creations thru netinst + KVM, I stumbled
> upon a limitation from the emulated UARTs (if one sends back from the
> guest to the host large logs, it might overrun the UART buffer which
> complains with kernel messages about overused IRQ).
> 
> While turning to paravirtualized serial, I realized that the
> char/virtio_console kernel module is missing in the netinst's initrd,
> and this driver is required very early. Obviously I still use the UART
> emulation for kernel messages since it's the only _very early_ output
> medium, thus emulated UART and paravirtualized serials should be used
> together.

You mention netinst a few times, but you seem to be talking about
netboot really. netinst is an ISO image with a bunch of packages, enough
to configure everything needed to pull the rest of the system from a
network mirror; netboot is kernel+initrd for PXE boots and similar
minimalistic approaches.

> If this module makes it to netinst's initrd, one would use those kvm
> args:
> 
> -chardev file,path=virtiocon0.log,id=virtiocon0
> -device virtio-serial
> -device virtconsole,chardev=virtiocon0
> 
> ... and in the guest a /dev/hvc0 would appear. Anything the guest would
> write to /dev/hv0 would en up in the host's vitriocon0.log file.

So it seems we're talking about kernel/drivers/char/virtio_console.ko
that could be added to either the serial-modules udeb or the
virtio-modules one. Kernel maintainers, what do you think?

This might be worth backporting to stretch too. I can send patches when
you've selected the udeb we should be adding this module to.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[toc] | [next] | [standalone]

#61376

[Multipart message — attachments visible in raw view] — view raw

On Sun, 2018-07-08 at 06:37 +0200, Cyril Brulebois wrote:
[...]
> Vincent Caron <vincent@zerodeux.net> (2018-07-06):
[...]
> > If this module makes it to netinst's initrd, one would use those kvm
> > args:
> > 
> > -chardev file,path=virtiocon0.log,id=virtiocon0
> > -device virtio-serial
> > -device virtconsole,chardev=virtiocon0
> > 
> > ... and in the guest a /dev/hvc0 would appear. Anything the guest would
> > write to /dev/hv0 would en up in the host's vitriocon0.log file.
> 
> So it seems we're talking about kernel/drivers/char/virtio_console.ko
> that could be added to either the serial-modules udeb or the
> virtio-modules one. Kernel maintainers, what do you think?
>
> This might be worth backporting to stretch too. I can send patches when
> you've selected the udeb we should be adding this module to.

I would say virtio-modules.  All the virtio class drivers depend on
virtio and virtio_ring, which means that adding them to any other
package would require that package to depend on virtio-modules.

(The Xen-specific drivers don't have this issue only because xenbus
unfortunately has to be built-in.)

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

[toc] | [prev] | [next] | [standalone]

#61377

[Multipart message — attachments visible in raw view] — view raw

Control: reassign -1 src:linux
Control: tag -1 patch

Ben Hutchings <ben@decadent.org.uk> (2018-07-09):
> I would say virtio-modules.  All the virtio class drivers depend on
> virtio and virtio_ring, which means that adding them to any other
> package would require that package to depend on virtio-modules.
> 
> (The Xen-specific drivers don't have this issue only because xenbus
> unfortunately has to be built-in.)

Alright, I've implemented this in the attached patches, one for sid, and
one for stretch. I didn't run any test builds, but I've verified that
contrary to some other virtio* modules, virtio_console is built
everywhere (CONFIG_VIRTIO_CONSOLE=m in debian/config/config), so should
be added without '?'.

Thanks for considering.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[toc] | [prev] | [next] | [standalone]

#61378 — Processed: Re: Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst

Processing control commands:

> reassign -1 src:linux
Bug #903122 [debian-installer-9-netboot-amd64] debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst
Bug reassigned from package 'debian-installer-9-netboot-amd64' to 'src:linux'.
Ignoring request to alter found versions of bug #903122 to the same values previously set
Ignoring request to alter fixed versions of bug #903122 to the same values previously set
> tag -1 patch
Bug #903122 [src:linux] debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst
Added tag(s) patch.

-- 
903122: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903122
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#61380

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2018-07-10 at 02:32 +0200, Cyril Brulebois wrote:
> Control: reassign -1 src:linux
> Control: tag -1 patch
> 
> Ben Hutchings <ben@decadent.org.uk> (2018-07-09):
> > I would say virtio-modules.  All the virtio class drivers depend on
> > virtio and virtio_ring, which means that adding them to any other
> > package would require that package to depend on virtio-modules.
> > 
> > (The Xen-specific drivers don't have this issue only because xenbus
> > unfortunately has to be built-in.)
> 
> Alright, I've implemented this in the attached patches, one for sid, and
> one for stretch. I didn't run any test builds, but I've verified that
> contrary to some other virtio* modules, virtio_console is built
> everywhere (CONFIG_VIRTIO_CONSOLE=m in debian/config/config), so should
> be added without '?'.

For the kernel-wedge config, it generally doesn't matter whether a
driver might be built-in.  The "copy-modules" sub-command checks in the
"modules.builtin" file before looking for a real module file.  It's
only a problem if all the modules listed for a package are built-in,
because an empty package is treated as an error (maybe that should just
be a warning?).

Ben.

> Thanks for considering.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web