Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #60223 > unrolled thread

Bug#890601: Source Package Doesn't Contain Source

Started by"Jason Self" <jason@bluehome.net>
First post2018-02-16 17:00 +0100
Last post2018-02-16 22:50 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.debian.kernel


Contents

  Bug#890601: Source Package Doesn't Contain Source "Jason Self" <jason@bluehome.net> - 2018-02-16 17:00 +0100
    Bug#890601: firmware-free: Source Package Doesn't Contain Source Jonathan Nieder <jrnieder@gmail.com> - 2018-02-16 19:00 +0100
      Bug#890601: firmware-free: Source Package Doesn't Contain Source "Jason Self" <jason@bluehome.net> - 2018-02-16 22:40 +0100
        Bug#890601: firmware-free: Source Package Doesn't Contain Source Jonathan Nieder <jrnieder@gmail.com> - 2018-02-16 22:50 +0100
          Processed: Re: firmware-free: Source Package Doesn't Contain Source "Debian Bug Tracking System" <owner@bugs.debian.org> - 2018-02-16 22:50 +0100

#60223 — Bug#890601: Source Package Doesn't Contain Source

From"Jason Self" <jason@bluehome.net>
Date2018-02-16 17:00 +0100
SubjectBug#890601: Source Package Doesn't Contain Source
Message-ID<vjQAy-2vs-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Package: firmware-linux-free
Version: 3.4

It appears that the source package for firmware-linux-free contains the 
firmware binaries downloaded from linux-firmware.git. Shouldn't a source 
package contain, you know, the source code? Especially as some of the 
firmwares are GPL-licensed, and Debian is shipping only the binaries.

In looking into other distros it seems that that most don't compile the 
firmware from source either. As a result people don't notice when the tools 
to do so break. For example: The as31 assembler needed to build the usbdux 
firmware currently segfaults. Reference bug #887320.

[toc] | [next] | [standalone]


#60225 — Bug#890601: firmware-free: Source Package Doesn't Contain Source

FromJonathan Nieder <jrnieder@gmail.com>
Date2018-02-16 19:00 +0100
SubjectBug#890601: firmware-free: Source Package Doesn't Contain Source
Message-ID<vjSsF-3Iu-3@gated-at.bofh.it>
In reply to#60223
Hi Jason,

Jason Self wrote:

> It appears that the source package for firmware-linux-free contains the
> firmware binaries downloaded from linux-firmware.git. Shouldn't a source
> package contain, you know, the source code? Especially as some of the
> firmwares are GPL-licensed, and Debian is shipping only the binaries.

Can you be more specific?  Which file have you found in the source
package that does not have corresponding source included?

> In looking into other distros it seems that that most don't compile the
> firmware from source either. As a result people don't notice when the tools
> to do so break. For example: The as31 assembler needed to build the usbdux
> firmware currently segfaults. Reference bug #887320.

That sounds like a different bug report: "package doesn't build from
source".

Thanks and hope that helps,
Jonathan

[toc] | [prev] | [next] | [standalone]


#60226 — Bug#890601: firmware-free: Source Package Doesn't Contain Source

From"Jason Self" <jason@bluehome.net>
Date2018-02-16 22:40 +0100
SubjectBug#890601: firmware-free: Source Package Doesn't Contain Source
Message-ID<vjVTz-61i-5@gated-at.bofh.it>
In reply to#60225

[Multipart message — attachments visible in raw view] — view raw

Jonathan Nieder <jrnieder@gmail.com> wrote ..

> Can you be more specific?  Which file have you found in the source
> package that does not have corresponding source included?

OK; perhaps this bug needs re-titling. There seems to be "a" source 
present, but the programs don't appear to be built from it.

What started this is that I tried to build the usbdux firmware from 
source and found that the assembler needed to build the firmware 
segfaulted when trying to do so. Curious as to how Debian got the 
firmware to build I checked out the firmware-free package. The answer 
seems to be: They didn't; they just use the binaries from linux-
firmware.git. (The sha512 hashes appear to be identical.)

If they were built from source then the build dependencies for firmware-
free would be bigger (such as, among others, depending on as31 in order 
to build the usbdux firmware) and the breakage of tools needed to build 
the firmware would have been noticed.

Surely including auto-generated files and/or just re-cycling upstream's 
binaries in a source package either is or should be some sort of policy 
violation? Building from source would help to ensure that the provided 
source is complete, corresponding, and buildable. It would also be 
consistent with the proposed stuff for JavaScript to exclude auto-
generated files from source.

[toc] | [prev] | [next] | [standalone]


#60227 — Bug#890601: firmware-free: Source Package Doesn't Contain Source

FromJonathan Nieder <jrnieder@gmail.com>
Date2018-02-16 22:50 +0100
SubjectBug#890601: firmware-free: Source Package Doesn't Contain Source
Message-ID<vjW3f-64z-3@gated-at.bofh.it>
In reply to#60226
retitle 890601 firmware-linux-free uses prebuilt blobs instead of building from source
severity 890601 wishlist
quit

Jason Self wrote:
> Jonathan Nieder <jrnieder@gmail.com> wrote ..

>> Can you be more specific?  Which file have you found in the source
>> package that does not have corresponding source included?
>
> OK; perhaps this bug needs re-titling. There seems to be "a" source 
> present, but the programs don't appear to be built from it.

Thanks for clarifying.

I agree that fixing that is a worthwhile project, though it's hard to
do (e.g. because of the current state of cross-compilers in the
archive).  Retitling and setting severity based on my understanding of
kernel team's current plans.

Thanks,
Jonathan

[toc] | [prev] | [next] | [standalone]


#60228 — Processed: Re: firmware-free: Source Package Doesn't Contain Source

From"Debian Bug Tracking System" <owner@bugs.debian.org>
Date2018-02-16 22:50 +0100
SubjectProcessed: Re: firmware-free: Source Package Doesn't Contain Source
Message-ID<vjW3f-64z-1@gated-at.bofh.it>
In reply to#60227
Processing commands for control@bugs.debian.org:

> retitle 890601 firmware-linux-free uses prebuilt blobs instead of building from source
Bug #890601 [firmware-linux-free] Source Package Doesn't Contain Source
Changed Bug title to 'firmware-linux-free uses prebuilt blobs instead of building from source' from 'Source Package Doesn't Contain Source'.
> severity 890601 wishlist
Bug #890601 [firmware-linux-free] firmware-linux-free uses prebuilt blobs instead of building from source
Severity set to 'wishlist' from 'normal'
> quit
Stopping processing here.

Please contact me if you need assistance.
-- 
890601: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890601
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.kernel


csiph-web