Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #60928 > unrolled thread

Bug#898165: linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals

Back to article view | Back to linux.debian.kernel

Contents

  Bug#898165: linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals Moritz Schlarb <schlarbm@uni-mainz.de> - 2018-05-08 11:20 +0200
    Bug#898165: linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals Christoph Martin <martin@uni-mainz.de> - 2018-05-11 15:30 +0200
    Processed: Re: Bug#898165: linux-image-3.16.0-6-amd64: can't  mount NFS shares via nfs referrals "Debian Bug Tracking System" <owner@bugs.debian.org> - 2018-05-14 11:10 +0200
    Bug#898165: linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals Pradeep <pradeepthomas@gmail.com> - 2018-05-14 18:00 +0200
    Bug#898165: marked as forwarded (linux-image-3.16.0-6-amd64:  can't mount NFS shares via nfs referrals) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2018-05-17 10:20 +0200
    Bug#898165: Regression in [v2] nfs: Fix ugly referral attributes ? Chuck Lever <chuck.lever@oracle.com> - 2018-05-17 19:20 +0200
    Bug#898165: Regression in [v2] nfs: Fix ugly referral attributes ? Chuck Lever <chuck.lever@oracle.com> - 2018-05-18 21:10 +0200

#60928 — Bug#898165: linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals

Package: src:linux
Version: 3.16.56-1
Severity: important

Control: fixed -1 linux/4.9.88-1~bpo8+1
Control: fixed -1 linux/4.9.88-1

Hello,

after getting the latest stable security kernel version on one of our
NFS clients, said client can't mount our user home directories via our
NFS referer server anymore.

This problem is only similar to
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850713
but (for us) far more severe, since *this* bug affects home directories.

Our workaround is to install the latest kernel from jessie-backports,
which does not have this problem.

The logs aren't saying anything at the time of login, where the home
should be mounted.

There are only some patches regarding nfs listed in the package
changelog, maybe if you could point us to a specific one, we could try
to bisect it.

Regards,
Moritz

-- Package-specific info:
** Kernel log: boot messages should be attached

** Model information
sys_vendor: Dell Inc.
product_name: OptiPlex 7010
product_version: 01
chassis_vendor: Dell Inc.
chassis_version: 
bios_vendor: Dell Inc.
bios_version: A28
board_vendor: Dell Inc.
board_name: 0GY6Y8
board_version: A03

** PCI devices:
00:00.0 Host bridge [0600]: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor DRAM Controller [8086:0150] (rev 09)
	Subsystem: Dell Device [1028:0577]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR- INTx-
	Latency: 0
	Capabilities: <access denied>
	Kernel driver in use: ivb_uncore

00:02.0 VGA compatible controller [0300]: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor Graphics Controller [8086:0162] (rev 09) (prog-if 00 [VGA controller])
	Subsystem: Dell Device [1028:0577]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin A routed to IRQ 31
	Region 0: Memory at f7800000 (64-bit, non-prefetchable) [size=4M]
	Region 2: Memory at e0000000 (64-bit, prefetchable) [size=256M]
	Region 4: I/O ports at f000 [size=64]
	[virtual] Expansion ROM at 000c0000 [disabled] [size=128K]
	Capabilities: <access denied>
	Kernel driver in use: i915

00:14.0 USB controller [0c03]: Intel Corporation 7 Series/C210 Series Chipset Family USB xHCI Host Controller [8086:1e31] (rev 04) (prog-if 30 [XHCI])
	Subsystem: Dell Device [1028:0577]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin A routed to IRQ 27
	Region 0: Memory at f7c20000 (64-bit, non-prefetchable) [size=64K]
	Capabilities: <access denied>
	Kernel driver in use: xhci_hcd

00:16.0 Communication controller [0780]: Intel Corporation 7 Series/C210 Series Chipset Family MEI Controller #1 [8086:1e3a] (rev 04)
	Subsystem: Dell Device [1028:0577]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin A routed to IRQ 29
	Region 0: Memory at f7c3c000 (64-bit, non-prefetchable) [size=16]
	Capabilities: <access denied>
	Kernel driver in use: mei_me

00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04)
	Subsystem: Dell Device [1028:052c]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin A routed to IRQ 26
	Region 0: Memory at f7c00000 (32-bit, non-prefetchable) [size=128K]
	Region 1: Memory at f7c39000 (32-bit, non-prefetchable) [size=4K]
	Region 2: I/O ports at f080 [size=32]
	Capabilities: <access denied>
	Kernel driver in use: e1000e

00:1a.0 USB controller [0c03]: Intel Corporation 7 Series/C210 Series Chipset Family USB Enhanced Host Controller #2 [8086:1e2d] (rev 04) (prog-if 20 [EHCI])
	Subsystem: Dell Device [1028:0577]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin A routed to IRQ 16
	Region 0: Memory at f7c38000 (32-bit, non-prefetchable) [size=1K]
	Capabilities: <access denied>
	Kernel driver in use: ehci-pci

00:1b.0 Audio device [0403]: Intel Corporation 7 Series/C210 Series Chipset Family High Definition Audio Controller [8086:1e20] (rev 04)
	Subsystem: Dell Device [1028:0577]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 64 bytes
	Interrupt: pin A routed to IRQ 30
	Region 0: Memory at f7c30000 (64-bit, non-prefetchable) [size=16K]
	Capabilities: <access denied>
	Kernel driver in use: snd_hda_intel

00:1d.0 USB controller [0c03]: Intel Corporation 7 Series/C210 Series Chipset Family USB Enhanced Host Controller #1 [8086:1e26] (rev 04) (prog-if 20 [EHCI])
	Subsystem: Dell Device [1028:0577]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin A routed to IRQ 23
	Region 0: Memory at f7c37000 (32-bit, non-prefetchable) [size=1K]
	Capabilities: <access denied>
	Kernel driver in use: ehci-pci

00:1e.0 PCI bridge [0604]: Intel Corporation 82801 PCI Bridge [8086:244e] (rev a4) (prog-if 01 [Subtractive decode])
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Bus: primary=00, secondary=01, subordinate=01, sec-latency=32
	Secondary status: 66MHz- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
	BridgeCtl: Parity- SERR- NoISA- VGA- MAbort- >Reset- FastB2B-
		PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
	Capabilities: <access denied>

00:1f.0 ISA bridge [0601]: Intel Corporation Q77 Express Chipset LPC Controller [8086:1e47] (rev 04)
	Subsystem: Dell Device [1028:0577]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Capabilities: <access denied>
	Kernel driver in use: lpc_ich

00:1f.2 SATA controller [0106]: Intel Corporation 7 Series/C210 Series Chipset Family 6-port SATA Controller [AHCI mode] [8086:1e02] (rev 04) (prog-if 01 [AHCI 1.0])
	Subsystem: Dell Device [1028:0577]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0
	Interrupt: pin B routed to IRQ 28
	Region 0: I/O ports at f0d0 [size=8]
	Region 1: I/O ports at f0c0 [size=4]
	Region 2: I/O ports at f0b0 [size=8]
	Region 3: I/O ports at f0a0 [size=4]
	Region 4: I/O ports at f060 [size=32]
	Region 5: Memory at f7c36000 (32-bit, non-prefetchable) [size=2K]
	Capabilities: <access denied>
	Kernel driver in use: ahci

00:1f.3 SMBus [0c05]: Intel Corporation 7 Series/C210 Series Chipset Family SMBus Controller [8086:1e22] (rev 04)
	Subsystem: Dell Device [1028:0577]
	Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Interrupt: pin C routed to IRQ 18
	Region 0: Memory at f7c35000 (64-bit, non-prefetchable) [size=256]
	Region 4: I/O ports at f040 [size=32]
	Kernel driver in use: i801_smbus


** USB devices:
Bus 002 Device 005: ID 046d:c069 Logitech, Inc. M500 Laser Mouse
Bus 002 Device 004: ID 0bf8:101e Fujitsu Siemens Computers 
Bus 002 Device 003: ID 0424:2514 Standard Microsystems Corp. USB 2.0 Hub
Bus 002 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub


-- System Information:
Debian Release: 8.10
  APT prefers oldstable-updates
  APT policy: (700, 'oldstable-updates'), (700, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-0.bpo.6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages linux-image-3.16.0-6-amd64 depends on:
ii  debconf [debconf-2.0]                   1.5.56+deb8u1
ii  initramfs-tools [linux-initramfs-tool]  0.120+deb8u3
ii  kmod                                    18-3
ii  linux-base                              4.3~bpo8+1

Versions of packages linux-image-3.16.0-6-amd64 recommends:
ii  firmware-linux-free  3.3
ii  irqbalance           1.0.6-3+deb8u1

Versions of packages linux-image-3.16.0-6-amd64 suggests:
pn  debian-kernel-handbook  <none>
ii  grub-pc                 2.02~beta2-22+deb8u1
pn  linux-doc-3.16          <none>

Versions of packages linux-image-3.16.0-6-amd64 is related to:
pn  firmware-atheros        <none>
pn  firmware-bnx2           <none>
pn  firmware-bnx2x          <none>
pn  firmware-brcm80211      <none>
pn  firmware-intelwimax     <none>
pn  firmware-ipw2x00        <none>
pn  firmware-ivtv           <none>
pn  firmware-iwlwifi        <none>
pn  firmware-libertas       <none>
ii  firmware-linux          0.43
ii  firmware-linux-nonfree  0.43
pn  firmware-myricom        <none>
pn  firmware-netxen         <none>
pn  firmware-qlogic         <none>
pn  firmware-ralink         <none>
pn  firmware-realtek        <none>
pn  xen-hypervisor          <none>

-- debconf information:
  linux-image-3.16.0-6-amd64/postinst/depmod-error-initrd-3.16.0-6-amd64: false
  linux-image-3.16.0-6-amd64/postinst/mips-initrd-3.16.0-6-amd64:
  linux-image-3.16.0-6-amd64/prerm/removing-running-kernel-3.16.0-6-amd64: true

[toc] | [next] | [standalone]

#60974

[Multipart message — attachments visible in raw view] — view raw

Am 11.05.2018 um 14:21 schrieb Moritz Schlarb:

> we tried to get some insight into the issue by wiresharking while trying
> to mount.
> 
> Although the client first receives NFS4ERR_MOVED and then re-queries for
> FS_Locations and receives a correct response for the referred
> fs_location, it just does not continue to mount that given fs_location
> then like it used to.

Furthermore we see no package going out to the referred NFS server.

Christoph

-- 
============================================================================
Christoph Martin, Leiter Unix-Systeme
Zentrum für Datenverarbeitung, Uni-Mainz, Germany
 Anselm Franz von Bentzel-Weg 12, 55128 Mainz
 Telefon: +49(6131)3926337
 Instant-Messaging: Jabber/XMPP: martin@jabber.uni-mainz.de

[toc] | [prev] | [next] | [standalone]

#61011 — Processed: Re: Bug#898165: linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals

Processing control commands:

> tags -1 + patch upstream
Bug #898165 [src:linux] linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals
Added tag(s) patch and upstream.
> notfound -1 linux/3.16.51-3+deb8u1
Bug #898165 [src:linux] linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals
No longer marked as found in versions linux/3.16.51-3+deb8u1.

-- 
898165: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898165
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#61019

[Multipart message — attachments visible in raw view] — view raw

Hi Moritz,

The patch is for NFS client side bug where it was initializing the
attributes to zero if NFS4ERR_MOVED is returned in LOOKUP; but referral was
not followed later. This only happens with NFSv4 server and the specific
error (NFS4ERR_MOVED).

It is not related to nfs-ganesha - it can be reproduced with kernel NFS as
well.

Are you seeing any regressions with the patch?

Thanks,
Pradeep

On Mon, May 14, 2018 at 2:40 AM, Moritz Schlarb <schlarbm@uni-mainz.de>
wrote:

> Hello Frank and Pradeep,
>
> I was hoping that you would have some insight on a possible
> bug/regression/incompability between nfs-ganesha and the Linux kernel
> with a specific patch to which you reacted (see below) in
> https://marc.info/?l=linux-nfs&m=150998968529002&w=2.
>
> There is no mail about the results of Pradeep's checking whether that
> patch is safe for nfs-ganesha on the server side, or whether there were
> additional changes needed. Maybe one of you could shed some light on that.
>
> I've created a tracking Debian bug report for our issue:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898165
>
> Best regards,
> Moritz
>
> On 14.05.2018 11:05, Moritz Schlarb wrote:
> > Control: tags -1 + patch upstream
> > Control: notfound -1 linux/3.16.51-3+deb8u1
> >
> > Hi everyone,
> >
> > I have identified the upstream commit that introduced this
> > bug/regression for us.
> >
> > It is c05cefcc72416a37eba5a2b35f0704ed758a9145 "nfs: Fix ugly referral
> > attributes"
> > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/
> linux.git/commit/?id=c05cefcc72416a37eba5a2b35f0704ed758a9145)
> > which seems to have been part of upstream 3.16.54.
> >
> > I have manually compiled 3.16.56-1+deb8u1 with that patch reversed and I
> > can successfully mount my home directory again.
> >
> > Regards,
> >
>
> --
> Moritz Schlarb
> Unix-Gruppe | Systembetreuung
> Zentrum für Datenverarbeitung
> Johannes Gutenberg-Universität Mainz
> Raum 01-331 - Tel. +49 6131 39-29441
> OpenPGP Fingerprint: DF01 2247 BFC6
> 5501 AFF2 8445 0C24 B841 C7DD BAAF
>

[toc] | [prev] | [next] | [standalone]

#61042 — Bug#898165: marked as forwarded (linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Thu, 17 May 2018 09:53:33 +0200
with message-id <19d4d696-3abc-42cd-28fb-86a24b572ddd@uni-mainz.de>
has caused the   report #898165,
regarding linux-image-3.16.0-6-amd64: can't mount NFS shares via nfs referrals
to be marked as having been forwarded to the upstream software
author(s) <linux-nfs@vger.kernel.org>

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
898165: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898165
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#61047 — Bug#898165: Regression in [v2] nfs: Fix ugly referral attributes ?

> On May 17, 2018, at 3:53 AM, Moritz Schlarb <schlarbm@uni-mainz.de> wrote:
> 
> Hi everyone,
> 
> there might be a regression coming from this patch:
> Since it got included in 3.16.54, our clients running a recent 3.16
> kernel (like from Debian jessie-security) did not follow NFS 4.1
> referrals (issued by nfs-ganesha) anymore.
> I have built that exact Debian kernel package with just this patch
> reversed and it worked again, so I got pretty confident that this patch
> is at least strongly related to the problem.
> Pradeep also confirmed the problem happening in 3.16.54 but not in 3.16.51.
> Interestingly, this does *not* happen with 4.9 kernels, although the
> patch was part of 4.9.80...
> 
> I have attached a pcap file of a machine running 3.16.56-1+deb8u1 in
> which I try to login as a user where my home directory is
> /uni-mainz.de/homes/schlarbm (with nfsrefer.zdv.uni-mainz.de:/ on
> /uni-mainz.de) which is then referred to
> fs02.uni-mainz.de:/vol/ma17/homes/schlarbm but that referral is not
> followed by the client.
> 
> Please let me know if you need additional information to reproduce or
> have suggestions on what we could try.

Just a shot in the dark: Wondering if v3.16 needs

commit ea96d1ecbe4fcb1df487d99309d3157b4ff5fc02
Author:     Anna Schumaker <Anna.Schumaker@netapp.com>
AuthorDate: Fri Apr 3 14:35:59 2015 -0400
Commit:     Trond Myklebust <trond.myklebust@primarydata.com>
CommitDate: Thu Apr 23 14:43:54 2015 -0400

    nfs: Fetch MOUNTED_ON_FILEID when updating an inode


> Best regards,
> Moritz
> 
> On 05.11.2017 21:45, Chuck Lever wrote:
>> Before traversing a referral and performing a mount, the mounted-on
>> directory looks strange:
>> 
>> dr-xr-xr-x. 2 4294967294 4294967294 0 Dec 31  1969 dir.0
>> 
>> nfs4_get_referral is wiping out any cached attributes with what was
>> returned via GETATTR(fs_locations), but the bit mask for that
>> operation does not request any file attributes.
>> 
>> Retrieve owner and timestamp information so that the memcpy in
>> nfs4_get_referral fills in more attributes.
>> 
>> Changes since v1:
>> - Don't request attributes that the client unconditionally replaces
>> - Request only MOUNTED_ON_FILEID or FILEID attribute, not both
>> - encode_fs_locations() doesn't use the third bitmask word
>> 
>> Fixes: 6b97fd3da1ea ("NFSv4: Follow a referral")
>> Suggested-by: Pradeep Thomas <pradeepthomas@gmail.com>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> Cc: stable@vger.kernel.org
>> ---
>> fs/nfs/nfs4proc.c |   18 ++++++++----------
>> 1 file changed, 8 insertions(+), 10 deletions(-)
>> 
>> I could send this as an incremental, but that just seems to piss
>> off distributors, who will just squash them all together anyway.
>> 
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> 
>> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
>> index 6c61e2b..2662879 100644
>> --- a/fs/nfs/nfs4proc.c
>> +++ b/fs/nfs/nfs4proc.c
>> @@ -254,15 +254,12 @@ static int nfs4_map_errors(int err)
>> };
>> 
>> const u32 nfs4_fs_locations_bitmap[3] = {
>> -	FATTR4_WORD0_TYPE
>> -	| FATTR4_WORD0_CHANGE
>> +	FATTR4_WORD0_CHANGE
>> 	| FATTR4_WORD0_SIZE
>> 	| FATTR4_WORD0_FSID
>> 	| FATTR4_WORD0_FILEID
>> 	| FATTR4_WORD0_FS_LOCATIONS,
>> -	FATTR4_WORD1_MODE
>> -	| FATTR4_WORD1_NUMLINKS
>> -	| FATTR4_WORD1_OWNER
>> +	FATTR4_WORD1_OWNER
>> 	| FATTR4_WORD1_OWNER_GROUP
>> 	| FATTR4_WORD1_RAWDEV
>> 	| FATTR4_WORD1_SPACE_USED
>> @@ -6763,9 +6760,7 @@ static int _nfs4_proc_fs_locations(struct rpc_clnt *client, struct inode *dir,
>> 				   struct page *page)
>> {
>> 	struct nfs_server *server = NFS_SERVER(dir);
>> -	u32 bitmask[3] = {
>> -		[0] = FATTR4_WORD0_FSID | FATTR4_WORD0_FS_LOCATIONS,
>> -	};
>> +	u32 bitmask[3];
>> 	struct nfs4_fs_locations_arg args = {
>> 		.dir_fh = NFS_FH(dir),
>> 		.name = name,
>> @@ -6784,12 +6779,15 @@ static int _nfs4_proc_fs_locations(struct rpc_clnt *client, struct inode *dir,
>> 
>> 	dprintk("%s: start\n", __func__);
>> 
>> +	bitmask[0] = nfs4_fattr_bitmap[0] | FATTR4_WORD0_FS_LOCATIONS;
>> +	bitmask[1] = nfs4_fattr_bitmap[1];
>> +
>> 	/* Ask for the fileid of the absent filesystem if mounted_on_fileid
>> 	 * is not supported */
>> 	if (NFS_SERVER(dir)->attr_bitmask[1] & FATTR4_WORD1_MOUNTED_ON_FILEID)
>> -		bitmask[1] |= FATTR4_WORD1_MOUNTED_ON_FILEID;
>> +		bitmask[0] &= ~FATTR4_WORD0_FILEID;
>> 	else
>> -		bitmask[0] |= FATTR4_WORD0_FILEID;
>> +		bitmask[1] &= ~FATTR4_WORD1_MOUNTED_ON_FILEID;
>> 
>> 	nfs_fattr_init(&fs_locations->fattr);
>> 	fs_locations->server = server;
>> 
> <nfs-referral-broken.pcap><schlarbm.vcf>

--
Chuck Lever

[toc] | [prev] | [next] | [standalone]

#61050 — Bug#898165: Regression in [v2] nfs: Fix ugly referral attributes ?

> On May 17, 2018, at 5:48 PM, Moritz Schlarb <schlarbm@uni-mainz.de> wrote:
> 
> Hi Chuck,
> 
> On 17.05.2018 16:15, Chuck Lever wrote:
> 
>> Just a shot in the dark: Wondering if v3.16 needs
>> 
>> commit ea96d1ecbe4fcb1df487d99309d3157b4ff5fc02
>> Author:     Anna Schumaker <Anna.Schumaker@netapp.com>
>> AuthorDate: Fri Apr 3 14:35:59 2015 -0400
>> Commit:     Trond Myklebust <trond.myklebust@primarydata.com>
>> CommitDate: Thu Apr 23 14:43:54 2015 -0400
>> 
>>    nfs: Fetch MOUNTED_ON_FILEID when updating an inode
> 
> Gosh, it seems you're right!
> When I take that patch and apply it, the referrals are being followed again!
> 
> Thanks for your idea!
> Now how do we make sure it gets applied soonish?

Hi Moritz-

Anyone (including you or your distributor) can request that this
patch be applied to the upstream v3.16 LTS branch. Since you have
confirmed that it applies and fixes your problem, it would be
appropriate to report that along with your backport request.


--
Chuck Lever

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web