Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #59331 > unrolled thread

Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

Back to article view | Back to linux.debian.kernel

Contents

  Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most Riku Voipio <riku.voipio@linaro.org> - 2017-11-02 16:00 +0100
    Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most Riku Voipio <riku.voipio@iki.fi> - 2017-12-12 10:30 +0100
      Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most Ben Hutchings <ben@decadent.org.uk> - 2017-12-12 17:00 +0100
    Bug#880584: marked as done ([PATCH] auto_add_modules: add mfd in  MODULES==most) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2018-07-19 02:30 +0200

#59331 — Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

Package: initramfs-tools
Version: 0.130
Severity: normal
Tags: patch

Multi Function Devices may carry essential functions on arm/arm64
platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
causing MMC driver init fail.  when generating generic initrd on offline
with MODULES=most, update-initramfs doesn't pick mfd modules.

Since mfd is quite small (284K on arm64), just add them all to most. This
may also open the road to make some currently built-in CONFIG_MFD
drivers modules.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 hook-functions | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hook-functions b/hook-functions
index 679e11d..4b49391 100644
--- a/hook-functions
+++ b/hook-functions
@@ -537,6 +537,7 @@ auto_add_modules()
 			copy_modules_dir kernel/drivers/gpio
 			copy_modules_dir kernel/drivers/i2c/busses
 			copy_modules_dir kernel/drivers/i2c/muxes
+			copy_modules_dir kernel/drivers/mfd
 			copy_modules_dir kernel/drivers/phy
 			copy_modules_dir kernel/drivers/pinctrl
 			copy_modules_dir kernel/drivers/regulator
-- 
2.14.2

[toc] | [next] | [standalone]

#59629

Hi Ben,

On Thu, Nov 02, 2017 at 02:46:47PM +0000, Riku Voipio wrote:
> Package: initramfs-tools
> Version: 0.130
> Severity: normal
> Tags: patch
> 
> Multi Function Devices may carry essential functions on arm/arm64
> platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
> causing MMC driver init fail.  when generating generic initrd on offline
> with MODULES=most, update-initramfs doesn't pick mfd modules.
> 
> Since mfd is quite small (284K on arm64), just add them all to most. This
> may also open the road to make some currently built-in CONFIG_MFD
> drivers modules.


Is this patch ok to commit?
 
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
>  hook-functions | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hook-functions b/hook-functions
> index 679e11d..4b49391 100644
> --- a/hook-functions
> +++ b/hook-functions
> @@ -537,6 +537,7 @@ auto_add_modules()
>  			copy_modules_dir kernel/drivers/gpio
>  			copy_modules_dir kernel/drivers/i2c/busses
>  			copy_modules_dir kernel/drivers/i2c/muxes
> +			copy_modules_dir kernel/drivers/mfd
>  			copy_modules_dir kernel/drivers/phy
>  			copy_modules_dir kernel/drivers/pinctrl
>  			copy_modules_dir kernel/drivers/regulator
> -- 
> 2.14.2
> 

[toc] | [prev] | [next] | [standalone]

#59634

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2017-12-12 at 09:09 +0000, Riku Voipio wrote:
> Hi Ben,
> 
> On Thu, Nov 02, 2017 at 02:46:47PM +0000, Riku Voipio wrote:
> > Package: initramfs-tools
> > Version: 0.130
> > Severity: normal
> > Tags: patch
> > 
> > Multi Function Devices may carry essential functions on arm/arm64
> > platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
> > causing MMC driver init fail.  when generating generic initrd on offline
> > with MODULES=most, update-initramfs doesn't pick mfd modules.
> > 
> > Since mfd is quite small (284K on arm64), just add them all to most. This
> > may also open the road to make some currently built-in CONFIG_MFD
> > drivers modules.
> 
> 
> Is this patch ok to commit?

I suppose so.

Please add a 'Closes:' tag to the commit message.

Ben.

> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> > ---
> >  hook-functions | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hook-functions b/hook-functions
> > index 679e11d..4b49391 100644
> > --- a/hook-functions
> > +++ b/hook-functions
> > @@ -537,6 +537,7 @@ auto_add_modules()
> >  			copy_modules_dir kernel/drivers/gpio
> >  			copy_modules_dir kernel/drivers/i2c/busses
> >  			copy_modules_dir kernel/drivers/i2c/muxes
> > +			copy_modules_dir kernel/drivers/mfd
> >  			copy_modules_dir kernel/drivers/phy
> >  			copy_modules_dir kernel/drivers/pinctrl
> >  			copy_modules_dir kernel/drivers/regulator
> > -- 
> > 2.14.2
> > 
> 
> 
-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.

[toc] | [prev] | [next] | [standalone]

#61478 — Bug#880584: marked as done ([PATCH] auto_add_modules: add mfd in MODULES==most)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Thu, 19 Jul 2018 00:19:37 +0000
with message-id <E1ffwfR-000BTi-0E@fasolo.debian.org>
and subject line Bug#880584: fixed in initramfs-tools 0.131
has caused the Debian Bug report #880584,
regarding [PATCH] auto_add_modules: add mfd in MODULES==most
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
880584: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880584
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web