Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #59403 > unrolled thread

Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel

Back to article view | Back to linux.debian.kernel

Contents

  Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel James Cowgill <jcowgill@debian.org> - 2017-11-15 17:30 +0100
    Processed: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT  to Kconfig" to stretch kernel owner@bugs.debian.org (Debian Bug Tracking System) - 2017-11-15 17:30 +0100
    Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel James Cowgill <jcowgill@debian.org> - 2017-11-15 18:00 +0100
      Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel Ben Hutchings <ben@decadent.org.uk> - 2017-11-16 20:10 +0100
        Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel James Cowgill <jcowgill@debian.org> - 2017-11-16 21:40 +0100
          Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-11-17 09:20 +0100

#59403 — Bug#881830: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel

[Multipart message — attachments visible in raw view] — view raw

Source: linux
Version: 4.9.51-1
Severity: wishlist
Control: fixed -1 4.12.2-1~exp1

Hi,

Is it possible to cherry-pick the following upstream commit into the
stable kernel so it is available on the buildds?

commit 47b2c3fff4932e6fc17ce13d51a43c6969714e20
Author: Bilal Amarni <bilal.amarni@gmail.com>
Date:   Thu Jun 8 14:47:26 2017 +0100

    security/keys: add CONFIG_KEYS_COMPAT to Kconfig

This commit moves KEYS_COMPAT to an architecture independent location
and enables it on all architectures where COMPAT is enabled. This should
allow 64-bit MIPS kernels to handle 32-bit applications using the keyctl
syscall (currently they fail with ENOSYS - see keyutils package). I
think this will also help with compiling armhf on arm64 kernels.

Thanks,
James

[toc] | [next] | [standalone]

#59404 — Processed: linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel

Processing control commands:

> fixed -1 4.12.2-1~exp1
Bug #881830 [src:linux] linux: cherry-pick "security/keys: add CONFIG_KEYS_COMPAT to Kconfig" to stretch kernel
Marked as fixed in versions linux/4.12.2-1~exp1.

-- 
881830: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881830
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#59405

[Multipart message — attachments visible in raw view] — view raw

Since I was a little puzzled as to why keyutils built previously on
mips, I found this commit to 4.8 which caused the need for KEYS_COMPAT:

commit 20f06ed9f61a185c6dabd662c310bed6189470df
Author: David Howells <dhowells@redhat.com>
Date:   Wed Jul 27 11:43:37 2016 +0100

    KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace
    
    MIPS64 needs to use compat_sys_keyctl for 32-bit userspace rather than
    calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
    the issue.

Now I'm thinking maybe this can be argued as a bugfix for the above
commit and put in upstream 4.9?

James

[toc] | [prev] | [next] | [standalone]

#59411

[Multipart message — attachments visible in raw view] — view raw

On Wed, 2017-11-15 at 16:50 +0000, James Cowgill wrote:
> Since I was a little puzzled as to why keyutils built previously on
> mips, I found this commit to 4.8 which caused the need for KEYS_COMPAT:
> 
> commit 20f06ed9f61a185c6dabd662c310bed6189470df
> Author: David Howells <dhowells@redhat.com>
> Date:   Wed Jul 27 11:43:37 2016 +0100
> 
>     KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace
>     
>     MIPS64 needs to use compat_sys_keyctl for 32-bit userspace rather than
>     calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
>     the issue.
> 
> Now I'm thinking maybe this can be argued as a bugfix for the above
> commit and put in upstream 4.9?

Greg, please queue up these two for 4.9:

5c2a625937ba arm64: support keyctl() system call in 32-bit mode
47b2c3fff493 security/keys: add CONFIG_KEYS_COMPAT to Kconfig

Ben.

-- 
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of
incompetence.

[toc] | [prev] | [next] | [standalone]

#59415

[Multipart message — attachments visible in raw view] — view raw

Hi,

On 16/11/17 19:04, Ben Hutchings wrote:
> On Wed, 2017-11-15 at 16:50 +0000, James Cowgill wrote:
>> Since I was a little puzzled as to why keyutils built previously on
>> mips, I found this commit to 4.8 which caused the need for KEYS_COMPAT:
>>
>> commit 20f06ed9f61a185c6dabd662c310bed6189470df
>> Author: David Howells <dhowells@redhat.com>
>> Date:   Wed Jul 27 11:43:37 2016 +0100
>>
>>     KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace
>>     
>>     MIPS64 needs to use compat_sys_keyctl for 32-bit userspace rather than
>>     calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
>>     the issue.
>>
>> Now I'm thinking maybe this can be argued as a bugfix for the above
>> commit and put in upstream 4.9?
> 
> Greg, please queue up these two for 4.9:
> 
> 5c2a625937ba arm64: support keyctl() system call in 32-bit mode
> 47b2c3fff493 security/keys: add CONFIG_KEYS_COMPAT to Kconfig

Sorry, I asked for this in two places. I think it's already queued up
for 4.9 now.

Thanks,
James

[toc] | [prev] | [next] | [standalone]

#59417

On Thu, Nov 16, 2017 at 08:28:28PM +0000, James Cowgill wrote:
> Hi,
> 
> On 16/11/17 19:04, Ben Hutchings wrote:
> > On Wed, 2017-11-15 at 16:50 +0000, James Cowgill wrote:
> >> Since I was a little puzzled as to why keyutils built previously on
> >> mips, I found this commit to 4.8 which caused the need for KEYS_COMPAT:
> >>
> >> commit 20f06ed9f61a185c6dabd662c310bed6189470df
> >> Author: David Howells <dhowells@redhat.com>
> >> Date:   Wed Jul 27 11:43:37 2016 +0100
> >>
> >>     KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace
> >>     
> >>     MIPS64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> >>     calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
> >>     the issue.
> >>
> >> Now I'm thinking maybe this can be argued as a bugfix for the above
> >> commit and put in upstream 4.9?
> > 
> > Greg, please queue up these two for 4.9:
> > 
> > 5c2a625937ba arm64: support keyctl() system call in 32-bit mode
> > 47b2c3fff493 security/keys: add CONFIG_KEYS_COMPAT to Kconfig
> 
> Sorry, I asked for this in two places. I think it's already queued up
> for 4.9 now.

Well, close, but not quite.  The second patch there reverts the first
patch, and adds the "generic" work.  As I already handled that in the
merge of the second patch, the first one is not needed, and the end
result should be the same.

So all is good.  Or at least I think so, someone verifying I got this
all right would be appreciated :)

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web