Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #59331 > unrolled thread

Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

Started byRiku Voipio <riku.voipio@linaro.org>
First post2017-11-02 16:00 +0100
Last post2017-12-12 17:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.debian.kernel


Contents

  Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most Riku Voipio <riku.voipio@linaro.org> - 2017-11-02 16:00 +0100
    Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most Riku Voipio <riku.voipio@iki.fi> - 2017-12-12 10:30 +0100
      Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most Ben Hutchings <ben@decadent.org.uk> - 2017-12-12 17:00 +0100

#59331 — Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

FromRiku Voipio <riku.voipio@linaro.org>
Date2017-11-02 16:00 +0100
SubjectBug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most
Message-ID<uHp8m-8cS-9@gated-at.bofh.it>
Package: initramfs-tools
Version: 0.130
Severity: normal
Tags: patch

Multi Function Devices may carry essential functions on arm/arm64
platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
causing MMC driver init fail.  when generating generic initrd on offline
with MODULES=most, update-initramfs doesn't pick mfd modules.

Since mfd is quite small (284K on arm64), just add them all to most. This
may also open the road to make some currently built-in CONFIG_MFD
drivers modules.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 hook-functions | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hook-functions b/hook-functions
index 679e11d..4b49391 100644
--- a/hook-functions
+++ b/hook-functions
@@ -537,6 +537,7 @@ auto_add_modules()
 			copy_modules_dir kernel/drivers/gpio
 			copy_modules_dir kernel/drivers/i2c/busses
 			copy_modules_dir kernel/drivers/i2c/muxes
+			copy_modules_dir kernel/drivers/mfd
 			copy_modules_dir kernel/drivers/phy
 			copy_modules_dir kernel/drivers/pinctrl
 			copy_modules_dir kernel/drivers/regulator
-- 
2.14.2

[toc] | [next] | [standalone]


#59629

FromRiku Voipio <riku.voipio@iki.fi>
Date2017-12-12 10:30 +0100
Message-ID<uVP2V-1aS-1@gated-at.bofh.it>
In reply to#59331
Hi Ben,

On Thu, Nov 02, 2017 at 02:46:47PM +0000, Riku Voipio wrote:
> Package: initramfs-tools
> Version: 0.130
> Severity: normal
> Tags: patch
> 
> Multi Function Devices may carry essential functions on arm/arm64
> platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
> causing MMC driver init fail.  when generating generic initrd on offline
> with MODULES=most, update-initramfs doesn't pick mfd modules.
> 
> Since mfd is quite small (284K on arm64), just add them all to most. This
> may also open the road to make some currently built-in CONFIG_MFD
> drivers modules.


Is this patch ok to commit?
 
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
>  hook-functions | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hook-functions b/hook-functions
> index 679e11d..4b49391 100644
> --- a/hook-functions
> +++ b/hook-functions
> @@ -537,6 +537,7 @@ auto_add_modules()
>  			copy_modules_dir kernel/drivers/gpio
>  			copy_modules_dir kernel/drivers/i2c/busses
>  			copy_modules_dir kernel/drivers/i2c/muxes
> +			copy_modules_dir kernel/drivers/mfd
>  			copy_modules_dir kernel/drivers/phy
>  			copy_modules_dir kernel/drivers/pinctrl
>  			copy_modules_dir kernel/drivers/regulator
> -- 
> 2.14.2
> 

[toc] | [prev] | [next] | [standalone]


#59634

FromBen Hutchings <ben@decadent.org.uk>
Date2017-12-12 17:00 +0100
Message-ID<uVV8l-523-5@gated-at.bofh.it>
In reply to#59629

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2017-12-12 at 09:09 +0000, Riku Voipio wrote:
> Hi Ben,
> 
> On Thu, Nov 02, 2017 at 02:46:47PM +0000, Riku Voipio wrote:
> > Package: initramfs-tools
> > Version: 0.130
> > Severity: normal
> > Tags: patch
> > 
> > Multi Function Devices may carry essential functions on arm/arm64
> > platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
> > causing MMC driver init fail.  when generating generic initrd on offline
> > with MODULES=most, update-initramfs doesn't pick mfd modules.
> > 
> > Since mfd is quite small (284K on arm64), just add them all to most. This
> > may also open the road to make some currently built-in CONFIG_MFD
> > drivers modules.
> 
> 
> Is this patch ok to commit?

I suppose so.

Please add a 'Closes:' tag to the commit message.

Ben.

> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> > ---
> >  hook-functions | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hook-functions b/hook-functions
> > index 679e11d..4b49391 100644
> > --- a/hook-functions
> > +++ b/hook-functions
> > @@ -537,6 +537,7 @@ auto_add_modules()
> >  			copy_modules_dir kernel/drivers/gpio
> >  			copy_modules_dir kernel/drivers/i2c/busses
> >  			copy_modules_dir kernel/drivers/i2c/muxes
> > +			copy_modules_dir kernel/drivers/mfd
> >  			copy_modules_dir kernel/drivers/phy
> >  			copy_modules_dir kernel/drivers/pinctrl
> >  			copy_modules_dir kernel/drivers/regulator
> > -- 
> > 2.14.2
> > 
> 
> 
-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.kernel


csiph-web