Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #58240 > unrolled thread

Bug#843448: [jspricke@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB]

Back to article view | Back to linux.debian.kernel

Contents

  Bug#843448: [jspricke@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB] Jochen Sprickerhof <jspricke@debian.org> - 2017-07-03 16:40 +0200
    Bug#843448: [jspricke@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB] "Steinar H. Gunderson" <sesse@debian.org> - 2017-07-03 16:50 +0200
    Bug#843448: [jspricke@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB] "Steinar H. Gunderson" <sesse@debian.org> - 2017-07-06 23:20 +0200
      Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Jochen Sprickerhof <jspricke@debian.org> - 2017-07-07 20:50 +0200
        Processed: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to  boot on Odroid-Xu4 with rootfs on USB owner@bugs.debian.org (Debian Bug Tracking System) - 2017-07-07 20:50 +0200
        Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB "Steinar H. Gunderson" <sesse@debian.org> - 2017-07-07 21:00 +0200
        Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Vagrant Cascadian <vagrant@debian.org> - 2017-07-08 05:30 +0200
          Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Jochen Sprickerhof <jspricke@debian.org> - 2017-07-08 08:00 +0200
            Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Jochen Sprickerhof <jspricke@debian.org> - 2017-07-08 10:50 +0200
              Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB "Steinar H. Gunderson" <sesse@debian.org> - 2017-07-08 10:50 +0200
                Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Jochen Sprickerhof <jspricke@debian.org> - 2017-07-08 18:30 +0200
            Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB "Steinar H. Gunderson" <sesse@debian.org> - 2017-07-08 10:50 +0200
              Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Vagrant Cascadian <vagrant@debian.org> - 2017-07-11 03:00 +0200
                Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Vagrant Cascadian <vagrant@debian.org> - 2017-07-16 21:00 +0200
                  Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Vagrant Cascadian <vagrant@debian.org> - 2017-09-07 08:40 +0200
                    Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB "Steinar H. Gunderson" <sesse@debian.org> - 2017-09-12 22:40 +0200
                      Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Jochen Sprickerhof <jspricke@debian.org> - 2017-09-24 10:10 +0200
                        Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Ben Hutchings <ben@decadent.org.uk> - 2017-09-24 21:40 +0200
                        Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Vagrant Cascadian <vagrant@debian.org> - 2017-09-24 23:20 +0200
                        Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB gustavo panizzo <gfa@zumbi.com.ar> - 2017-09-28 05:00 +0200
                          Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB Jochen Sprickerhof <jspricke@debian.org> - 2017-09-30 18:40 +0200
            Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB gustavo panizzo <gfa@zumbi.com.ar> - 2017-07-19 14:00 +0200

Page 1 of 2  [1] 2  Next page →

#58240 — Bug#843448: [jspricke@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB]

[Multipart message — attachments visible in raw view] — view raw

Hi guys,

forgot to add you to Cc, sorry.

Cheers Jochen

----- Forwarded message from Jochen Sprickerhof <jspricke@debian.org> -----

Date: Mon, 03 Jul 2017 16:31:01 +0200
To: Debian Bug Tracking System <843448@bugs.debian.org>
X-Mailer: reportbug 7.1.7
Reply-To: Jochen Sprickerhof <jspricke@debian.org>, 843448@bugs.debian.org
From: Jochen Sprickerhof <jspricke@debian.org>
Subject: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

Package: src:linux
Followup-For: Bug #843448

Hi,

thanks to the pointers, I've condensed the first patch (74b9605e) to the
attached one against 4.9. Can you verify that it works?

I will try to port it to 4.11 and linux-next and post them.

The second patch (2166ffd00-updated.diff) looks good for me, would be great to
see it in mainline. Did someone send it to the maintainers already?

Cheers Jochen

>From a06c3727c1c19b2761b0aef267ce6338f0b2de7e Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof <git@jochen.sprickerhof.de>
Date: Mon, 3 Jul 2017 15:59:25 +0200
Subject: [PATCH] usb: dwc3: core: setup phy before trying to read from it

dwc3_readl needs the device to be set up with dwc3_phy_setup.

Tested with Odroid XU4.

This is a regression from c499ff71ff2a281366c6ec7a904c547d806cbcd1.

Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
---
 drivers/usb/dwc3/core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 33d3eb0c944a..69ad59753590 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -606,6 +606,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	u32			reg;
 	int			ret;
 
+	ret = dwc3_phy_setup(dwc);
+	if (ret)
+		goto err0;
+
 	reg = dwc3_readl(dwc->regs, DWC3_GSNPSID);
 	/* This should read as U3 followed by revision number */
 	if ((reg & DWC3_GSNPSID_MASK) == 0x55330000) {
@@ -643,10 +647,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	if (ret)
 		goto err0;
 
-	ret = dwc3_phy_setup(dwc);
-	if (ret)
-		goto err0;
-
 	reg = dwc3_readl(dwc->regs, DWC3_GCTL);
 	reg &= ~DWC3_GCTL_SCALEDOWN_MASK;
 
-- 
2.13.2



----- End forwarded message -----

[toc] | [next] | [standalone]

#58241

On Mon, Jul 03, 2017 at 04:35:49PM +0200, Jochen Sprickerhof wrote:
> thanks to the pointers, I've condensed the first patch (74b9605e) to the
> attached one against 4.9. Can you verify that it works?

I'll try to give it a shot, although I fear that I might not have the time
before my XU4 goes down for transportation. :-)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

[toc] | [prev] | [next] | [standalone]

#58286

On Mon, Jul 03, 2017 at 04:35:49PM +0200, Jochen Sprickerhof wrote:
> thanks to the pointers, I've condensed the first patch (74b9605e) to the
> attached one against 4.9. Can you verify that it works?
> 
> I will try to port it to 4.11 and linux-next and post them.
> 
> The second patch (2166ffd00-updated.diff) looks good for me, would be great to
> see it in mainline. Did someone send it to the maintainers already?

I've built latest 4.9.0 from stretch, plus your patch, plus
2166ffd00-updated.diff. It seems to boot on my XU4 with networking
working just fine; unfortunately, I can't give it much more testing
than that right now.

/* Steinar */
-- 
Homepage: https://www.sesse.net/

[toc] | [prev] | [next] | [standalone]

#58300 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

Control: tags -1 patch

Hi,

I've created patches for v4.12 (applies to v4.11 as well) and git
master and send them to the subsystem maintainers. Would be great to see
them included in the Debian kernel as well.

Cheers Jochen

[toc] | [prev] | [next] | [standalone]

#58301 — Processed: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

Processing control commands:

> tags -1 patch
Bug #843448 [src:linux] linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB
Added tag(s) patch.

-- 
843448: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843448
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#58302 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

On Fri, Jul 07, 2017 at 08:42:08PM +0200, Jochen Sprickerhof wrote:
> I've created patches for v4.12 (applies to v4.11 as well) and git
> master and send them to the subsystem maintainers. Would be great to see
> them included in the Debian kernel as well.

Thanks for doing this :-) I'd love to see this in a stretch point release
so that we don't have to wait for buster to get XU4 support.

(Granted, I've never tried d-i, but at least then I can rebuild my XU4
images.)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

[toc] | [prev] | [next] | [standalone]

#58306 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

On 2017-07-07, Jochen Sprickerhof wrote:
> I've created patches for v4.12 (applies to v4.11 as well) and git
> master and send them to the subsystem maintainers. Would be great to see
> them included in the Debian kernel as well.

Thanks!

Is this the only patch needed? Does it also need one of the patches
mentioned earlier in this bug? This is a single patch, with a v4.12 and
v4.11 variant, or two very similar looking patches?

I'd be happy to test on debian's 4.9 and 4.11 kernels, but it is a
little unclear to me exactly which patches are meant for what.

live well,
  vagrant

> From 7b12187f59ff43571e664b9f6987534ee622700f Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> Date: Fri, 7 Jul 2017 19:38:03 +0200
> Subject: [PATCH] v4.12: usb: dwc3: core: Setup phy before trying to read from
>  it
>
> Commit c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> moved the call to dwc3_phy_setup() from dwc3_probe() to dwc3_core_init()
> and after the dwc3_readl() (now in dwc3_core_is_valid). This broke USB
> and Ethernet on Odroid XU4, because dwc3_readl() needs dwc3_phy_setup()
> to be run before.
>
> Fix this by moving the call to dwc3_phy_setup() before
> dwc3_core_is_valid().
>
> This fixes USB and Ethernet on Odroid XU4.
>
> Also see https://bugs.debian.org/843448
>
> Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> ---
>  drivers/usb/dwc3/core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 455d89a1cd6d..2418979a883a 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -732,6 +732,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
>  	u32			reg;
>  	int			ret;
>  
> +	ret = dwc3_phy_setup(dwc);
> +	if (ret)
> +		goto err0;
> +
>  	if (!dwc3_core_is_valid(dwc)) {
>  		dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
>  		ret = -ENODEV;
> @@ -755,10 +759,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
>  	if (ret)
>  		goto err0;
>  
> -	ret = dwc3_phy_setup(dwc);
> -	if (ret)
> -		goto err0;
> -
>  	dwc3_core_setup_global_control(dwc);
>  	dwc3_core_num_eps(dwc);
>  
> -- 
> 2.13.2
>
> From 6b7d33243a364c668530a5ae11ed5a57cecd42d9 Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> Date: Fri, 7 Jul 2017 19:38:03 +0200
> Subject: [PATCH] usb: dwc3: core: Setup phy before trying to read from it
>
> Commit c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> moved the call to dwc3_phy_setup() from dwc3_probe() to dwc3_core_init()
> and after the dwc3_readl() (now in dwc3_core_is_valid). This broke USB
> and Ethernet on Odroid XU4, because dwc3_readl() needs dwc3_phy_setup()
> to be run before.
>
> Fix this by moving the call to dwc3_phy_setup() before
> dwc3_core_is_valid().
>
> This fixes USB and Ethernet on Odroid XU4.
>
> This needs and is supposed to be applied on top of
> https://patchwork.kernel.org/patch/9815981/
>
> Also see https://bugs.debian.org/843448
>
> Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> ---
>  drivers/usb/dwc3/core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 03474d3575ab..3c6faddc1394 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -747,6 +747,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
>  	u32			reg;
>  	int			ret;
>  
> +	ret = dwc3_phy_setup(dwc);
> +	if (ret)
> +		goto err0;
> +
>  	if (!dwc3_core_is_valid(dwc)) {
>  		dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
>  		ret = -ENODEV;
> @@ -774,10 +778,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
>  	if (ret)
>  		goto err0;
>  
> -	ret = dwc3_phy_setup(dwc);
> -	if (ret)
> -		goto err0;
> -
>  	dwc3_core_setup_global_control(dwc);
>  	dwc3_core_num_eps(dwc);
>  
> -- 
> 2.13.2

[toc] | [prev] | [next] | [standalone]

#58307 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

Hi Vagrant,

* Vagrant Cascadian <vagrant@debian.org> [2017-07-07 20:21]:
> Is this the only patch needed? Does it also need one of the patches
> mentioned earlier in this bug? This is a single patch, with a v4.12 and
> v4.11 variant, or two very similar looking patches?
> 
> I'd be happy to test on debian's 4.9 and 4.11 kernels, but it is a
> little unclear to me exactly which patches are meant for what.

Sorry for being unclear.

For v4.9 the only patch needed is:

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97

For v4.11 and v4.12 the only patch needed is:

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-v4.12-usb-dwc3-core-Setup-phy-before-trying-to-read-.patch;msg=117

For current Linux master you need:

https://patchwork.kernel.org/patch/9815981/
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=2;bug=843448;filename=0001-usb-dwc3-core-Setup-phy-before-trying-to-read-from-i.patch;msg=117

I also forwarded this upstream here:

http://marc.info/?l=linux-usb&m=149945465112440&w=2

Test results welcome.

Cheers Jochen

[toc] | [prev] | [next] | [standalone]

#58308 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

* Steinar H. Gunderson <sesse@debian.org> [2017-07-08 10:38]:
> Don't you also want this?
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75

This is not needed to fix this bug.

Cheers Jochen

[toc] | [prev] | [next] | [standalone]

#58309 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

On Sat, Jul 08, 2017 at 10:42:26AM +0200, Jochen Sprickerhof wrote:
>> Don't you also want this?
>> 
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75
> This is not needed to fix this bug.

Well, you don't get working USB after a warm boot without it, do you?

/* Steinar */
-- 
Homepage: https://www.sesse.net/

[toc] | [prev] | [next] | [standalone]

#58313 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

* Steinar H. Gunderson <sesse@debian.org> [2017-07-08 10:43]:
> Well, you don't get working USB after a warm boot without it, do you?

Oups forgot to test that, you are totally right :).

@Gustavo: could you take care of brining that one upstream? Thanks!

Cheers Jochen

[toc] | [prev] | [next] | [standalone]

#58310 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
> For v4.9 the only patch needed is:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97

Don't you also want this?

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75

/* Steinar */
-- 
Homepage: https://www.sesse.net/

[toc] | [prev] | [next] | [standalone]

#58337 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

On 2017-07-08, Steinar H. Gunderson wrote:
> On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
>> For v4.9 the only patch needed is:
>> 
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug„3448;filename01-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg—
>
> Don't you also want this?
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug„3448;filename!66ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msgu

I've built patched linux 4.9 packages using the above two patches, and
am running them on several odroid-xu4 boards used in the reproducible
builds builders, running rootfs and a build partition on USB. So that
should test USB reasonably well... I'll report if there are any major
stability issues.

I'll also try to switch one of them over to a patched 4.11 or 4.12
soonish... to make sure there aren't further regressions there.


Thanks everyone for working on this!


live well,
  vagrant

[toc] | [prev] | [next] | [standalone]

#58385 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

On 2017-07-10, Vagrant Cascadian wrote:
> On 2017-07-08, Steinar H. Gunderson wrote:
>> On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
>>> For v4.9 the only patch needed is:
>>> 
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug„3448;filename01-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg—
>>
>> Don't you also want this?
>>
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug„3448;filename!66ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msgu
>
> I've built patched linux 4.9 packages using the above two patches, and
> am running them on several odroid-xu4 boards used in the reproducible
> builds builders, running rootfs and a build partition on USB. So that
> should test USB reasonably well... I'll report if there are any major
> stability issues.

There have been infrequent USB resets, but it usually handles them
successfully:

[500623.473890] scsi host0: uas_eh_bus_reset_handler start
[500623.483176] sd 0:0:0:0: [sda] tag#22 uas_zap_pending 0 uas-tag 23
inflight: CMD
[500623.489235] sd 0:0:0:0: [sda] tag#22 CDB: Write(10) 2a 00 01 a4 51
10 00 00 10 00
[500623.496778] sd 0:0:0:0: [sda] tag#23 uas_zap_pending 0 uas-tag 24
inflight: CMD
[500623.504219] sd 0:0:0:0: [sda] tag#23 CDB: Read(10) 28 00 00 66 59 20
00 00 60 00
[500623.511678] sd 0:0:0:0: [sda] tag#24 uas_zap_pending 0 uas-tag 25
inflight: CMD
[500623.519120] sd 0:0:0:0: [sda] tag#24 CDB: Write(10) 2a 00 04 d4 c1
e8 00 00 18 00
[500623.526667] sd 0:0:0:0: [sda] tag#25 uas_zap_pending 0 uas-tag 26
inflight: CMD
[500623.534112] sd 0:0:0:0: [sda] tag#25 CDB: Read(10) 28 00 00 50 b1 10
00 00 08 00
[500623.541570] sd 0:0:0:0: [sda] tag#26 uas_zap_pending 0 uas-tag 27
inflight: CMD
[500623.549012] sd 0:0:0:0: [sda] tag#26 CDB: Write(10) 2a 00 04 d4 c6
58 00 00 08 00
[500623.556561] sd 0:0:0:0: [sda] tag#27 uas_zap_pending 0 uas-tag 28
inflight: CMD
[500623.564003] sd 0:0:0:0: [sda] tag#27 CDB: Read(10) 28 00 00 66 58 e0
00 00 40 00
[500623.654698] usb 4-1.2: reset SuperSpeed USB device number 3 using
xhci-hcd
[500623.681540] scsi host0: uas_eh_bus_reset_handler success

This is no worse than when running on 4.7.


> I'll also try to switch one of them over to a patched 4.11 or 4.12
> soonish... to make sure there aren't further regressions there.

One of them was running 4.11, and didn't seem any better or worse.


live well,
  vagrant

[toc] | [prev] | [next] | [standalone]

#58870 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

On 2017-07-16, Vagrant Cascadian wrote:
> On 2017-07-10, Vagrant Cascadian wrote:
>> On 2017-07-08, Steinar H. Gunderson wrote:
>>> On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
>>>> For v4.9 the only patch needed is:
>>>> 
>>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug„3448;filename01-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg—
>>>
>>> Don't you also want this?
>>>
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug„3448;filename!66ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msgu
>>
>> I've built patched linux 4.9 packages using the above two patches, and
>> am running them on several odroid-xu4 boards used in the reproducible
>> builds builders, running rootfs and a build partition on USB. So that
>> should test USB reasonably well... I'll report if there are any major
>> stability issues.

4.9 still working reasonably well...


>> I'll also try to switch one of them over to a patched 4.11 or 4.12
>> soonish... to make sure there aren't further regressions there.
>
> One of them was running 4.11, and didn't seem any better or worse.

And updated to testing on 4.12.10 on one of the boards...


Any progress getting these patches upstream?


live well,
  vagrant

[toc] | [prev] | [next] | [standalone]

#58912 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

On Wed, Sep 06, 2017 at 11:24:27PM -0700, Vagrant Cascadian wrote:
>> One of them was running 4.11, and didn't seem any better or worse.
> And updated to testing on 4.12.10 on one of the boards...
> 
> Any progress getting these patches upstream?

...and on getting them into a stretch point release? It's really the only
thing that's missing for completely plain stretch on these boards. :-)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

[toc] | [prev] | [next] | [standalone]

#58985 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

Hi,

Finally I had the time and hardware available to look into this again 
and found a better way to fix it. Applying the attached patch results in 
a new exynos5422-odroidxu4.dtb that could simply be copied to /boot/dtbs/*/
I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.

@Ben: This seems unintrusive enough to be included in the next stretch 
point release, what do you think?

Cheers Jochen

[toc] | [prev] | [next] | [standalone]

#58991 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

On Sun, 2017-09-24 at 09:52 +0200, Jochen Sprickerhof wrote:
> Hi,
> 
> Finally I had the time and hardware available to look into this again 
> and found a better way to fix it. Applying the attached patch results in 
> a new exynos5422-odroidxu4.dtb that could simply be copied to /boot/dtbs/*/
> I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
> as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.
> 
> @Ben: This seems unintrusive enough to be included in the next stretch 
> point release, what do you think?

I'm not applying this until it's accepted upstream.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an
expert.

[toc] | [prev] | [next] | [standalone]

#58999 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Multipart message — attachments visible in raw view] — view raw

On 2017-09-24, Jochen Sprickerhof wrote:
> Finally I had the time and hardware available to look into this again 
> and found a better way to fix it. Applying the attached patch results in 
> a new exynos5422-odroidxu4.dtb that could simply be copied to /boot/dtbs/*/
> I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
> as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.

Thanks!

I'm testing the patched .dtb on linux-image-4.9.0-3-armmp-lpae on two
machines and one machine running linux-image-4.13.0-trunk-armmp-lpae.
All use USB for rootfs and a build partition, so should test USB
reasonable well. Seems to work fine so far.

Using a patched .dtb is a much easier workaround than having to
recompile the whole kernel (and follow security updates and so on)!

I'd be happy to also do some testing with newer mainline kernels, if
you'd like to CC me on patch submissions upstream.


live well,
  vagrant

> Cheers Jochen
> From 0d3552be829d5a275d549cbf6ab468bfdb026e49 Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> Date: Sun, 24 Sep 2017 08:28:12 +0200
> Subject: [PATCH] ARM: dts: exynos: Use dwc3 quirk for USB3 and LAN on Odroid
>  XU4
>
> First proposed in https://lkml.org/lkml/2015/3/18/400 and discussed
> again in https://lkml.org/lkml/2017/1/24/402.
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu4.dts | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
> index 2faf88627a48..3861f74b2ecc 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
> @@ -43,6 +43,11 @@
>  	status = "okay";
>  };
>  
> +&usbdrd_dwc3_0 {
> +	snps,dis_u3_susphy_quirk;
> +};
> +
>  &usbdrd_dwc3_1 {
>  	dr_mode = "host";
> +	snps,dis_u3_susphy_quirk;
>  };
> -- 
> 2.14.1

[toc] | [prev] | [next] | [standalone]

#59042 — Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

On Sun, Sep 24, 2017 at 07:52:29AM +0000, Jochen Sprickerhof wrote:
>Hi,
>
>Finally I had the time and hardware available to look into this again 
>and found a better way to fix it. Applying the attached patch results 
>in a new exynos5422-odroidxu4.dtb that could simply be copied to 
>/boot/dtbs/*/
>I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
>as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.

I've tested with linux-next, on top of commit
73527316e3fdde8a210b8ab66c1bf48538cf6b09
4.14.0-rc1-next-20170922+

everything works fine, USB3 devices work fine after reboot :)

@Jochen, will you try to get it merged upstream?

>
>@Ben: This seems unintrusive enough to be included in the next stretch 
>point release, what do you think?
>
>Cheers Jochen





-- 
IRC: gfa
GPG: 0X44BB1BA79F6C6333

[toc] | [prev] | [next] | [standalone]

Page 1 of 2  [1] 2  Next page →

Back to top | Article view | linux.debian.kernel

csiph-web