Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #57995 > unrolled thread

Bug#864536: missing kernel modules in D-I sd-card images

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#864536: missing kernel modules in D-I sd-card images Cyril Brulebois <kibi@debian.org> - 2017-06-11 02:30 +0200
    Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images Karsten Merker <merker@debian.org> - 2017-06-11 10:40 +0200
      Re: Bug#864536: missing kernel modules in D-I sd-card images Cyril Brulebois <kibi@debian.org> - 2017-06-11 17:20 +0200
      Bug#856111: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images Karsten Merker <merker@debian.org> - 2017-06-11 17:40 +0200
        Processed: Re: Bug#864457: Bug#864536: missing kernel modules in  D-I sd-card images owner@bugs.debian.org (Debian Bug Tracking System) - 2017-06-11 17:40 +0200
        Processed: Re: Bug#864457: Bug#864536: missing kernel modules in  D-I sd-card images owner@bugs.debian.org (Debian Bug Tracking System) - 2017-06-11 17:40 +0200
        Processed: Re: Bug#864457: Bug#864536: missing kernel modules in  D-I sd-card images owner@bugs.debian.org (Debian Bug Tracking System) - 2017-06-11 17:40 +0200
        Bug#856111: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images Cyril Brulebois <kibi@debian.org> - 2017-06-14 09:40 +0200
          Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card  images Karsten Merker <merker@debian.org> - 2017-06-14 22:30 +0200
            Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card  images Cyril Brulebois <kibi@debian.org> - 2017-06-15 10:40 +0200

#57995 — Bug#864536: missing kernel modules in D-I sd-card images

[Multipart message — attachments visible in raw view] — view raw

Hi Diego,

(adding kernel maintainers to the loop for the fix, and release team for
comments about the extra package I think we would need to fix this.)

Diego Roversi <diegor@tiscali.it> (2017-06-10):
> Package: debian-installer
> Version: 20170525
> 
> SD-card image from
> https://d-i.debian.org/daily-images/armhf/daily/netboot/SD-card-images/,
> doesn't have a kernel module, so mmc and network does'nt work.
> 
> There was also a thread in debian-arm mailing list about this issue:
> 
> https://lists.debian.org/debian-arm/2017/01/msg00000.html
> 
> The missing module is i2c_rk3x. Could you add to the image? 

Looking at linux.git, it seems this driver is built as a module, but there's
no i2c-modules udeb for armhf. I don't think this bug is critical enough to
have a linux upload before r0 (unless something is in the works already),
but I'm a little concerned that postponing a bug fix for r1 wouldn't be too
nice… Adding a new binary package in a point release feels wrong. :(


KiBi.

[toc] | [next] | [standalone]

#57997 — Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

On Sun, Jun 11, 2017 at 02:17:37AM +0200, Cyril Brulebois wrote:
> Hi Diego,
> 
> (adding kernel maintainers to the loop for the fix, and release team for
> comments about the extra package I think we would need to fix this.)
> 
> Diego Roversi <diegor@tiscali.it> (2017-06-10):
> > Package: debian-installer
> > Version: 20170525
> > 
> > SD-card image from
> > https://d-i.debian.org/daily-images/armhf/daily/netboot/SD-card-images/,
> > doesn't have a kernel module, so mmc and network does'nt work.
> > 
> > There was also a thread in debian-arm mailing list about this issue:
> > 
> > https://lists.debian.org/debian-arm/2017/01/msg00000.html
> > 
> > The missing module is i2c_rk3x. Could you add to the image? 
> 
> Looking at linux.git, it seems this driver is built as a module, but there's
> no i2c-modules udeb for armhf. I don't think this bug is critical enough to
> have a linux upload before r0 (unless something is in the works already),
> but I'm a little concerned that postponing a bug fix for r1 wouldn't be too
> nice… Adding a new binary package in a point release feels wrong. :(

Hello,

as we appear to have the same underlying problem in bugs 864536,
864457 and 856111, I personally think that adding the modules
necessary for i2c-support in d-i is worth another upload before
r0, provided the current diagnosis in 864457 is correct and
handling the additional work due to this is doable for everybody
involved.

If the current diagnosis in 864457 is correct, not providing i2c
modules AFAICS will not only break d-i completely on the
Firefly-RK3288 (bug 864536) but also the following usecases:

- all hd-media and thereby all offline installs
- all installations to USB-connected harddisks
- all non-serial-console installations due to non-working
  USB keyboard support

on all systems that use the AXP20x series of powermanagement
controllers, which is a significant part of the armhf platforms
that we provide installer images for:

- A10-OLinuXino-Lime
- A20-OLinuXino-Lime
- A20-OLinuXino-Lime2
- A20-OLinuXino-MICRO
- A20-Olimex-SOM-EVB
- BananaPi
- BananaPro
- Cubieboard
- Cubieboard2
- Cubietruck
- Lamobo_R1
- orangepi_plus
- pcDuino
- pcDuino3

AIUI, the following changes to the kernel package would be
needed:

- add an i2c-modules config for armhf which includes the generic
  i2c-modules config plus the i2c-mv64xxx and i2c-rk3x modules 
- add the axp20x_usb_power module to the armhf kernel-image config
  to address the specifics of bug #856111 (see Ben Hutchings' notes
  at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856111#54)

As that effectively only makes the same modules that we already
install on all armhf systems also available inside the d-i
environment, the chances of causing a regression by this change
are rather low.  Size constraints are AFAIK not a problem on
armhf (in contrast to armel), so the aforementioned changes
should be rather low-risk.

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.

[toc] | [prev] | [next] | [standalone]

#58000

[Multipart message — attachments visible in raw view] — view raw

Hey debian-kernel,

Karsten Merker <merker@debian.org> (2017-06-11):
> as we appear to have the same underlying problem in bugs 864536,
> 864457 and 856111, I personally think that adding the modules
> necessary for i2c-support in d-i is worth another upload before
> r0, provided the current diagnosis in 864457 is correct and
> handling the additional work due to this is doable for everybody
> involved.
> 
> If the current diagnosis in 864457 is correct, not providing i2c
> modules AFAICS will not only break d-i completely on the
> Firefly-RK3288 (bug 864536) but also the following usecases:
> 
> - all hd-media and thereby all offline installs
> - all installations to USB-connected harddisks
> - all non-serial-console installations due to non-working
>   USB keyboard support
> 
> on all systems that use the AXP20x series of powermanagement
> controllers, which is a significant part of the armhf platforms
> that we provide installer images for:
> 
> - A10-OLinuXino-Lime
> - A20-OLinuXino-Lime
> - A20-OLinuXino-Lime2
> - A20-OLinuXino-MICRO
> - A20-Olimex-SOM-EVB
> - BananaPi
> - BananaPro
> - Cubieboard
> - Cubieboard2
> - Cubietruck
> - Lamobo_R1
> - orangepi_plus
> - pcDuino
> - pcDuino3
> 
> AIUI, the following changes to the kernel package would be
> needed:
> 
> - add an i2c-modules config for armhf which includes the generic
>   i2c-modules config plus the i2c-mv64xxx and i2c-rk3x modules 
> - add the axp20x_usb_power module to the armhf kernel-image config
>   to address the specifics of bug #856111 (see Ben Hutchings' notes
>   at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856111#54)
> 
> As that effectively only makes the same modules that we already
> install on all armhf systems also available inside the d-i
> environment, the chances of causing a regression by this change
> are rather low.  Size constraints are AFAIK not a problem on
> armhf (in contrast to armel), so the aforementioned changes
> should be rather low-risk.

Based on Karsten's input, I'm now rather convinced that adding a udeb
before r0 would be the best way to deal with it. Even if some other
modules are missing inside, we still have a chance of fixing this in a
point release by just adding a few .ko files to an already existing
udeb, instead of introducing it during a point release.

I've just checked with Niels, and this looks like a sane approach from a
release team point of view.

Do you know if you'll be able to perform a new linux upload from the
stretch branch in a relatively near future? The sooner we get fixes, the
more we can run tests, and the saner release people will be. ;)

Please let me know if I can help.


KiBi.

[toc] | [prev] | [next] | [standalone]

#58001 — Bug#856111: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

[Multipart message — attachments visible in raw view] — view raw

control: tags 864536 + patch
control: tags 864457 + patch
control: tags 856111 + patch

On Sun, Jun 11, 2017 at 10:30:58AM +0200, Karsten Merker wrote:
> On Sun, Jun 11, 2017 at 02:17:37AM +0200, Cyril Brulebois wrote:
> > Hi Diego,
> > 
> > (adding kernel maintainers to the loop for the fix, and release team for
> > comments about the extra package I think we would need to fix this.)
> > 
> > Diego Roversi <diegor@tiscali.it> (2017-06-10):
> > > Package: debian-installer
> > > Version: 20170525
> > > 
> > > SD-card image from
> > > https://d-i.debian.org/daily-images/armhf/daily/netboot/SD-card-images/,
> > > doesn't have a kernel module, so mmc and network does'nt work.
> > > 
> > > There was also a thread in debian-arm mailing list about this issue:
> > > 
> > > https://lists.debian.org/debian-arm/2017/01/msg00000.html
> > > 
> > > The missing module is i2c_rk3x. Could you add to the image? 
> > 
> > Looking at linux.git, it seems this driver is built as a module, but there's
> > no i2c-modules udeb for armhf. I don't think this bug is critical enough to
> > have a linux upload before r0 (unless something is in the works already),
> > but I'm a little concerned that postponing a bug fix for r1 wouldn't be too
> > nice… Adding a new binary package in a point release feels wrong. :(
> 
> Hello,
> 
> as we appear to have the same underlying problem in bugs 864536,
> 864457 and 856111, I personally think that adding the modules
> necessary for i2c-support in d-i is worth another upload before
> r0, provided the current diagnosis in 864457 is correct and
> handling the additional work due to this is doable for everybody
> involved.
> 
> If the current diagnosis in 864457 is correct, not providing i2c
> modules AFAICS will not only break d-i completely on the
> Firefly-RK3288 (bug 864536) but also the following usecases:
> 
> - all hd-media and thereby all offline installs
> - all installations to USB-connected harddisks
> - all non-serial-console installations due to non-working
>   USB keyboard support
> 
> on all systems that use the AXP20x series of powermanagement
> controllers, which is a significant part of the armhf platforms
> that we provide installer images for:
> 
> - A10-OLinuXino-Lime
> - A20-OLinuXino-Lime
> - A20-OLinuXino-Lime2
> - A20-OLinuXino-MICRO
> - A20-Olimex-SOM-EVB
> - BananaPi
> - BananaPro
> - Cubieboard
> - Cubieboard2
> - Cubietruck
> - Lamobo_R1
> - orangepi_plus
> - pcDuino
> - pcDuino3
> 
> AIUI, the following changes to the kernel package would be
> needed:
> 
> - add an i2c-modules config for armhf which includes the generic
>   i2c-modules config plus the i2c-mv64xxx and i2c-rk3x modules 
> - add the axp20x_usb_power module to the armhf kernel-image config
>   to address the specifics of bug #856111 (see Ben Hutchings' notes
>   at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856111#54)
> 
> As that effectively only makes the same modules that we already
> install on all armhf systems also available inside the d-i
> environment, the chances of causing a regression by this change
> are rather low.  Size constraints are AFAIK not a problem on
> armhf (in contrast to armel), so the aforementioned changes
> should be rather low-risk.

I have just finished a test build with the aforementioned changes
and it successfully initializes the USB host controllers on
a system with an AXP20x.

A patch against the kernel package is attached.  After that
change is applied to the kernel package, we would then need to
add the i2c-modules udeb to the installer builds for armhf.

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.

[toc] | [prev] | [next] | [standalone]

#58002 — Processed: Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

Processing control commands:

> tags 864536 + patch
Bug #864536 [debian-installer] missing kernel modules in D-I sd-card images
Ignoring request to alter tags of bug #864536 to the same tags previously set
> tags 864457 + patch
Bug #864457 [installation-reports] [d-i daily hd-media 20170608] kernel doesn't initialize USB ports inside d-i on a sunxi-based system
Ignoring request to alter tags of bug #864457 to the same tags previously set
> tags 856111 + patch
Bug #856111 [src:linux] failed install: no keyboard support on armhf:BananaPi
Ignoring request to alter tags of bug #856111 to the same tags previously set

-- 
856111: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856111
864457: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864457
864536: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864536
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#58003 — Processed: Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

Processing control commands:

> tags 864536 + patch
Bug #864536 [debian-installer] missing kernel modules in D-I sd-card images
Ignoring request to alter tags of bug #864536 to the same tags previously set
> tags 864457 + patch
Bug #864457 [installation-reports] [d-i daily hd-media 20170608] kernel doesn't initialize USB ports inside d-i on a sunxi-based system
Ignoring request to alter tags of bug #864457 to the same tags previously set
> tags 856111 + patch
Bug #856111 [src:linux] failed install: no keyboard support on armhf:BananaPi
Ignoring request to alter tags of bug #856111 to the same tags previously set

-- 
856111: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856111
864457: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864457
864536: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864536
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#58004 — Processed: Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

Processing control commands:

> tags 864536 + patch
Bug #864536 [debian-installer] missing kernel modules in D-I sd-card images
Added tag(s) patch.
> tags 864457 + patch
Bug #864457 [installation-reports] [d-i daily hd-media 20170608] kernel doesn't initialize USB ports inside d-i on a sunxi-based system
Added tag(s) patch.
> tags 856111 + patch
Bug #856111 [src:linux] failed install: no keyboard support on armhf:BananaPi
Added tag(s) patch.

-- 
856111: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856111
864457: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864457
864536: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864536
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#58026 — Bug#856111: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

[Multipart message — attachments visible in raw view] — view raw

Karsten Merker <merker@debian.org> (2017-06-11):
> A patch against the kernel package is attached.  After that
> change is applied to the kernel package, we would then need to
> add the i2c-modules udeb to the installer builds for armhf.

So I've seen you pushed the changes in master for debian-installer. I'll
trigger another “daily” build for armhf, and the results should show up
at [1] in a few hours (we have a few crontab entries on dillon, so it's
not refreshed immediately).

 1. https://d-i.debian.org/daily-images/daily-build-overview.html


KiBi.

[toc] | [prev] | [next] | [standalone]

#58037 — Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

On Wed, Jun 14, 2017 at 09:27:25AM +0200, Cyril Brulebois wrote:
> Karsten Merker <merker@debian.org> (2017-06-11):
> > A patch against the kernel package is attached.  After that
> > change is applied to the kernel package, we would then need to
> > add the i2c-modules udeb to the installer builds for armhf.
> 
> So I've seen you pushed the changes in master for debian-installer. I'll
> trigger another “daily” build for armhf, and the results should show up
> at [1] in a few hours (we have a few crontab entries on dillon, so it's
> not refreshed immediately).
> 
>  1. https://d-i.debian.org/daily-images/daily-build-overview.html

Hello,

I have just completed a testinstall of the new "daily" build
(hd-media offline install, debian-testing-armhf-xfce-CD-1.iso
dated 2017-06-12, serial console, from a USB-Stick to an SD-card)
on a Banana Pi, i.e. on a system with an AXP20x powermanagement
controller, and everything has worked flawlessly.

I have also checked that a USB-keyboard (and the HDMI console)
work in d-i.

Diego, could you test the new "daily" on your firefly as well?
https://d-i.debian.org/daily-images/armhf/20170614-07:46/

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.

[toc] | [prev] | [next] | [standalone]

#58043 — Re: Bug#864457: Bug#864536: missing kernel modules in D-I sd-card images

[Multipart message — attachments visible in raw view] — view raw

Hi,

Karsten Merker <merker@debian.org> (2017-06-14):
> I have just completed a testinstall of the new "daily" build
> (hd-media offline install, debian-testing-armhf-xfce-CD-1.iso
> dated 2017-06-12, serial console, from a USB-Stick to an SD-card)
> on a Banana Pi, i.e. on a system with an AXP20x powermanagement
> controller, and everything has worked flawlessly.
> 
> I have also checked that a USB-keyboard (and the HDMI console)
> work in d-i.

This is wonderful, thanks! I had planned to upload in any cases, but
having confirmation runtime is OK as well is very nice. Just uploaded
debian-installer_20170615_source.changes accordingly.


KiBi.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web