Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #56540 > unrolled thread

[PATCH v2] [arm64] Add more options

Started byriku.voipio@linaro.org
First post2017-01-13 16:00 +0100
Last post2017-01-24 13:30 +0100
Articles 5 — 4 participants

Back to article view | Back to linux.debian.kernel


Contents

  [PATCH v2] [arm64] Add more options riku.voipio@linaro.org - 2017-01-13 16:00 +0100
    Re: [PATCH v2] [arm64] Add more options Riku Voipio <riku.voipio@iki.fi> - 2017-01-23 10:00 +0100
    Re: [PATCH v2] [arm64] Add more options Ben Hutchings <ben@decadent.org.uk> - 2017-01-24 03:30 +0100
      Re: [PATCH v2] [arm64] Add more options Riku Voipio <riku.voipio@linaro.org> - 2017-01-24 11:00 +0100
        Re: [PATCH v2] [arm64] Add more options Ben Hutchings <ben@decadent.org.uk> - 2017-01-24 13:30 +0100

#56540 — [PATCH v2] [arm64] Add more options

Fromriku.voipio@linaro.org
Date2017-01-13 16:00 +0100
Subject[PATCH v2] [arm64] Add more options
Message-ID<sZbuF-26I-5@gated-at.bofh.it>
From: Riku Voipio <riku.voipio@linaro.org>

* Enable Cavium ThunderX server architecutre
* Enable server related options
* Enable CMA for DB410c DRM
* Some missing gpio driver enabled in upstream defconfig
* DT cpufreq, spidev and missing DB410c audio setting
---
 debian/config/arm64/config | 70 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/debian/config/arm64/config b/debian/config/arm64/config
index f87157346..08c42e7e5 100644
--- a/debian/config/arm64/config
+++ b/debian/config/arm64/config
@@ -9,11 +9,13 @@ CONFIG_ARM64_ERRATUM_834220=y
 CONFIG_ARM64_VA_BITS_48=y
 ## end choice
 CONFIG_SCHED_MC=y
+CONFIG_NUMA=y
 CONFIG_SECCOMP=y
 CONFIG_XEN=y
 CONFIG_RANDOMIZE_BASE=y
 CONFIG_RANDOMIZE_MODULE_REGION_FULL=y
 CONFIG_EFI_SECURE_BOOT_SECURELEVEL=y
+CONFIG_ARM64_ACPI_PARKING_PROTOCOL=y
 CONFIG_COMPAT=y
 
 ##
@@ -44,6 +46,7 @@ CONFIG_ARCH_MVEBU=y
 CONFIG_ARCH_QCOM=y
 CONFIG_ARCH_SEATTLE=y
 CONFIG_ARCH_TEGRA=y
+CONFIG_ARCH_THUNDER=y
 CONFIG_ARCH_VEXPRESS=y
 CONFIG_ARCH_XGENE=y
 
@@ -51,6 +54,7 @@ CONFIG_ARCH_XGENE=y
 ## file: drivers/acpi/Kconfig
 ##
 CONFIG_ACPI=y
+CONFIG_ACPI_NUMA=y
 
 ##
 ## file: drivers/ata/Kconfig
@@ -59,6 +63,13 @@ CONFIG_SATA_AHCI_PLATFORM=m
 CONFIG_AHCI_MVEBU=m
 CONFIG_AHCI_TEGRA=m
 CONFIG_AHCI_XGENE=m
+CONFIG_SATA_AHCI_SEATTLE=m
+
+##
+## file: drivers/base/Kconfig
+##
+CONFIG_DMA_CMA=y
+CONFIG_CMA_SIZE_MBYTES=64
 
 ##
 ## file: drivers/bluetooth/Kconfig
@@ -78,6 +89,8 @@ CONFIG_TEGRA_ACONNECT=y
 CONFIG_HW_RANDOM_BCM2835=m
 CONFIG_HW_RANDOM_HISI=m
 CONFIG_HW_RANDOM_MSM=m
+CONFIG_HW_RANDOM_XGENE=m
+CONFIG_HW_RANDOM_CAVIUM=m
 
 ##
 ## file: drivers/char/ipmi/Kconfig
@@ -105,6 +118,11 @@ CONFIG_MSM_GCC_8996=y
 CONFIG_MSM_MMCC_8996=y
 
 ##
+## file: drivers/cpufreq/Kconfig
+##
+CONFIG_CPUFREQ_DT=m
+
+##
 ## file: drivers/cpuidle/Kconfig.arm
 ##
 CONFIG_ARM_CPUIDLE=y
@@ -119,6 +137,7 @@ CONFIG_CRYPTO_DEV_QCE=m
 ##
 CONFIG_DMADEVICES=y
 CONFIG_DMA_BCM2835=y
+CONFIG_K3_DMA=m
 CONFIG_MV_XOR=y
 CONFIG_MV_XOR_V2=y
 CONFIG_TEGRA20_APB_DMA=y
@@ -155,6 +174,9 @@ CONFIG_RASPBERRYPI_FIRMWARE=y
 ## file: drivers/gpio/Kconfig
 ##
 CONFIG_GPIOLIB=y
+CONFIG_GPIO_PL061=y
+CONFIG_GPIO_XGENE=y
+CONFIG_GPIO_XGENE_SB=m
 CONFIG_GPIO_PCA953X=y
 CONFIG_GPIO_PCA953X_IRQ=y
 CONFIG_GPIO_MAX77620=y
@@ -205,6 +227,11 @@ CONFIG_DRM_VC4=m
 CONFIG_TEGRA_HOST1X=m
 
 ##
+## file: drivers/hwmon/Kconfig
+##
+CONFIG_SENSORS_XGENE=m
+
+##
 ## file: drivers/hwspinlock/Kconfig
 ##
 CONFIG_HWSPINLOCK_QCOM=m
@@ -222,6 +249,7 @@ CONFIG_I2C_DESIGNWARE_PLATFORM=m
 CONFIG_I2C_MV64XXX=m
 CONFIG_I2C_QUP=m
 CONFIG_I2C_TEGRA=m
+CONFIG_I2C_THUNDERX=m
 CONFIG_I2C_CROS_EC_TUNNEL=m
 CONFIG_I2C_XGENE_SLIMPRO=m
 
@@ -234,6 +262,7 @@ CONFIG_QCOM_SPMI_VADC=m
 ##
 ## file: drivers/input/keyboard/Kconfig
 ##
+CONFIG_KEYBOARD_GPIO=m
 CONFIG_KEYBOARD_TEGRA=m
 
 ##
@@ -248,6 +277,8 @@ CONFIG_INPUT_HISI_POWERKEY=m
 ## file: drivers/iommu/Kconfig
 ##
 CONFIG_TEGRA_IOMMU_SMMU=y
+CONFIG_ARM_SMMU=y
+CONFIG_ARM_SMMU_V3=y
 
 ##
 ## file: drivers/leds/Kconfig
@@ -284,6 +315,11 @@ CONFIG_MFD_SPMI_PMIC=m
 CONFIG_QCOM_COINCELL=m
 
 ##
+## file: drivers/misc/ti-st/Kconfig
+##
+CONFIG_TI_ST=m
+
+##
 ## file: drivers/mmc/Kconfig
 ##
 CONFIG_MMC=y
@@ -341,6 +377,15 @@ CONFIG_AMD_XGBE=m
 CONFIG_NET_XGENE=m
 
 ##
+## file: drivers/net/ethernet/cavium/Kconfig
+##
+CONFIG_NET_VENDOR_CAVIUM=y
+CONFIG_THUNDER_NIC_PF=m
+CONFIG_THUNDER_NIC_VF=m
+CONFIG_THUNDER_NIC_BGX=m
+CONFIG_THUNDER_NIC_RGX=m
+
+##
 ## file: drivers/net/ethernet/dec/tulip/Kconfig
 ##
 CONFIG_NET_TULIP=y
@@ -413,6 +458,8 @@ CONFIG_SKFP=m
 ## file: drivers/net/phy/Kconfig
 ##
 CONFIG_MDIO_HISI_FEMAC=m
+CONFIG_MDIO_THUNDER=m
+CONFIG_MDIO_XGENE=m
 
 ##
 ## file: drivers/net/wireless/ath/wcn36xx/Kconfig
@@ -462,6 +509,8 @@ CONFIG_PCI_HOST_GENERIC=y
 CONFIG_PCI_XGENE=y
 CONFIG_PCI_HISI=y
 CONFIG_PCIE_QCOM=y
+CONFIG_PCI_HOST_THUNDER_PEM=y
+CONFIG_PCI_HOST_THUNDER_ECAM=y
 CONFIG_PCIE_ARMADA_8K=y
 
 ##
@@ -481,6 +530,7 @@ CONFIG_PHY_TEGRA_XUSB=m
 ##
 ## file: drivers/pinctrl/Kconfig
 ##
+CONFIG_PINCTRL_AMD=y
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_PINCTRL_MAX77620=y
 
@@ -601,6 +651,8 @@ CONFIG_SPI_QUP=m
 CONFIG_SPI_TEGRA114=m
 CONFIG_SPI_TEGRA20_SFLASH=m
 CONFIG_SPI_TEGRA20_SLINK=m
+CONFIG_SPI_THUNDERX=m
+CONFIG_SPI_SPIDEV=m
 
 ##
 ## file: drivers/spmi/Kconfig
@@ -682,6 +734,18 @@ CONFIG_USB_DWC3_DUAL_ROLE=y
 ## file: drivers/usb/gadget/Kconfig
 ##
 CONFIG_USB_GADGET=m
+CONFIG_USB_CONFIGFS=m
+
+##
+## file: drivers/usb/gadget/legacy/Kconfig
+##
+CONFIG_USB_ETH=m
+CONFIG_USB_ETH_RNDIS=y
+CONFIG_USB_GADGETFS=m
+CONFIG_USB_FUNCTIONFS=m
+CONFIG_USB_FUNCTIONFS_ETH=y
+CONFIG_USB_FUNCTIONFS_RNDIS=y
+CONFIG_USB_FUNCTIONFS_GENERIC=y
 
 ##
 ## file: drivers/usb/host/Kconfig
@@ -732,6 +796,11 @@ CONFIG_BCM2835_WDT=m
 CONFIG_PSTORE=y
 
 ##
+## file: mm/Kconfig
+##
+CONFIG_CMA=y
+
+##
 ## file: net/bluetooth/Kconfig
 ##
 CONFIG_BT_LEDS=y
@@ -755,6 +824,7 @@ CONFIG_SND_BCM2835_SOC_I2S=m
 ## file: sound/soc/qcom/Kconfig
 ##
 CONFIG_SND_SOC_QCOM=m
+CONFIG_SND_SOC_APQ8016_SBC=m
 
 ##
 ## file: sound/soc/tegra/Kconfig
-- 
2.11.0

[toc] | [next] | [standalone]


#56688

FromRiku Voipio <riku.voipio@iki.fi>
Date2017-01-23 10:00 +0100
Message-ID<t2IDM-4em-31@gated-at.bofh.it>
In reply to#56540
On Fri, Jan 13, 2017 at 04:41:47PM +0200, riku.voipio@linaro.org wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
> 
> * Enable Cavium ThunderX server architecutre
> * Enable server related options
> * Enable CMA for DB410c DRM
> * Some missing gpio driver enabled in upstream defconfig
> * DT cpufreq, spidev and missing DB410c audio setting

Ping? Or would it be better to re-send this to BTS?

Riku

> ---
>  debian/config/arm64/config | 70 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/debian/config/arm64/config b/debian/config/arm64/config
> index f87157346..08c42e7e5 100644
> --- a/debian/config/arm64/config
> +++ b/debian/config/arm64/config
> @@ -9,11 +9,13 @@ CONFIG_ARM64_ERRATUM_834220=y
>  CONFIG_ARM64_VA_BITS_48=y
>  ## end choice
>  CONFIG_SCHED_MC=y
> +CONFIG_NUMA=y
>  CONFIG_SECCOMP=y
>  CONFIG_XEN=y
>  CONFIG_RANDOMIZE_BASE=y
>  CONFIG_RANDOMIZE_MODULE_REGION_FULL=y
>  CONFIG_EFI_SECURE_BOOT_SECURELEVEL=y
> +CONFIG_ARM64_ACPI_PARKING_PROTOCOL=y
>  CONFIG_COMPAT=y
>  
>  ##
> @@ -44,6 +46,7 @@ CONFIG_ARCH_MVEBU=y
>  CONFIG_ARCH_QCOM=y
>  CONFIG_ARCH_SEATTLE=y
>  CONFIG_ARCH_TEGRA=y
> +CONFIG_ARCH_THUNDER=y
>  CONFIG_ARCH_VEXPRESS=y
>  CONFIG_ARCH_XGENE=y
>  
> @@ -51,6 +54,7 @@ CONFIG_ARCH_XGENE=y
>  ## file: drivers/acpi/Kconfig
>  ##
>  CONFIG_ACPI=y
> +CONFIG_ACPI_NUMA=y
>  
>  ##
>  ## file: drivers/ata/Kconfig
> @@ -59,6 +63,13 @@ CONFIG_SATA_AHCI_PLATFORM=m
>  CONFIG_AHCI_MVEBU=m
>  CONFIG_AHCI_TEGRA=m
>  CONFIG_AHCI_XGENE=m
> +CONFIG_SATA_AHCI_SEATTLE=m
> +
> +##
> +## file: drivers/base/Kconfig
> +##
> +CONFIG_DMA_CMA=y
> +CONFIG_CMA_SIZE_MBYTES=64
>  
>  ##
>  ## file: drivers/bluetooth/Kconfig
> @@ -78,6 +89,8 @@ CONFIG_TEGRA_ACONNECT=y
>  CONFIG_HW_RANDOM_BCM2835=m
>  CONFIG_HW_RANDOM_HISI=m
>  CONFIG_HW_RANDOM_MSM=m
> +CONFIG_HW_RANDOM_XGENE=m
> +CONFIG_HW_RANDOM_CAVIUM=m
>  
>  ##
>  ## file: drivers/char/ipmi/Kconfig
> @@ -105,6 +118,11 @@ CONFIG_MSM_GCC_8996=y
>  CONFIG_MSM_MMCC_8996=y
>  
>  ##
> +## file: drivers/cpufreq/Kconfig
> +##
> +CONFIG_CPUFREQ_DT=m
> +
> +##
>  ## file: drivers/cpuidle/Kconfig.arm
>  ##
>  CONFIG_ARM_CPUIDLE=y
> @@ -119,6 +137,7 @@ CONFIG_CRYPTO_DEV_QCE=m
>  ##
>  CONFIG_DMADEVICES=y
>  CONFIG_DMA_BCM2835=y
> +CONFIG_K3_DMA=m
>  CONFIG_MV_XOR=y
>  CONFIG_MV_XOR_V2=y
>  CONFIG_TEGRA20_APB_DMA=y
> @@ -155,6 +174,9 @@ CONFIG_RASPBERRYPI_FIRMWARE=y
>  ## file: drivers/gpio/Kconfig
>  ##
>  CONFIG_GPIOLIB=y
> +CONFIG_GPIO_PL061=y
> +CONFIG_GPIO_XGENE=y
> +CONFIG_GPIO_XGENE_SB=m
>  CONFIG_GPIO_PCA953X=y
>  CONFIG_GPIO_PCA953X_IRQ=y
>  CONFIG_GPIO_MAX77620=y
> @@ -205,6 +227,11 @@ CONFIG_DRM_VC4=m
>  CONFIG_TEGRA_HOST1X=m
>  
>  ##
> +## file: drivers/hwmon/Kconfig
> +##
> +CONFIG_SENSORS_XGENE=m
> +
> +##
>  ## file: drivers/hwspinlock/Kconfig
>  ##
>  CONFIG_HWSPINLOCK_QCOM=m
> @@ -222,6 +249,7 @@ CONFIG_I2C_DESIGNWARE_PLATFORM=m
>  CONFIG_I2C_MV64XXX=m
>  CONFIG_I2C_QUP=m
>  CONFIG_I2C_TEGRA=m
> +CONFIG_I2C_THUNDERX=m
>  CONFIG_I2C_CROS_EC_TUNNEL=m
>  CONFIG_I2C_XGENE_SLIMPRO=m
>  
> @@ -234,6 +262,7 @@ CONFIG_QCOM_SPMI_VADC=m
>  ##
>  ## file: drivers/input/keyboard/Kconfig
>  ##
> +CONFIG_KEYBOARD_GPIO=m
>  CONFIG_KEYBOARD_TEGRA=m
>  
>  ##
> @@ -248,6 +277,8 @@ CONFIG_INPUT_HISI_POWERKEY=m
>  ## file: drivers/iommu/Kconfig
>  ##
>  CONFIG_TEGRA_IOMMU_SMMU=y
> +CONFIG_ARM_SMMU=y
> +CONFIG_ARM_SMMU_V3=y
>  
>  ##
>  ## file: drivers/leds/Kconfig
> @@ -284,6 +315,11 @@ CONFIG_MFD_SPMI_PMIC=m
>  CONFIG_QCOM_COINCELL=m
>  
>  ##
> +## file: drivers/misc/ti-st/Kconfig
> +##
> +CONFIG_TI_ST=m
> +
> +##
>  ## file: drivers/mmc/Kconfig
>  ##
>  CONFIG_MMC=y
> @@ -341,6 +377,15 @@ CONFIG_AMD_XGBE=m
>  CONFIG_NET_XGENE=m
>  
>  ##
> +## file: drivers/net/ethernet/cavium/Kconfig
> +##
> +CONFIG_NET_VENDOR_CAVIUM=y
> +CONFIG_THUNDER_NIC_PF=m
> +CONFIG_THUNDER_NIC_VF=m
> +CONFIG_THUNDER_NIC_BGX=m
> +CONFIG_THUNDER_NIC_RGX=m
> +
> +##
>  ## file: drivers/net/ethernet/dec/tulip/Kconfig
>  ##
>  CONFIG_NET_TULIP=y
> @@ -413,6 +458,8 @@ CONFIG_SKFP=m
>  ## file: drivers/net/phy/Kconfig
>  ##
>  CONFIG_MDIO_HISI_FEMAC=m
> +CONFIG_MDIO_THUNDER=m
> +CONFIG_MDIO_XGENE=m
>  
>  ##
>  ## file: drivers/net/wireless/ath/wcn36xx/Kconfig
> @@ -462,6 +509,8 @@ CONFIG_PCI_HOST_GENERIC=y
>  CONFIG_PCI_XGENE=y
>  CONFIG_PCI_HISI=y
>  CONFIG_PCIE_QCOM=y
> +CONFIG_PCI_HOST_THUNDER_PEM=y
> +CONFIG_PCI_HOST_THUNDER_ECAM=y
>  CONFIG_PCIE_ARMADA_8K=y
>  
>  ##
> @@ -481,6 +530,7 @@ CONFIG_PHY_TEGRA_XUSB=m
>  ##
>  ## file: drivers/pinctrl/Kconfig
>  ##
> +CONFIG_PINCTRL_AMD=y
>  CONFIG_PINCTRL_SINGLE=y
>  CONFIG_PINCTRL_MAX77620=y
>  
> @@ -601,6 +651,8 @@ CONFIG_SPI_QUP=m
>  CONFIG_SPI_TEGRA114=m
>  CONFIG_SPI_TEGRA20_SFLASH=m
>  CONFIG_SPI_TEGRA20_SLINK=m
> +CONFIG_SPI_THUNDERX=m
> +CONFIG_SPI_SPIDEV=m
>  
>  ##
>  ## file: drivers/spmi/Kconfig
> @@ -682,6 +734,18 @@ CONFIG_USB_DWC3_DUAL_ROLE=y
>  ## file: drivers/usb/gadget/Kconfig
>  ##
>  CONFIG_USB_GADGET=m
> +CONFIG_USB_CONFIGFS=m
> +
> +##
> +## file: drivers/usb/gadget/legacy/Kconfig
> +##
> +CONFIG_USB_ETH=m
> +CONFIG_USB_ETH_RNDIS=y
> +CONFIG_USB_GADGETFS=m
> +CONFIG_USB_FUNCTIONFS=m
> +CONFIG_USB_FUNCTIONFS_ETH=y
> +CONFIG_USB_FUNCTIONFS_RNDIS=y
> +CONFIG_USB_FUNCTIONFS_GENERIC=y
>  
>  ##
>  ## file: drivers/usb/host/Kconfig
> @@ -732,6 +796,11 @@ CONFIG_BCM2835_WDT=m
>  CONFIG_PSTORE=y
>  
>  ##
> +## file: mm/Kconfig
> +##
> +CONFIG_CMA=y
> +
> +##
>  ## file: net/bluetooth/Kconfig
>  ##
>  CONFIG_BT_LEDS=y
> @@ -755,6 +824,7 @@ CONFIG_SND_BCM2835_SOC_I2S=m
>  ## file: sound/soc/qcom/Kconfig
>  ##
>  CONFIG_SND_SOC_QCOM=m
> +CONFIG_SND_SOC_APQ8016_SBC=m
>  
>  ##
>  ## file: sound/soc/tegra/Kconfig
> -- 
> 2.11.0
> 

[toc] | [prev] | [next] | [standalone]


#56716

FromBen Hutchings <ben@decadent.org.uk>
Date2017-01-24 03:30 +0100
Message-ID<t2Z1U-6Az-13@gated-at.bofh.it>
In reply to#56540

[Multipart message — attachments visible in raw view] — view raw

On Fri, 2017-01-13 at 16:41 +0200, riku.voipio@linaro.org wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
> 
> * Enable Cavium ThunderX server architecutre
> * Enable server related options
> * Enable CMA for DB410c DRM

CMA and NUMA both require an ABI bump (which we'll do at some point
before release, but probably not the next upload).

> * Some missing gpio driver enabled in upstream defconfig
> * DT cpufreq, spidev and missing DB410c audio setting
> ---
[...]
> +##
> +## file: drivers/base/Kconfig
> +##
> +CONFIG_DMA_CMA=y
> +CONFIG_CMA_SIZE_MBYTES=64

I notice this is higher than the default (16).  Is it a sensible
default for all/most platforms that will need CMA?  What about
platforms that don't use CMA at all, where the CMA zone will be wasted?

[...]
>  @@ -682,6 +734,18 @@ CONFIG_USB_DWC3_DUAL_ROLE=y
>  ## file: drivers/usb/gadget/Kconfig
>  ##
>  CONFIG_USB_GADGET=m
> +CONFIG_USB_CONFIGFS=m

I don't think that does anything useful unless we also enable some more
CONFIG_USB_CONFIGFS_* options.

> +
> +##
> +## file: drivers/usb/gadget/legacy/Kconfig
> +##
> +CONFIG_USB_ETH=m
> +CONFIG_USB_ETH_RNDIS=y
> +CONFIG_USB_GADGETFS=m
> +CONFIG_USB_FUNCTIONFS=m
> +CONFIG_USB_FUNCTIONFS_ETH=y
> +CONFIG_USB_FUNCTIONFS_RNDIS=y
> +CONFIG_USB_FUNCTIONFS_GENERIC=y
[...]

I think the gadget config should be consolidated in
debian/config/config, leaving individual architectures to enable only
CONFIG_USB_GADGET and driver-specific symbols for gadget support.  Can
you do that as a preparatory patch?

Ben.

-- 
Ben Hutchings
Never put off till tomorrow what you can avoid all together.

[toc] | [prev] | [next] | [standalone]


#56725

FromRiku Voipio <riku.voipio@linaro.org>
Date2017-01-24 11:00 +0100
Message-ID<t363n-2EC-1@gated-at.bofh.it>
In reply to#56716
On 24 January 2017 at 04:21, Ben Hutchings <ben@decadent.org.uk> wrote:
> On Fri, 2017-01-13 at 16:41 +0200, riku.voipio@linaro.org wrote:
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> * Enable Cavium ThunderX server architecutre
>> * Enable server related options
>> * Enable CMA for DB410c DRM
>
> CMA and NUMA both require an ABI bump (which we'll do at some point
> before release, but probably not the next upload).
>
>> * Some missing gpio driver enabled in upstream defconfig
>> * DT cpufreq, spidev and missing DB410c audio setting
>> ---
> [...]
>> +##
>> +## file: drivers/base/Kconfig
>> +##
>> +CONFIG_DMA_CMA=y
>> +CONFIG_CMA_SIZE_MBYTES=64
>
> I notice this is higher than the default (16).  Is it a sensible
> default for all/most platforms that will need CMA?  What about
> platforms that don't use CMA at all, where the CMA zone will be wasted?

CMA memory isn't wasted. It is populated with movable pages until a
CMA user needs a continuous block from it. Userspace (unless mlocked)
and cache/buffers are all movable, so I don't think CMA would be
underutilized in memory pressure scenarios.

16M was not enough for getting DRM display on dragonboard 410c. I can
check what is the minimum needed.

> [...]
>>  @@ -682,6 +734,18 @@ CONFIG_USB_DWC3_DUAL_ROLE=y
>>  ## file: drivers/usb/gadget/Kconfig
>>  ##
>>  CONFIG_USB_GADGET=m
>> +CONFIG_USB_CONFIGFS=m
>
> I don't think that does anything useful unless we also enable some more
> CONFIG_USB_CONFIGFS_* options.

Gah, the set of configfs, functionfs and gadgetfs is so confusing here..

>> +
>> +##
>> +## file: drivers/usb/gadget/legacy/Kconfig
>> +##
>> +CONFIG_USB_ETH=m
>> +CONFIG_USB_ETH_RNDIS=y
>> +CONFIG_USB_GADGETFS=m
>> +CONFIG_USB_FUNCTIONFS=m
>> +CONFIG_USB_FUNCTIONFS_ETH=y
>> +CONFIG_USB_FUNCTIONFS_RNDIS=y
>> +CONFIG_USB_FUNCTIONFS_GENERIC=y
> [...]
>
> I think the gadget config should be consolidated in
> debian/config/config, leaving individual architectures to enable only
> CONFIG_USB_GADGET and driver-specific symbols for gadget support.  Can
> you do that as a preparatory patch?

Ok, I'll have a look.

Riku

[toc] | [prev] | [next] | [standalone]


#56727

FromBen Hutchings <ben@decadent.org.uk>
Date2017-01-24 13:30 +0100
Message-ID<t38oy-4f8-27@gated-at.bofh.it>
In reply to#56725

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2017-01-24 at 11:35 +0200, Riku Voipio wrote:
> On 24 January 2017 at 04:21, Ben Hutchings <ben@decadent.org.uk>
> wrote:
> > On Fri, 2017-01-13 at 16:41 +0200, riku.voipio@linaro.org wrote:
> > > From: Riku Voipio <riku.voipio@linaro.org>
> > > 
> > > * Enable Cavium ThunderX server architecutre
> > > * Enable server related options
> > > * Enable CMA for DB410c DRM
> > 
> > CMA and NUMA both require an ABI bump (which we'll do at some point
> > before release, but probably not the next upload).
> > 
> > > * Some missing gpio driver enabled in upstream defconfig
> > > * DT cpufreq, spidev and missing DB410c audio setting
> > > ---
> > 
> > [...]
> > > +##
> > > +## file: drivers/base/Kconfig
> > > +##
> > > +CONFIG_DMA_CMA=y
> > > +CONFIG_CMA_SIZE_MBYTES=64
> > 
> > I notice this is higher than the default (16).  Is it a sensible
> > default for all/most platforms that will need CMA?  What about
> > platforms that don't use CMA at all, where the CMA zone will be
> > wasted?
> 
> CMA memory isn't wasted. It is populated with movable pages until a
> CMA user needs a continuous block from it. Userspace (unless mlocked)
> and cache/buffers are all movable, so I don't think CMA would be
> underutilized in memory pressure scenarios.

Oh, yes I see.

> 16M was not enough for getting DRM display on dragonboard 410c. I can
> check what is the minimum needed.

Given a single full-HD frame needs 8 MiB, I can see 16 MiB total would
be too small.  But then, multiply by 4 for 4K frames, and 64 MiB would
also be constraining.  (I don't know whether we currently support any
hardware with 4K output.)

Perhaps it would make sense to set a percentage instead (e.g.
CONFIG_CMA_SIZE_MBYTES=0, CONFIG_CMA_SIZE_PERCENTAGE=10)?

> > [...]
> > >  @@ -682,6 +734,18 @@ CONFIG_USB_DWC3_DUAL_ROLE=y
> > >  ## file: drivers/usb/gadget/Kconfig
> > >  ##
> > >  CONFIG_USB_GADGET=m
> > > +CONFIG_USB_CONFIGFS=m
> > 
> > I don't think that does anything useful unless we also enable some more
> > CONFIG_USB_CONFIGFS_* options.
> 
> Gah, the set of configfs, functionfs and gadgetfs is so confusing
> here..
[...]

Yes it is!

Ben.

-- 
Ben Hutchings
Never put off till tomorrow what you can avoid all together.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.kernel


csiph-web