Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #55081 > unrolled thread

Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture

Back to article view | Back to linux.debian.kernel

Contents

  Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Helge Deller <deller@gmx.de> - 2016-09-12 18:30 +0200
    Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Ben Hutchings <ben@decadent.org.uk> - 2016-09-12 21:40 +0200
      Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Ben Hutchings <ben@decadent.org.uk> - 2016-09-19 19:50 +0200
        Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Helge Deller <deller@gmx.de> - 2016-09-19 21:00 +0200
          Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Ben Hutchings <ben@decadent.org.uk> - 2016-09-19 21:10 +0200
            Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Helge Deller <deller@gmx.de> - 2016-09-22 21:30 +0200
              Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture Ben Hutchings <ben@decadent.org.uk> - 2016-09-23 01:50 +0200
                Bug#837588: vmlinux in linux-image packages is unstripped Ben Hutchings <ben@decadent.org.uk> - 2016-09-23 05:50 +0200
                  Bug#837588: vmlinux in linux-image packages is unstripped Helge Deller <deller@gmx.de> - 2016-09-27 15:00 +0200
                    Bug#837588: vmlinux in linux-image packages is unstripped Ben Hutchings <ben@decadent.org.uk> - 2016-09-27 21:10 +0200
                      Bug#837588: vmlinux in linux-image packages is unstripped Helge Deller <deller@gmx.de> - 2016-09-27 23:20 +0200
                        Bug#837588: vmlinux in linux-image packages is unstripped Ben Hutchings <ben@decadent.org.uk> - 2016-09-30 23:30 +0200
                          Bug#837588: vmlinux in linux-image packages is unstripped Helge Deller <deller@gmx.de> - 2016-10-01 22:30 +0200
    Processed: Re: Bug#837588: hppa: Please disable CONFIG_FTRACE for  hppa architecture owner@bugs.debian.org (Debian Bug Tracking System) - 2016-09-12 21:40 +0200
    Processed: Re: Bug#837588: hppa: Please disable CONFIG_FTRACE for  hppa architecture owner@bugs.debian.org (Debian Bug Tracking System) - 2016-09-23 01:50 +0200

#55081 — Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture

Package: linux
Version: 4.7.2-1
Severity: important

We sadly will need to disable CONFIG_FTRACE for hppa architecture completely for now.

The problem is, that gcc creates lots of overhead when adding the code for the
mcount call (minimum 16 bytes per function, plus two relocation symbol entries)
which leads that the 64bit vmlinux kernel file for 4.7 becomes around 99MB, while
vmlinux for kernel 4.6 was just around 17MB. This size wouldn't be a real problem itself,
but sadly the default /boot partition is currently maximum 128 MB in size which
is not able to keep the vmlinux file plus the size for the initrd image (which is a lot
bigger than 100MB then).
That leads to the fact, that people who have a default hppa installation will not
be able to install the new kernel (and don't have space in /boot to keep other older
images either).

So, can you please deactivate CONFIG_FTRACE completely for 32- and 64bit hppa configs?
Is it sufficient to add "CONFIG_FTRACE=n" to debian/config/hppa/config ?

Thanks!
Helge

PS: I'm still working on upstream ftrace support for hppa. It's not complete yet, so
we don't loose to much when we disable ftrace again now. Further more I will adjust the
debian installer to create bigger /boot partitions so that we can enable it later again.

[toc] | [next] | [standalone]

#55082

[Multipart message — attachments visible in raw view] — view raw

Control: tag -1 pending

On Mon, 2016-09-12 at 18:17 +0200, Helge Deller wrote:
[...]
> So, can you please deactivate CONFIG_FTRACE completely for 32- and 64bit hppa configs?
> Is it sufficient to add "CONFIG_FTRACE=n" to debian/config/hppa/config ?

Done.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy
others.

[toc] | [prev] | [next] | [standalone]

#55159

[Multipart message — attachments visible in raw view] — view raw

On Mon, 2016-09-12 at 20:28 +0100, Ben Hutchings wrote:
> Control: tag -1 pending
> 
> On Mon, 2016-09-12 at 18:17 +0200, Helge Deller wrote:
> [...]
> > 
> > So, can you please deactivate CONFIG_FTRACE completely for 32- and
> > 64bit hppa configs?
> > Is it sufficient to add "CONFIG_FTRACE=n" to
> > debian/config/hppa/config ?
> 
> Done.

But this changes the module ABI, resulting in FTBFS.  From what you've
said on this bug, I'm not sure whether the previous version (4.7.2-1)
was at all usable.  If not then I will delete the ABI reference for
hppa so the change is ignored.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy
others.

[toc] | [prev] | [next] | [standalone]

#55160

[Multipart message — attachments visible in raw view] — view raw

Hi Ben,

On 19.09.2016 19:41, Ben Hutchings wrote:
> On Mon, 2016-09-12 at 20:28 +0100, Ben Hutchings wrote:
>> On Mon, 2016-09-12 at 18:17 +0200, Helge Deller wrote:
>>> So, can you please deactivate CONFIG_FTRACE completely for 32- and
>>> 64bit hppa configs?
>>> Is it sufficient to add "CONFIG_FTRACE=n" to
>>> debian/config/hppa/config ?
>>
>> Done.
> 
> But this changes the module ABI, resulting in FTBFS.  From what you've
> said on this bug, I'm not sure whether the previous version (4.7.2-1)
> was at all usable. 

I was able to boot the 4.7.2-1 kernel on one of my machines where /boot was big enough.
The hppa buildd servers have smaller /boot partitions though  nd the kernel was not useable/installable there.

> If not then I will delete the ABI reference for
> hppa so the change is ignored.

I'd propose to delete the ABI reference.
I'm not aware of any hppa-relevant out-of-tree kernel modules either.

Helge

[toc] | [prev] | [next] | [standalone]

#55161

[Multipart message — attachments visible in raw view] — view raw

On Mon, 2016-09-19 at 20:50 +0200, Helge Deller wrote:
> Hi Ben,
> 
> On 19.09.2016 19:41, Ben Hutchings wrote:
> > 
> > On Mon, 2016-09-12 at 20:28 +0100, Ben Hutchings wrote:
> > > 
> > > On Mon, 2016-09-12 at 18:17 +0200, Helge Deller wrote:
> > > > 
> > > > So, can you please deactivate CONFIG_FTRACE completely for 32- and
> > > > 64bit hppa configs?
> > > > Is it sufficient to add "CONFIG_FTRACE=n" to
> > > > debian/config/hppa/config ?
> > > 
> > > Done.
> > 
> > But this changes the module ABI, resulting in FTBFS.  From what you've
> > said on this bug, I'm not sure whether the previous version (4.7.2-1)
> > was at all usable. 
> 
> I was able to boot the 4.7.2-1 kernel on one of my machines where /boot was big enough.
> The hppa buildd servers have smaller /boot partitions though  nd the kernel was not useable/installable there.
> 
> > 
> > If not then I will delete the ABI reference for
> > hppa so the change is ignored.
> 
> I'd propose to delete the ABI reference.
> I'm not aware of any hppa-relevant out-of-tree kernel modules either.

OK.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy
others.

[toc] | [prev] | [next] | [standalone]

#55183

[Multipart message — attachments visible in raw view] — view raw

Hi Ben,

On 19.09.2016 20:56, Ben Hutchings wrote:
> On Mon, 2016-09-19 at 20:50 +0200, Helge Deller wrote:
>> On 19.09.2016 19:41, Ben Hutchings wrote:
>>> On Mon, 2016-09-12 at 20:28 +0100, Ben Hutchings wrote:
>>>> On Mon, 2016-09-12 at 18:17 +0200, Helge Deller wrote:
>>>>>
>>>>> So, can you please deactivate CONFIG_FTRACE completely for 32- and
>>>>> 64bit hppa configs?
>>>>> Is it sufficient to add "CONFIG_FTRACE=n" to
>>>>> debian/config/hppa/config ?
>>>>
>>>> Done.

Argh - this didn't fixed the size issues on hppa.
I was under the wrong assumption, that CONFIG_FTRACE (which was implemented in
kernel 4.7 for the first time) was the culprit which increased the kernel size.
This assumption was wrong.

The attached patch finally fixes the issue.
It re-enables the CONFIG_FTRACE option (which is set by your upper config files),
and disables CONFIG_DEBUG_INFO which was now suddenly enabled by the debian
kernel 4.7 (it wasn't in 4.6!).
I enabled CONFIG_DEBUG_RODATA to write-protect kernel memory as well.

The main problem was, that the generated dwarf debug info increases the 
kernel vmlinux image from 17MB to 97MB in disk size.
I've compile- and run-tested the patch and built a +b1 kernel. 

Can you apply the attached patch on top of current git?
I can commit it myself as well if you like.

Thanks!
Helge

[toc] | [prev] | [next] | [standalone]

#55187

[Multipart message — attachments visible in raw view] — view raw

Control: reopen -1
Control: retitle -1 vmlinux in linux-image packages is unstripped

On Thu, 2016-09-22 at 21:18 +0200, Helge Deller wrote:
> Hi Ben,
> 
> On 19.09.2016 20:56, Ben Hutchings wrote:
> > 
> > On Mon, 2016-09-19 at 20:50 +0200, Helge Deller wrote:
> > > 
> > > On 19.09.2016 19:41, Ben Hutchings wrote:
> > > > 
> > > > On Mon, 2016-09-12 at 20:28 +0100, Ben Hutchings wrote:
> > > > > 
> > > > > On Mon, 2016-09-12 at 18:17 +0200, Helge Deller wrote:
> > > > > > 
> > > > > > 
> > > > > > So, can you please deactivate CONFIG_FTRACE completely for 32- and
> > > > > > 64bit hppa configs?
> > > > > > Is it sufficient to add "CONFIG_FTRACE=n" to
> > > > > > debian/config/hppa/config ?
> > > > > 
> > > > > Done.
> 
> Argh - this didn't fixed the size issues on hppa.
> I was under the wrong assumption, that CONFIG_FTRACE (which was implemented in
> kernel 4.7 for the first time) was the culprit which increased the kernel size.
> This assumption was wrong.
> 
> The attached patch finally fixes the issue.
> It re-enables the CONFIG_FTRACE option (which is set by your upper config files),
> and disables CONFIG_DEBUG_INFO which was now suddenly enabled by the debian
> kernel 4.7 (it wasn't in 4.6!).
> I enabled CONFIG_DEBUG_RODATA to write-protect kernel memory as well.
> 
> The main problem was, that the generated dwarf debug info increases the 
> kernel vmlinux image from 17MB to 97MB in disk size.
> I've compile- and run-tested the patch and built a +b1 kernel. 
> 
> Can you apply the attached patch on top of current git?
> I can commit it myself as well if you like.

This is not the correct fix, nor is this an hppa-specific problem.  We
need to strip debug information out of the kernel image that goes into
linux-image-<version>[-unsigned], and currently we don't do that
explicitly.  Previously we only enabled debug information for x86 and
s390, and for those the upstream build rules already strip debug
information before compressing the kernel.

Here's the current status, so far as I can see:

alpha:       vmlinux.gz, stripped(?) and compressed
arm64:       Image, stripped and uncompressed
armel,armhf: zImage,
stripped and compressed
hppa:        vmlinux, UNstripped and
uncompressed
m68k:        vmlinux.gz, stripped and compressed
mips*:    
  vmlinux, UNstripped and uncompressed
powerpc*:    vmlinux, UNstripped
and uncompressed
s390x:       image, stripped and uncompressed
sh4:      
  zImage, stripped(?) and compressed
sparc64:     zImage, stripped and
compressed
x86:         bzImage, stripped and compressed

(No binary packages of 4.7 are available on ftp.debian-ports.org for
alpha or sh4 yet, so those results are based on reading the respective
Makefiles.)

It seems that we only need a special case in debian/rules.real for
those architectures where we install vmlinux directly.

Ben.

-- 
Ben Hutchings
The first rule of tautology club is the first rule of tautology club.

[toc] | [prev] | [next] | [standalone]

#55192 — Bug#837588: vmlinux in linux-image packages is unstripped

[Multipart message — attachments visible in raw view] — view raw

I pushed a fix to the sid branch which I've tested on a powerpc
porterbox.

Ben.

-- 
Ben Hutchings
A free society is one where it is safe to be unpopular. - Adlai
Stevenson

[toc] | [prev] | [next] | [standalone]

#55238 — Bug#837588: vmlinux in linux-image packages is unstripped

Hi Ben,

On 23.09.2016 05:39, Ben Hutchings wrote:
> I pushed a fix to the sid branch which I've tested on a powerpc
> porterbox.

The addition of 
 dh_strip --no-automatic-dbgsym

broke the 64bit parisc/hppa kernel build:

dh_strip --no-automatic-dbgsym
strip:debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp: File format not recognized
dh_strip: strip --remove-section=.comment --remove-section=.note debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp returned exit code 1
debian/rules.real:381: recipe for target 'install-image_hppa_none_parisc64-smp' failed

I'm currently testing this patch (not sure if this is a good patch though):
- dh_strip --no-automatic-dbgsym
+ $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note '$(DIR)/$(IMAGE_FILE)'

Helge

[toc] | [prev] | [next] | [standalone]

#55243 — Bug#837588: vmlinux in linux-image packages is unstripped

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote:
> Hi Ben,
> 
> On 23.09.2016 05:39, Ben Hutchings wrote:
> > 
> > I pushed a fix to the sid branch which I've tested on a powerpc
> > porterbox.
> 
> The addition of 
>  dh_strip --no-automatic-dbgsym
> 
> broke the 64bit parisc/hppa kernel build:

That's strange, because it's not really an addition (we've always run
dh_strip).

[...]
> I'm currently testing this patch (not sure if this is a good patch though):
> - dh_strip --no-automatic-dbgsym
> + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note '$(DIR)/$(IMAGE_FILE)'

This is not correct because we do want to strip the userland tools that
get included in powerpc builds.  We could add -Xvmlinux to the dh_strip
command to make sure it doesn't touch the kernel.

vmlinux is being stripped using $(CROSS_COMPILE)objcopy, but I wonder
whether we should be using hppa64-linux-gnu-objcopy instead for the 64-
bit kernel?

Ben.

-- 
Ben Hutchings
If the facts do not conform to your theory, they must be disposed of.

[toc] | [prev] | [next] | [standalone]

#55244 — Bug#837588: vmlinux in linux-image packages is unstripped

[Multipart message — attachments visible in raw view] — view raw

Hi Ben,

On 27.09.2016 21:07, Ben Hutchings wrote:
> On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote:
>> On 23.09.2016 05:39, Ben Hutchings wrote:
>>>
>>> I pushed a fix to the sid branch which I've tested on a powerpc
>>> porterbox.
>>
>> The addition of 
>>  dh_strip --no-automatic-dbgsym
>>
>> broke the 64bit parisc/hppa kernel build:
> 
> That's strange, because it's not really an addition (we've always run
> dh_strip).
> 
> [...]
>> I'm currently testing this patch (not sure if this is a good patch though):
>> - dh_strip --no-automatic-dbgsym
>> + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note '$(DIR)/$(IMAGE_FILE)'
> 
> This is not correct because we do want to strip the userland tools that
> get included in powerpc builds.  We could add -Xvmlinux to the dh_strip
> command to make sure it doesn't touch the kernel.

Since the error is:
strip:debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp: File format not recognized
I think you would need something like -X$(IMAGE_FILE)
 
> vmlinux is being stripped using $(CROSS_COMPILE)objcopy, but I wonder
> whether we should be using hppa64-linux-gnu-objcopy instead for the 64-
> bit kernel?

I think $(CROSS_COMPILE)objcopy expands to hppa64-linux-gnu-objcopy when packaging
the 64bit kernel. At least my patch worked which seems to indicate that.

Anyhow, I'm fine with any patch you agree on and which fixes the problem.

Helge

[toc] | [prev] | [next] | [standalone]

#55271 — Bug#837588: vmlinux in linux-image packages is unstripped

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2016-09-27 at 23:09 +0200, Helge Deller wrote:
> Hi Ben,
> 
> On 27.09.2016 21:07, Ben Hutchings wrote:
> > 
> > On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote:
> > > 
> > > On 23.09.2016 05:39, Ben Hutchings wrote:
> > > > 
> > > > 
> > > > I pushed a fix to the sid branch which I've tested on a powerpc
> > > > porterbox.
> > > 
> > > The addition of 
> > >  dh_strip --no-automatic-dbgsym
> > > 
> > > broke the 64bit parisc/hppa kernel build:
> > 
> > That's strange, because it's not really an addition (we've always run
> > dh_strip).
> > 
> > [...]
> > > 
> > > I'm currently testing this patch (not sure if this is a good patch though):
> > > - dh_strip --no-automatic-dbgsym
> > > + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note '$(DIR)/$(IMAGE_FILE)'
> > 
> > This is not correct because we do want to strip the userland tools that
> > get included in powerpc builds.  We could add -Xvmlinux to the dh_strip
> > command to make sure it doesn't touch the kernel.
> 
> Since the error is:
> strip:debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp: File format not recognized
> I think you would need something like -X$(IMAGE_FILE)

That should also work, but the -X option gives a substring to match,
not a wildcard or full filename.

> > 
> > vmlinux is being stripped using $(CROSS_COMPILE)objcopy, but I wonder
> > whether we should be using hppa64-linux-gnu-objcopy instead for the 64-
> > bit kernel?
> 
> I think $(CROSS_COMPILE)objcopy expands to hppa64-linux-gnu-objcopy when packaging
> the 64bit kernel. At least my patch worked which seems to indicate that.

Oh yes, I never noticed before that rules.gen defines
OVERRIDE_HOST_TYPE in this case.

> Anyhow, I'm fine with any patch you agree on and which fixes the problem.

Can you try adding -X$(IMAGE_FILE)?  I have no idea how to access any
hppa porterbox myself.

Ben.

-- 
Ben Hutchings
If the facts do not conform to your theory, they must be disposed of.

[toc] | [prev] | [next] | [standalone]

#55280 — Bug#837588: vmlinux in linux-image packages is unstripped

Hi Ben,

On 30.09.2016 23:20, Ben Hutchings wrote:
> On Tue, 2016-09-27 at 23:09 +0200, Helge Deller wrote:
>> On 27.09.2016 21:07, Ben Hutchings wrote:
>>> On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote:
>>>> On 23.09.2016 05:39, Ben Hutchings wrote:
>>>>>
>>>>> I pushed a fix to the sid branch which I've tested on a powerpc
>>>>> porterbox.
>>>>
>>>> The addition of 
>>>>  dh_strip --no-automatic-dbgsym
>>>>
>>>> broke the 64bit parisc/hppa kernel build:
>>>
>>> That's strange, because it's not really an addition (we've always run
>>> dh_strip).
>>>
>>> [...]
> 
> Can you try adding -X$(IMAGE_FILE)?  

Yes, this seems to work:
-  dh_strip --no-automatic-dbgsym
+  dh_strip --no-automatic-dbgsym -X$(IMAGE_FILE)

I had to restart my test-kernel-build because of another error,
but from the logs the build didn't failed now because of this 
dh_strip line any longer. I'll have final convidence tomorrow.
So, please add "-X$(IMAGE_FILE)" for now.


> I have no idea how to access any hppa porterbox myself.

If you need access once, just let me know. 
Maybe, if we have more machines up again, I will try to make one
accessible as porterbox.

Helge

[toc] | [prev] | [next] | [standalone]

#55083 — Processed: Re: Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture

Processing control commands:

> tag -1 pending
Bug #837588 [linux] hppa: Please disable CONFIG_FTRACE for hppa architecture
Added tag(s) pending.

-- 
837588: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837588
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#55188 — Processed: Re: Bug#837588: hppa: Please disable CONFIG_FTRACE for hppa architecture

Processing control commands:

> reopen -1
Bug #837588 {Done: Ben Hutchings <ben@decadent.org.uk>} [linux] hppa: Please disable CONFIG_FTRACE for hppa architecture
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions linux/4.7.4-1.
> retitle -1 vmlinux in linux-image packages is unstripped
Bug #837588 [linux] hppa: Please disable CONFIG_FTRACE for hppa architecture
Changed Bug title to 'vmlinux in linux-image packages is unstripped' from 'hppa: Please disable CONFIG_FTRACE for hppa architecture'.

-- 
837588: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837588
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web